Skip to content

fix: encode BlockOverrides prevRandao as a 32-byte hash - #700

Closed
Iamsohungrynow wants to merge 1 commit into
wevm:mainfrom
Iamsohungrynow:fix/block-overrides-prev-randao
Closed

Iamsohungrynow wants to merge 1 commit into
wevm:mainfrom
Iamsohungrynow:fix/block-overrides-prev-randao

Conversation

@Iamsohungrynow

Copy link
Copy Markdown
Contributor

BlockOverrides.toRpc sends prevRandao: 6n as "0x6", but geth types it as common.Hash and rejects it (hex string of odd length), so simulateBlocks with a prevRandao override fails. pads it to 32 bytes now, core and zod, fromRpc already read that form

@vercel

vercel Bot commented Nov 19, 2026

Copy link
Copy Markdown

@Iamsohungrynow is attempting to deploy a commit to the Wevm Team on Vercel.

A member of the Team first needs to authorize it.

jxom commented Nov 19, 2026

Copy link
Copy Markdown
Member

Thanks @Iamsohungrynow! We opened #704 with your change plus 256-bit bounds on the zod prevRandao codecs (so out-of-range values fail validation instead of throwing) and an updated JSDoc example, crediting you as co-author. Closing in favor of it.

@jxom jxom closed this Nov 19, 2026
jxom added a commit that referenced this pull request Nov 19, 2026
Supersedes #700.


Amp-Thread-ID: https://ampcode.com/threads/T-01a1f5cc-eb3a-72b3-bdda-0480feddb7f9

Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: Martina <261225237+Iamsohungrynow@users.noreply.github.com>
Co-authored-by: jxom <jake@tempo.xyz>
jxom added a commit that referenced this pull request Nov 19, 2026
* fix: hash zero-valued leaves in `BinaryStateTree.merkelize` (#690)

EIP-7864 only maps the 64-byte zero input to the zero hash, so a leaf set
to 32 zero bytes is a real leaf. `hash` zeroed any all-zero input, which
merkelized zero-valued leaves as empty (a lone zero leaf at the zero key
gave the empty-tree root).

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Amp-Thread-ID: https://ampcode.com/threads/T-01a1f5cc-eb3a-72b3-bdda-0480feddb7f9
Co-authored-by: jxom <jake@tempo.xyz>

* fix: encode legacy `v` above 255 in `Transaction.toRpc` (#691)

`Transaction.toRpc` encoded `v` with `size: 1` for every transaction
type. A legacy EIP-155 `v` is `chainId * 2 + 35 + yParity`, so from
chain ID 110 on (Polygon, Base, Arbitrum, ...) it passes 255 and `toRpc`
threw `Hex.IntegerOutOfRangeError`. `toRpc(fromRpc(tx))` failed on real
legacy transactions from those chains. execution-apis types the legacy
`v` as `uint` and the typed `v` as `byte`, so legacy now encodes it
without a size and typed transactions keep the single byte.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 6b94083)
Co-authored-by: jxom <jake@tempo.xyz>

* fix: encode authorization `r` and `s` as quantities in `Authorization.toRpc` (#693)

execution-apis types authorization list `r` and `s` as `uint256`, so
nodes expect them without leading zeros. `Authorization.toRpc` passed
the 32-byte padded values through, and geth-based nodes reject them in
`eth_estimateGas`, `eth_call` and `eth_sendTransaction` ("hex number
with leading zero digits") whenever the top nibble is zero.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit d7b57e1)
Co-authored-by: jxom <jake@tempo.xyz>

* fix: keep `requestsHash` in `Block.toRpc` (#703)

Supersedes #692.

Amp-Thread-ID: https://ampcode.com/threads/T-01a1f5cc-eb3a-72b3-bdda-0480feddb7f9

Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: gomes <17035424+gomesalexandre@users.noreply.github.com>
Co-authored-by: jxom <jake@tempo.xyz>
(cherry picked from commit b31cd5d)

* fix: encode `BlockOverrides` `prevRandao` as a 32-byte hash (#704)

Supersedes #700.

Amp-Thread-ID: https://ampcode.com/threads/T-01a1f5cc-eb3a-72b3-bdda-0480feddb7f9

Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: Martina <261225237+Iamsohungrynow@users.noreply.github.com>
Co-authored-by: jxom <jake@tempo.xyz>
(cherry picked from commit 9c3280b)

* fix(0.x): reject a comma in `Siwe` `scheme` and every line break in `statement`

Ports the scheme and statement parts of #705 (from #698 and #699).
The IP literal domain part does not apply to 0.x.

Co-authored-by: gomes <17035424+gomesalexandre@users.noreply.github.com>
Amp-Thread-ID: https://ampcode.com/threads/T-01a1f5cc-eb3a-72b3-bdda-0480feddb7f9
Co-authored-by: jxom <jake@tempo.xyz>

* docs: fix stated outputs in hash and selector examples (#702)

(cherry picked from commit 2d43a3a)
Co-authored-by: jxom <jake@tempo.xyz>

---------

Co-authored-by: gomes <17035424+gomesalexandre@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: jxom <jake@tempo.xyz>
Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: Martina <261225237+Iamsohungrynow@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants