Skip to content

fix: keep requestsHash in Block.toRpc - #703

Merged
jxom merged 1 commit into
mainfrom
external/pr-692-block-requests-hash
Nov 19, 2026
Merged

jxom merged 1 commit into
mainfrom
external/pr-692-block-requests-hash

Conversation

@jxom

@jxom jxom commented Nov 19, 2026

Copy link
Copy Markdown
Member

Supersedes #692 by @gomesalexandre (thanks!). Co-authored commit.

Adds requestsHash (EIP-7685, hash32 in execution-apis block.yaml) to Block.Block, Block.toRpc, and the Block zod schemas, so post-Prague blocks keep it on a round trip.

Changes vs #692: the original change as-is, plus vp fmt on src/zod/_test/Block.test-d.ts (it was unformatted, which CI's vp check --fix doesn't flag).

Supersedes #692.

Co-authored-by: gomes <17035424+gomesalexandre@users.noreply.github.com>
Amp-Thread-ID: https://ampcode.com/threads/T-01a1f5cc-eb3a-72b3-bdda-0480feddb7f9
Co-authored-by: jxom <jake@tempo.xyz>
@vercel

vercel Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
ox Error Error Nov 19, 2026 10:19pm UTC

Request Review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-19T22:18:19.188582Z 4207f66 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

Published ox@0.0.0-pr-703-4207f66 under the pr-703 dist-tag, which follows this pull request until it closes.

pnpm add ox@pr-703
pnpm add ox@0.0.0-pr-703-4207f66

@jxom
jxom merged commit b31cd5d into main Nov 19, 2026
14 of 15 checks passed
@jxom
jxom deleted the external/pr-692-block-requests-hash branch November 19, 2026 22:24
jxom added a commit that referenced this pull request Nov 19, 2026
* fix: hash zero-valued leaves in `BinaryStateTree.merkelize` (#690)

EIP-7864 only maps the 64-byte zero input to the zero hash, so a leaf set
to 32 zero bytes is a real leaf. `hash` zeroed any all-zero input, which
merkelized zero-valued leaves as empty (a lone zero leaf at the zero key
gave the empty-tree root).

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Amp-Thread-ID: https://ampcode.com/threads/T-01a1f5cc-eb3a-72b3-bdda-0480feddb7f9
Co-authored-by: jxom <jake@tempo.xyz>

* fix: encode legacy `v` above 255 in `Transaction.toRpc` (#691)

`Transaction.toRpc` encoded `v` with `size: 1` for every transaction
type. A legacy EIP-155 `v` is `chainId * 2 + 35 + yParity`, so from
chain ID 110 on (Polygon, Base, Arbitrum, ...) it passes 255 and `toRpc`
threw `Hex.IntegerOutOfRangeError`. `toRpc(fromRpc(tx))` failed on real
legacy transactions from those chains. execution-apis types the legacy
`v` as `uint` and the typed `v` as `byte`, so legacy now encodes it
without a size and typed transactions keep the single byte.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 6b94083)
Co-authored-by: jxom <jake@tempo.xyz>

* fix: encode authorization `r` and `s` as quantities in `Authorization.toRpc` (#693)

execution-apis types authorization list `r` and `s` as `uint256`, so
nodes expect them without leading zeros. `Authorization.toRpc` passed
the 32-byte padded values through, and geth-based nodes reject them in
`eth_estimateGas`, `eth_call` and `eth_sendTransaction` ("hex number
with leading zero digits") whenever the top nibble is zero.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit d7b57e1)
Co-authored-by: jxom <jake@tempo.xyz>

* fix: keep `requestsHash` in `Block.toRpc` (#703)

Supersedes #692.

Amp-Thread-ID: https://ampcode.com/threads/T-01a1f5cc-eb3a-72b3-bdda-0480feddb7f9

Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: gomes <17035424+gomesalexandre@users.noreply.github.com>
Co-authored-by: jxom <jake@tempo.xyz>
(cherry picked from commit b31cd5d)

* fix: encode `BlockOverrides` `prevRandao` as a 32-byte hash (#704)

Supersedes #700.

Amp-Thread-ID: https://ampcode.com/threads/T-01a1f5cc-eb3a-72b3-bdda-0480feddb7f9

Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: Martina <261225237+Iamsohungrynow@users.noreply.github.com>
Co-authored-by: jxom <jake@tempo.xyz>
(cherry picked from commit 9c3280b)

* fix(0.x): reject a comma in `Siwe` `scheme` and every line break in `statement`

Ports the scheme and statement parts of #705 (from #698 and #699).
The IP literal domain part does not apply to 0.x.

Co-authored-by: gomes <17035424+gomesalexandre@users.noreply.github.com>
Amp-Thread-ID: https://ampcode.com/threads/T-01a1f5cc-eb3a-72b3-bdda-0480feddb7f9
Co-authored-by: jxom <jake@tempo.xyz>

* docs: fix stated outputs in hash and selector examples (#702)

(cherry picked from commit 2d43a3a)
Co-authored-by: jxom <jake@tempo.xyz>

---------

Co-authored-by: gomes <17035424+gomesalexandre@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: jxom <jake@tempo.xyz>
Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: Martina <261225237+Iamsohungrynow@users.noreply.github.com>
@github-actions github-actions Bot mentioned this pull request Nov 19, 2026

This branch had an error being deployed

1 failed deployment
Preview — 4207f668 Deployed Nov 19, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants