Release 1.0a2#18
Merged
Merged
Conversation
scrub travis syntax from github actions Signed-off-by: Elijah Swift<elijah.swift@ibm.com>
change setup.cfg and setup.py to pyproject.toml pyproject.toml can still work with a minimal setup.py for dynamic elements like the pyobject we are building, but the pyproject toml is useful Update pyproject.toml Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
Change all calls to SMO to include option 8 for secrets redaction. Drop methods that contain potentially sensitive information as soon as they are no longer necessary. Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
Check to ensure new redaction eliminates password and password phrase information within the result Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
-changes the way secrets are redacted on input -no longer stores copy of secrets for replacement Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
-customers can add new secrets to redact -cannot overwrite existing secrets for security Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
-add set_passphrase settr to UserAdmin -add unit testing for this feature Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
-add functionality to redact secrets beyond default -cannot change defaults as this is security concern, once something is added, a new instance would be necessary - unit test for this must be run after all other user tests as it redacts UID's and this cannot be reversed for the life of the SecurityAdmin object Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
change pip and python -m pip to python3 -m pip split Lint, unit test and coverage to 3 discrete steps add build status badge for dev branch to repo readme Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
-add .flake8 file -move items within main in setup.py -change CONTRIBUTING.md to reference pyproject.toml Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
-minor typo fixes and name changes -convert options parameter to precheck keyword. Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
-Follow better naming convention -Move GitHub Actions Badge Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
-flake8 does not support pyproject.toml, we now configure via .flake8 file, removing references to flake8 in toml file. Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
-Add newlines for consistent formatting -isort change single quotes to double-quotes in setup.py Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
-split linting into separate steps -remove unnecessary newlines Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
-Remove empty newlines -Update docstring -Remove Extra Link Args Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
convert travis yml to github-actions yml
-Names, and formatting changes -Addition of docstrings -Tweak usability and error handling within some functions Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
-docstring changes -convert _secret_traits to __secret_traits Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
-Fix docstrings Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
Update pyproject.toml
-Move valid_segment_traits to function group constructors -Move secret_traits to main class constructor -Move unit testing for additional secret redaction back into logger tests for user_admin -add input cleanup to generate request only path and remove cleanup on entry to functions -docstring updates and minor code improvements Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
-adjust docstrings -change file names -add new unit tests to confirm only secrets are redacted Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
-black formatter adjusting formatting Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
Fix docstrings fix typos update __clear_state function Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
-Fix docstrings -Clean up positional/keyword arguments -Clean unit testing and code bits Signed-off-by: Elijah Swift <elijah.swift@ibm.com> Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
Signed-off-by: Leonard Carcaramo <lcarcaramo@ibm.com>
Signed-off-by: Leonard Carcaramo <lcarcaramo@ibm.com>
Change add_additional_valid_segment_traits to update_valid_segment traits Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
-Overwrite function is now "Replace" -"Add additional" is completely translated to update Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
-Update docstrings associated with Customized Segment traits -Fix issue where Add_Additional_Secret_Traits was renamed Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
Update docstrings Signed-off-by: Elijah Swift <elijah.swift@ibm.com>
Signed-off-by: Leonard Carcaramo <lcarcaramo@ibm.com>
Signed-off-by: Leonard Carcaramo <lcarcaramo@ibm.com>
Signed-off-by: Leonard Carcaramo <lcarcaramo@ibm.com>
Signed-off-by: Leonard Carcaramo <lcarcaramo@ibm.com>
Signed-off-by: Leonard Carcaramo <lcarcaramo@ibm.com>
Signed-off-by: Leonard Carcaramo <lcarcaramo@ibm.com>
Signed-off-by: Leonard Carcaramo <lcarcaramo@ibm.com>
Clean Custom Field Functions
Signed-off-by: Leonard Carcaramo <lcarcaramo@ibm.com>
Signed-off-by: Leonard Carcaramo <lcarcaramo@ibm.com>
Signed-off-by: Leonard Carcaramo <lcarcaramo@ibm.com>
Signed-off-by: Leonard Carcaramo <lcarcaramo@ibm.com>
Jenkins ci cd
Signed-off-by: Leonard Carcaramo <lcarcaramo@ibm.com>
Signed-off-by: Leonard Carcaramo <lcarcaramo@ibm.com>
Signed-off-by: Leonard Carcaramo <lcarcaramo@ibm.com>
Signed-off-by: Leonard Carcaramo <lcarcaramo@ibm.com>
Bug/remove pypi publish
ElijahSwiftIBM
approved these changes
Sep 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Issue Reference
https://github.com/ambitus/pyracf/milestone/1
💻 What does this address?
Refer to GitHub Milestone.
📟 Implementation Details
Refer to GitHub Milestone.
📋 Is there a test case?
Refer to GitHub Milestone.