Repository navigation
[Merged by Bors] - Fix frame count being a float - #4493
Closed
SUPERCILEX wants to merge 2 commits into
Closed
SUPERCILEX wants to merge 2 commits into
SUPERCILEX wants to merge 2 commits into
Conversation
Contributor
Author
|
Actually, I just realized this isn't a public API (couldn't figure out why my imports weren't working lol) so I'm less invested in this. I still think it's a good idea since it means the frame count will break down at 2^64 instead of 2^53, but if this isn't desired then I'm happy to close. |
Contributor
|
At a frame rate of 1_000 I believe it will take 30_000 years to overflow 2^53. Someone please check my math but I think this is accurate. |
|
still about 2047 times less time than 2^64 :P |
Contributor
@raffimolero do you mean about 2^11 times less ;) |
alice-i-cecile
approved these changes
May 16, 2022
alice-i-cecile
left a comment
Member
There was a problem hiding this comment.
I like this change. Even without a public interface, I prefer optimizing for correctness in this sort of design.
mockersf
approved these changes
May 16, 2022
Member
|
bors r+ |
bors Bot
pushed a commit
that referenced
this pull request
May 17, 2022
Original reasoning: #678 (comment) That reasoning doesn't seem valid IMO since eventually +1 will do nothing. Using an integer is more intuitive and will wrap around which is probably better than getting stuck.
robtfm
pushed a commit
to robtfm/bevy
that referenced
this pull request
May 17, 2022
Original reasoning: bevyengine#678 (comment) That reasoning doesn't seem valid IMO since eventually +1 will do nothing. Using an integer is more intuitive and will wrap around which is probably better than getting stuck.
exjam
pushed a commit
to exjam/bevy
that referenced
this pull request
May 22, 2022
Original reasoning: bevyengine#678 (comment) That reasoning doesn't seem valid IMO since eventually +1 will do nothing. Using an integer is more intuitive and will wrap around which is probably better than getting stuck.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
Original reasoning: bevyengine#678 (comment) That reasoning doesn't seem valid IMO since eventually +1 will do nothing. Using an integer is more intuitive and will wrap around which is probably better than getting stuck.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original reasoning: #678 (comment)
That reasoning doesn't seem valid IMO since eventually +1 will do nothing. Using an integer is more intuitive and will wrap around which is probably better than getting stuck.