Skip to content

[Merged by Bors] - Fix frame count being a float #4493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SUPERCILEX wants to merge 2 commits into from
Closed

[Merged by Bors] - Fix frame count being a float #4493

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4119ba
Fix frame count being a float
SUPERCILEX Apr 16, 2022
103559e
Update frame_time_diagnostics_plugin.rs
SUPERCILEX Apr 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions crates/bevy_diagnostic/src/frame_time_diagnostics_plugin.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,13 @@ use bevy_ecs::system::{Res, ResMut};
pub struct FrameTimeDiagnosticsPlugin;

pub struct FrameTimeDiagnosticsState {
frame_count: f64,
frame_count: u64,
}

impl Plugin for FrameTimeDiagnosticsPlugin {
fn build(&self, app: &mut bevy_app::App) {
app.add_startup_system(Self::setup_system)
.insert_resource(FrameTimeDiagnosticsState { frame_count: 0.0 })
.insert_resource(FrameTimeDiagnosticsState { frame_count: 0 })
.add_system(Self::diagnostic_system);
}
}
Expand All @@ -37,8 +37,8 @@ impl FrameTimeDiagnosticsPlugin {
time: Res<Time>,
mut state: ResMut<FrameTimeDiagnosticsState>,
) {
state.frame_count += 1.0;
diagnostics.add_measurement(Self::FRAME_COUNT, state.frame_count);
state.frame_count = state.frame_count.wrapping_add(1);
diagnostics.add_measurement(Self::FRAME_COUNT, state.frame_count as f64);

if time.delta_seconds_f64() == 0.0 {
return;
Expand Down