Repository navigation
[Search service] Add support for ES request preference - #49424
Merged
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
4 tasks done
Contributor
💚 Build Succeeded |
|
@elasticmachine merge upstream |
| search: (request, options) => | ||
| search( | ||
| search: (request, options) => { | ||
| if (typeof request.params.preference === 'undefined') { |
There was a problem hiding this comment.
Would if (request.params.preference === undefined) { work? a bit shorter. 🤷♀
Contributor
Author
There was a problem hiding this comment.
It's mostly out of habit because you can technically redefine undefined:
(undefined => {
console.log(undefined); // 'foo'
})('foo')But yeah, it shouldn't make any difference in this situation.
stacey-gammon
approved these changes
Oct 30, 2019
stacey-gammon
left a comment
There was a problem hiding this comment.
did not pull down and test but looks straightforward. Glad adding in settings worked out well.
I forget how the async es_search_strategy was set up, but we'll probably want to see how we aren't duplicating settings in that one. I wonder if we could hold a reference to the OSS es_search strategy after overwriting it, and re-use it, sending in a param for the server side strategy (so sync -> async) or something. 🤷♀ can figure that out later, for now, code lgtm.
Contributor
💚 Build Succeeded |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build Succeeded |
lukasolson
added a commit
to lukasolson/kibana
that referenced
this pull request
Nov 13, 2019
* Add support for ES preference * Fix name of test
Contributor
Author
|
7.x (7.6.0): 384b037 |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Nov 14, 2019
* 'master' of github.com:elastic/kibana: (27 commits) [Rollup] Fix for clone job workflow (elastic#50501) Empty message "No data available" for Labels and User metadata sections missing (elastic#49846) [APM] Duration by Country map doesn't take `transactionName` into account (elastic#50315) Remove react references from core `Notifications` apis (elastic#49573) Updated APM Indices endpoints to use the SavedObjectsClient from the legacy request context, and set the apm-indices schema object to be namspace-agnostic [Metrics UI] Calculate interval based on the dataset's period (elastic#50194) chore(NA): add new platform discovered plugins as entry points to check for dependencies on clean dll tasks (elastic#50610) [Telemetry] change of optin status telemetry (elastic#50158) [SIEM][Detection Engine] REST API Additions (elastic#50514) [DOCS] Removes dashboard-only mode doc (elastic#50441) [Filters] Fix operator overflowing out popover (elastic#50030) Change telemetry optIn to default to true (elastic#50490) [Maps] make grid rectangles the default symbolization for geo grid source (elastic#50169) Allow registered applications to hide Kibana chrome (elastic#49795) Upgrade EUI to v14.9.0 (elastic#49678) [Metrics UI] Convert layouts to use React components (elastic#49134) [Search service] Add support for ES request preference (elastic#49424) [Newsfeed/Lint] fix chained fn lint (elastic#50515) [Monitoring] Fix logstash pipelines page in multi-cluster environment (elastic#50166) [SIEM] Events viewer fixes (elastic#50175) ...
Contributor
💚 Build Succeeded |
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
* Add support for ES preference * Fix name of test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support to the new search service for setting the Elasticsearch request preference based on the
courier:setRequestPreferenceandcourier:customRequestPreferenceUI settings.Checklist