Skip to content

Change telemetry optIn to default to true - #50490

Merged
mikecote merged 6 commits into
elastic:masterfrom
mikecote:telemetry/opt-in-by-default
Nov 13, 2019
Merged

mikecote merged 6 commits into
elastic:masterfrom
mikecote:telemetry/opt-in-by-default

Conversation

@mikecote

@mikecote mikecote commented Nov 13, 2019 •

Copy link
Copy Markdown
Contributor

Resolves #50483

In this PR, I'm changing the default telemetry optIn value to true.

cc @Bamieh I had to change some of the logic as I noticed the config wasn't used as default value anymore when allow change is enabled.

@elasticmachine

Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-stack-services (Team:Stack Services)

@elasticmachine

Copy link
Copy Markdown
Contributor

💔 Build Failed

@bmcconaghy bmcconaghy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@elasticmachine

Copy link
Copy Markdown
Contributor

💔 Build Failed

@mikecote
mikecote requested a review from Bamieh November 13, 2019 18:05
@elasticmachine

Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@gmmorris gmmorris left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works locally and code LGTM

Not sure why this PR doesn't have the checklist @mikecote you might want to fix that before Lee notices ;)

@pmuellr pmuellr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, haven't tried running yet. Sorry for the late review

@elasticmachine

Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@mikecote
mikecote merged commit bff235b into elastic:master Nov 13, 2019
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 14, 2019
* 'master' of github.com:elastic/kibana: (27 commits)
  [Rollup] Fix for clone job workflow (elastic#50501)
  Empty message "No data available" for Labels and User metadata sections missing (elastic#49846)
  [APM] Duration by Country map doesn't take `transactionName` into account (elastic#50315)
  Remove react references from core `Notifications` apis (elastic#49573)
  Updated APM Indices endpoints to use the SavedObjectsClient from the legacy request context, and set the apm-indices schema object to be namspace-agnostic
  [Metrics UI] Calculate interval based on the dataset's period (elastic#50194)
  chore(NA): add new platform discovered plugins as entry points to check for dependencies on clean dll tasks (elastic#50610)
  [Telemetry] change of optin status telemetry (elastic#50158)
  [SIEM][Detection Engine] REST API Additions (elastic#50514)
  [DOCS] Removes dashboard-only mode doc (elastic#50441)
  [Filters] Fix operator overflowing out popover (elastic#50030)
  Change telemetry optIn to default to true (elastic#50490)
  [Maps] make grid rectangles the default symbolization for geo grid source (elastic#50169)
  Allow registered applications to hide Kibana chrome (elastic#49795)
  Upgrade EUI to v14.9.0 (elastic#49678)
  [Metrics UI] Convert layouts to use React components (elastic#49134)
  [Search service] Add support for ES request preference (elastic#49424)
  [Newsfeed/Lint] fix chained fn lint (elastic#50515)
  [Monitoring] Fix logstash pipelines page in multi-cluster environment (elastic#50166)
  [SIEM] Events viewer fixes (elastic#50175)
  ...
@alexfrancoeur alexfrancoeur mentioned this pull request Nov 15, 2019
1 task done
patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026
* Change optIn to default to true

* Update snapshot

* Fix eslint errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Telemetry release_note:skip Skip the PR/issue when compiling release notes v7.5.0 v7.6.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change optIn default state

6 participants