Repository navigation
[Rollup] Fix for clone job workflow - #50501
Merged
Merged
Conversation
Contributor
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
…ter index pattern changed
Contributor
💚 Build Succeeded |
Contributor
💔 Build Failed |
alisonelizabeth
approved these changes
Nov 13, 2019
alisonelizabeth
left a comment
Contributor
There was a problem hiding this comment.
Tested locally. Changes LGTM. Thanks for fixing this!
Contributor
|
@jloleysens can you add a |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Nov 14, 2019
* First iteration of fix for clone job workflow * Second iteration of fix, previous had race condition :gasp: * Slight revision to logic and added test for wizard with rollup job after index pattern changed
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Nov 14, 2019
* First iteration of fix for clone job workflow * Second iteration of fix, previous had race condition :gasp: * Slight revision to logic and added test for wizard with rollup job after index pattern changed
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Nov 14, 2019
* First iteration of fix for clone job workflow * Second iteration of fix, previous had race condition :gasp: * Slight revision to logic and added test for wizard with rollup job after index pattern changed
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Nov 14, 2019
* 'master' of github.com:elastic/kibana: (27 commits) [Rollup] Fix for clone job workflow (elastic#50501) Empty message "No data available" for Labels and User metadata sections missing (elastic#49846) [APM] Duration by Country map doesn't take `transactionName` into account (elastic#50315) Remove react references from core `Notifications` apis (elastic#49573) Updated APM Indices endpoints to use the SavedObjectsClient from the legacy request context, and set the apm-indices schema object to be namspace-agnostic [Metrics UI] Calculate interval based on the dataset's period (elastic#50194) chore(NA): add new platform discovered plugins as entry points to check for dependencies on clean dll tasks (elastic#50610) [Telemetry] change of optin status telemetry (elastic#50158) [SIEM][Detection Engine] REST API Additions (elastic#50514) [DOCS] Removes dashboard-only mode doc (elastic#50441) [Filters] Fix operator overflowing out popover (elastic#50030) Change telemetry optIn to default to true (elastic#50490) [Maps] make grid rectangles the default symbolization for geo grid source (elastic#50169) Allow registered applications to hide Kibana chrome (elastic#49795) Upgrade EUI to v14.9.0 (elastic#49678) [Metrics UI] Convert layouts to use React components (elastic#49134) [Search service] Add support for ES request preference (elastic#49424) [Newsfeed/Lint] fix chained fn lint (elastic#50515) [Monitoring] Fix logstash pipelines page in multi-cluster environment (elastic#50166) [SIEM] Events viewer fixes (elastic#50175) ...
jloleysens
added a commit
that referenced
this pull request
Nov 14, 2019
jloleysens
added a commit
that referenced
this pull request
Nov 14, 2019
jloleysens
added a commit
that referenced
this pull request
Nov 14, 2019
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
* First iteration of fix for clone job workflow * Second iteration of fix, previous had race condition :gasp: * Slight revision to logic and added test for wizard with rollup job after index pattern changed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses this issue: #50486
How to review
See issue for details on how to reproduce.
Todo
Add a testRelease Notes
We fixed a bug that prevented users from cloning rollup jobs if they changed the index pattern in the first step of the wizard.