Always use useIsFeatureEnabled() hook for feature detection#19589
Merged
Conversation
c9ecd30 to
0d89759
Compare
4 flaky tests on run #6687 ↗︎Details:
|
|||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Realm settings tabs tests > Accessibility tests for realm settings > Check a11y violations on user registration tab/ default roles sub tab |
Output
Screenshots
|
|
client_authorization_test.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Client authentication subtab > Should create a policy |
Output
Screenshots
|
|
clients_saml_test.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Clients SAML tests > SAML keys tab > should doesn't disable signature when cancel |
Output
Screenshots
|
|
realm_test.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Realm tests > should fail creating realm with empty name |
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
edewit
approved these changes
Apr 9, 2023
ssilvert
pushed a commit
that referenced
this pull request
Apr 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures that feature detection is always done with the same hook, this avoids repeating the same code for feature detection and will make it easier to refactor in the future.