Skip to content

Always use useIsFeatureEnabled() hook for feature detection#19643

Merged
ssilvert merged 1 commit into
mainfrom
revert-19635-revert-19589-consistent-feature-detection
Apr 18, 2023
Merged

Always use useIsFeatureEnabled() hook for feature detection#19643
ssilvert merged 1 commit into
mainfrom
revert-19635-revert-19589-consistent-feature-detection

Conversation

@jonkoops

Copy link
Copy Markdown
Contributor

Reverts #19635

@jonkoops jonkoops requested a review from a team as a code owner April 11, 2023 14:07
@ghost ghost added the team/ui label Apr 11, 2023
@jonkoops jonkoops added area/admin/ui kind/task status/hold PR should not be merged. On hold for later. labels Apr 11, 2023
@cypress

cypress Bot commented Apr 11, 2023

Copy link
Copy Markdown

5 flaky tests on run #6752 ↗︎

0 513 47 0 Flakiness 5

Details:

Merge 1c7acf3 into bcaab0e...
Project: Keycloak Admin UI Commit: 9024a7f2ec ℹ️
Status: Passed Duration: 16:20 💡
Started: Apr 11, 2023 2:42 PM Ended: Apr 11, 2023 2:58 PM
Flakiness  clients_test.spec.ts • 2 flaky tests

View Output Video

Test Artifacts
Clients test > Advanced tab test > Clustering Output Screenshots
Clients test > Realm client > Hides the delete action Output Screenshots
Flakiness  users_test.spec.ts • 1 flaky test

View Output Video

Test Artifacts
User creation > Accessibility tests for users > Check a11y violations on user identity provider links tab Output Screenshots
Flakiness  realm_settings_tabs_test.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Realm settings tabs tests > Accessibility tests for realm settings > Check a11y violations on client policies tab/ policies sub tab Output Screenshots
Flakiness  client_authorization_test.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Client authentication subtab > Edit a resource Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@cypress

cypress Bot commented Apr 11, 2023

Copy link
Copy Markdown

5 flaky tests on run #6753 ↗︎

0 513 47 0 Flakiness 5

Details:

Revert "Revert "Always use `useIsFeatureEnabled()` hook for feature detection (#...
Project: Keycloak Admin UI Commit: 1c7acf30b4
Status: Passed Duration: 16:07 💡
Started: Apr 11, 2023 2:46 PM Ended: Apr 11, 2023 3:02 PM
Flakiness  clients_test.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Clients test > Roles tab test > Should delete attribute from client role Output Screenshots
Flakiness  authentication_test.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Authentication test > should add a condition Output Screenshots
Flakiness  realm_settings_tabs_test.spec.ts • 2 flaky tests

View Output Video

Test Artifacts
Realm settings tabs tests > Accessibility tests for realm settings > Check a11y violations on keys tab/ providers sub tab Output Screenshots
Realm settings tabs tests > Accessibility tests for realm settings > Check a11y violations on keys tab/ providers sub tab / adding provider Output Screenshots
Flakiness  realm_test.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Realm tests > should create Test realm Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@ssilvert ssilvert merged commit 25a1496 into main Apr 18, 2023
@ssilvert ssilvert deleted the revert-19635-revert-19589-consistent-feature-detection branch April 18, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/admin/ui kind/task status/hold PR should not be merged. On hold for later. team/ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants