Allow registered applications to hide Kibana chrome by eliperelman · Pull Request #49795 · elastic/kibana

eliperelman · 2019-10-30T20:28:54Z

Summary

When registering an application, you can now use the chromeless option to hide the Kibana chrome UI when the application is mounted.

Fixes #49100.

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~This was checked for cross-browser compatibility, including a check against IE11~~
~~Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support~~
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
~~This was checked for keyboard-only and screenreader accessibility~~

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

Dev Docs

When registering an application, you can now use the chromeless option to hide the Kibana chrome UI when the application is mounted.

application.register({
  id: 'my-app',
  chromeless: true,
  async mount(context, params) {
    /* ... */
  },
});

elasticmachine · 2019-10-30T20:28:56Z

Pinging @elastic/kibana-platform (Team:Platform)

elasticmachine · 2019-10-30T21:35:33Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: ce6c7b10705df19a421af55359495087171bb848

joshdover · 2019-10-31T20:23:12Z

ack: reviewing now

elasticmachine · 2019-11-01T00:27:45Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 323495ddb296d157d08d18eba8960706764e2d25

pgayvallet · 2019-11-01T13:52:00Z

Do we know already how this is going to interact with the next point of #41981 (No icon in the left navbar)? Is an application with chromeHidden going to always be considered a standalone app (aka respect point 2 and 3 of #41981), or are we going to add specific API to register these new standalone apps ?

eliperelman · 2019-11-01T16:36:00Z

@pgayvallet the answer to that is unknown still, but I hope to have an answer for you in the next 2 PRs. 😃

elasticmachine · 2019-11-05T22:10:52Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: b9a7f951097958ebacf12f9e942edb58a308986d

eliperelman · 2019-11-06T15:19:18Z

In a face-to-face meeting with @joshdover and @pgayvallet, we decided that a single chromeless flag with hide both the UI chrome and disable showing an app icon in the left navbar.

elasticmachine · 2019-11-06T16:31:21Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: c1482fb78c29abe3dd2794a74c895f03743664fa

elasticmachine · 2019-11-07T18:06:47Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: fe96501ace2f238edb0c9e3c4fd32c5d3de720b0

joshdover

Looks great!

Since this behavior is a bit interwoven with a couple mechanisms, I think we should have a pair of functional tests in our plugin_functional suite. There's prior art there you should be able to steal from.

elasticmachine · 2019-11-12T20:39:21Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 7d871ce914860b6058df8f1a6a8b5425d2e50516

elasticmachine · 2019-11-12T22:36:39Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 1160ef730e3d2081cee8ec6384e9b5934bb6525a

elasticmachine · 2019-11-13T01:11:13Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 929ebbb568f0ddac46b9e5a80b7340d444a5753e

…idden

…from specifying

elasticmachine · 2019-11-13T19:35:12Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: a42cae4a4328df2e941165e2b5a37783ae5d2bc4

elasticmachine · 2019-11-13T20:55:59Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: cec9714

* Allow registered applications to hide Kibana chrome * Fix bug in flipped value of application chromeHidden * Add additional test for app chrome hidden versus chrome visibility * Rename chromeHidden to chromeless * Default chrome service app hidden observable to same value as force hidden * Consolidate force hiding in chrome, add functional tests * Move chromeless flag to App interface to prevent legacy applications from specifying * Address review nits to improve separation

* 'master' of github.com:elastic/kibana: (27 commits) [Rollup] Fix for clone job workflow (elastic#50501) Empty message "No data available" for Labels and User metadata sections missing (elastic#49846) [APM] Duration by Country map doesn't take `transactionName` into account (elastic#50315) Remove react references from core `Notifications` apis (elastic#49573) Updated APM Indices endpoints to use the SavedObjectsClient from the legacy request context, and set the apm-indices schema object to be namspace-agnostic [Metrics UI] Calculate interval based on the dataset's period (elastic#50194) chore(NA): add new platform discovered plugins as entry points to check for dependencies on clean dll tasks (elastic#50610) [Telemetry] change of optin status telemetry (elastic#50158) [SIEM][Detection Engine] REST API Additions (elastic#50514) [DOCS] Removes dashboard-only mode doc (elastic#50441) [Filters] Fix operator overflowing out popover (elastic#50030) Change telemetry optIn to default to true (elastic#50490) [Maps] make grid rectangles the default symbolization for geo grid source (elastic#50169) Allow registered applications to hide Kibana chrome (elastic#49795) Upgrade EUI to v14.9.0 (elastic#49678) [Metrics UI] Convert layouts to use React components (elastic#49134) [Search service] Add support for ES request preference (elastic#49424) [Newsfeed/Lint] fix chained fn lint (elastic#50515) [Monitoring] Fix logstash pipelines page in multi-cluster environment (elastic#50166) [SIEM] Events viewer fixes (elastic#50175) ...

elasticmachine · 2019-11-14T21:16:20Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: cec9714

* Allow registered applications to hide Kibana chrome * Fix bug in flipped value of application chromeHidden * Add additional test for app chrome hidden versus chrome visibility * Rename chromeHidden to chromeless * Default chrome service app hidden observable to same value as force hidden * Consolidate force hiding in chrome, add functional tests * Move chromeless flag to App interface to prevent legacy applications from specifying * Address review nits to improve separation

eliperelman added Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// Feature:New Platform release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. v8.0.0 v7.6.0 labels Oct 30, 2019

eliperelman requested a review from a team October 30, 2019 20:28

eliperelman self-assigned this Oct 30, 2019

joshdover reviewed Oct 31, 2019

View reviewed changes

Comment thread src/core/public/chrome/chrome_service.tsx Outdated

Comment thread src/core/public/chrome/chrome_service.tsx Outdated

Comment thread src/core/public/chrome/chrome_service.test.ts Outdated

eliperelman force-pushed the feature/49100 branch from ce6c7b1 to 323495d Compare October 31, 2019 23:08

eliperelman requested a review from joshdover November 1, 2019 16:37

eliperelman force-pushed the feature/49100 branch from 323495d to b9a7f95 Compare November 5, 2019 20:52

pgayvallet reviewed Nov 11, 2019

View reviewed changes

Comment thread src/core/public/chrome/chrome_service.tsx Outdated

joshdover reviewed Nov 11, 2019

View reviewed changes

Comment thread src/core/public/chrome/chrome_service.tsx Outdated

Comment thread src/core/public/chrome/chrome_service.tsx Outdated

mshustov reviewed Nov 12, 2019

View reviewed changes

Comment thread src/core/public/chrome/chrome_service.test.ts Outdated

Comment thread src/core/public/chrome/chrome_service.tsx Outdated

eliperelman force-pushed the feature/49100 branch from fe96501 to 7d871ce Compare November 12, 2019 19:44

eliperelman requested a review from a team November 12, 2019 19:44

eliperelman force-pushed the feature/49100 branch from fb2228c to 1160ef7 Compare November 12, 2019 21:21

joshdover approved these changes Nov 12, 2019

View reviewed changes

Comment thread test/plugin_functional/test_suites/core_plugins/applications.ts Outdated

Comment thread src/core/public/chrome/chrome_service.tsx Outdated

Comment thread src/core/public/chrome/chrome_service.tsx Outdated

eliperelman force-pushed the feature/49100 branch from 929ebbb to a42cae4 Compare November 13, 2019 18:21

eliperelman added 8 commits November 13, 2019 13:33

Allow registered applications to hide Kibana chrome

119fe3b

Fix bug in flipped value of application chromeHidden

81a195d

Add additional test for app chrome hidden versus chrome visibility

234afc1

Rename chromeHidden to chromeless

523f43a

Default chrome service app hidden observable to same value as force h…

f51f996

…idden

Consolidate force hiding in chrome, add functional tests

0242d1e

Move chromeless flag to App interface to prevent legacy applications …

43fdcf8

…from specifying

Address review nits to improve separation

cec9714

eliperelman force-pushed the feature/49100 branch from a42cae4 to cec9714 Compare November 13, 2019 19:33

eliperelman merged commit 6955593 into elastic:master Nov 13, 2019

eliperelman mentioned this pull request Nov 13, 2019

[7.x] Allow registered applications to hide Kibana chrome (#49795) #50524

Merged

joshuarrrr mentioned this pull request May 25, 2022

[UX] Redesigned Global Header opensearch-project/OpenSearch-Dashboards#1583

Closed

Conversation

eliperelman commented Oct 30, 2019 • edited by rayafratkina Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Dev Docs

Uh oh!

elasticmachine commented Oct 30, 2019

Uh oh!

elasticmachine commented Oct 30, 2019

💔 Build Failed

Uh oh!

joshdover commented Oct 31, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

elasticmachine commented Nov 1, 2019

💚 Build Succeeded

Uh oh!

pgayvallet commented Nov 1, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eliperelman commented Nov 1, 2019

Uh oh!

elasticmachine commented Nov 5, 2019

💚 Build Succeeded

Uh oh!

eliperelman commented Nov 6, 2019

Uh oh!

elasticmachine commented Nov 6, 2019

💚 Build Succeeded

Uh oh!

elasticmachine commented Nov 7, 2019

💚 Build Succeeded

Uh oh!

Uh oh!

joshdover left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

elasticmachine commented Nov 12, 2019

💔 Build Failed

Uh oh!

Uh oh!

Uh oh!

Uh oh!

elasticmachine commented Nov 12, 2019

💚 Build Succeeded

Uh oh!

elasticmachine commented Nov 13, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Nov 13, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Nov 13, 2019

💚 Build Succeeded

Uh oh!

elasticmachine commented Nov 14, 2019

💚 Build Succeeded

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

eliperelman commented Oct 30, 2019 •

edited by rayafratkina

Loading

pgayvallet commented Nov 1, 2019 •

edited

Loading