Add new version of Welcome theme based on PatternFly 5 - #23008
Conversation
Passing run #8895 ↗︎Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
edewit
left a comment
There was a problem hiding this comment.
so the design that kun made will be added later?
Yeah, that's correct. This PR just implements something bare-bones and similar to the existing welcome theme. Then once we have a solid design we can start making things look a bit better, plus some other tasks. |
ghost
left a comment
There was a problem hiding this comment.
Unreported flaky test detected, please review
Unreported flaky test detectedIf the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.forms.VerifyProfileTest#testEmailChangeSetsEmailVerifiedKeycloak CI - Forms IT (chrome) |
c91a994 to
8b18840
Compare
ssilvert
left a comment
There was a problem hiding this comment.
You already have a link to the admin console before the initial admin user is created. This should be hidden until the user is created.
I originally did this, but this link has to be on the page to ensure the tests pass. This is also the same behavior as the old welcome screen, but I see now that it attempts to hide it with CSS if the form is present. I'll change it back so that it only renders if no bootstrapping needs to be done, and remove/refactor the tests in the process. |
8b18840 to
883dab5
Compare
883dab5 to
7348282
Compare
7348282 to
cbe8afd
Compare
* master: (7978 commits) CLI args not recognized when running Quarkus dev mode (keycloak#23254) Bump github/codeql-action from 2.21.5 to 2.21.6 Race condition inside Keycloak build chain execution (keycloak#23260) doc(js-providers): Add OIDC object mapper documentation Fix NPE by calling delegate in DeploymentDelegate.getAdapterConfig() Add new version of Welcome theme based on PatternFly 5 (keycloak#23008) Toggle visibility of password input fields in login-ftl-based pages i18n: Add Thai language (keycloak#23165) Registration page not showing username when edit username is not enabled Bump @4tw/cypress-drag-drop from 2.2.4 to 2.2.5 in /js (keycloak#23237) Make `minValidity` parameter in `updateToken()` optional (keycloak#23050) Bump cypress from 13.1.0 to 13.2.0 in /js (keycloak#23186) Add 22.0.3 to release notes (keycloak#23238) Removed namespaces from messages (keycloak#23205) Send Client ID in token request with JWT Authentication Bump @types/tar-fs from 2.0.1 to 2.0.2 in /js (keycloak#23189) Bump uuid from 9.0.0 to 9.0.1 in /js (keycloak#23190) Bump wireit from 0.13.0 to 0.14.0 in /js (keycloak#23191) Bump @playwright/test from 1.37.1 to 1.38.0 in /js (keycloak#23223) Bump @testing-library/cypress from 9.0.0 to 10.0.1 in /js (keycloak#23224) ...
Adds a new version of the Welcome theme based on the recently released PatternFly 5. This is meant to be an early version with a basic design that matches the functionality of the original theme, avoiding breaking changes to the Java code that might impact folks extending it.
An improved version will follow later based on a new design.
Closes #21343