Skip to content

Add new version of Welcome theme based on PatternFly 5 - #23008

Merged
ssilvert merged 1 commit into
keycloak:mainfrom
jonkoops:welcome-v2
Sep 14, 2023
Merged

Add new version of Welcome theme based on PatternFly 5#23008
ssilvert merged 1 commit into
keycloak:mainfrom
jonkoops:welcome-v2

Conversation

@jonkoops

@jonkoops jonkoops commented Sep 6, 2023

Copy link
Copy Markdown
Contributor

Adds a new version of the Welcome theme based on the recently released PatternFly 5. This is meant to be an early version with a basic design that matches the functionality of the original theme, avoiding breaking changes to the Java code that might impact folks extending it.

An improved version will follow later based on a new design.

Closes #21343

@cypress

cypress Bot commented Sep 6, 2023

Copy link
Copy Markdown

Passing run #8895 ↗︎

0 527 48 0 Flakiness 0

Details:

Merge cbe8afd into 53ad5cd...
Project: Keycloak Admin UI Commit: d37d223b7f ℹ️
Status: Passed Duration: 13:13 💡
Started: Sep 11, 2023 12:03 PM Ended: Sep 11, 2023 12:17 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

edewit
edewit previously approved these changes Sep 6, 2023

@edewit edewit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so the design that kun made will be added later?

@edewit

edewit commented Sep 6, 2023

Copy link
Copy Markdown
Contributor

image

@jonkoops

jonkoops commented Sep 6, 2023

Copy link
Copy Markdown
Contributor Author

so the design that kun made will be added later?

Yeah, that's correct. This PR just implements something bare-bones and similar to the existing welcome theme. Then once we have a solid design we can start making things look a bit better, plus some other tasks.

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@ghost

ghost commented Sep 6, 2023

Copy link
Copy Markdown

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.VerifyProfileTest#testEmailChangeSetsEmailVerified

Keycloak CI - Forms IT (chrome)

java.lang.IllegalArgumentException: No enum constant org.keycloak.testsuite.pages.AppPage.RequestType.
	at java.base/java.lang.Enum.valueOf(Enum.java:273)
	at org.keycloak.testsuite.pages.AppPage$RequestType.valueOf(AppPage.java:56)
	at org.keycloak.testsuite.pages.AppPage.getRequestType(AppPage.java:49)
	at jdk.internal.reflect.GeneratedMethodAccessor553.invoke(Unknown Source)
...

Report flaky test

@ssilvert ssilvert left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You already have a link to the admin console before the initial admin user is created. This should be hidden until the user is created.

@jonkoops

Copy link
Copy Markdown
Contributor Author

You already have a link to the admin console before the initial admin user is created. This should be hidden until the user is created.

I originally did this, but this link has to be on the page to ensure the tests pass. This is also the same behavior as the old welcome screen, but I see now that it attempts to hide it with CSS if the form is present.

I'll change it back so that it only renders if no bootstrapping needs to be done, and remove/refactor the tests in the process.

@agagancarczyk agagancarczyk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ssilvert
ssilvert merged commit bcab75a into keycloak:main Sep 14, 2023
@jonkoops
jonkoops deleted the welcome-v2 branch September 14, 2023 13:06
paulbares added a commit to paulbares/keycloak that referenced this pull request Sep 15, 2023
* master: (7978 commits)
  CLI args not recognized when running Quarkus dev mode (keycloak#23254)
  Bump github/codeql-action from 2.21.5 to 2.21.6
  Race condition inside Keycloak build chain execution (keycloak#23260)
  doc(js-providers): Add OIDC object mapper documentation
  Fix NPE by calling delegate in DeploymentDelegate.getAdapterConfig()
  Add new version of Welcome theme based on PatternFly 5 (keycloak#23008)
  Toggle visibility of password input fields in login-ftl-based pages
  i18n: Add Thai language (keycloak#23165)
  Registration page not showing username when edit username is not enabled
  Bump @4tw/cypress-drag-drop from 2.2.4 to 2.2.5 in /js (keycloak#23237)
  Make `minValidity` parameter in `updateToken()` optional (keycloak#23050)
  Bump cypress from 13.1.0 to 13.2.0 in /js (keycloak#23186)
  Add 22.0.3 to release notes (keycloak#23238)
  Removed namespaces from messages (keycloak#23205)
  Send Client ID in token request with JWT Authentication
  Bump @types/tar-fs from 2.0.1 to 2.0.2 in /js (keycloak#23189)
  Bump uuid from 9.0.0 to 9.0.1 in /js (keycloak#23190)
  Bump wireit from 0.13.0 to 0.14.0 in /js (keycloak#23191)
  Bump @playwright/test from 1.37.1 to 1.38.0 in /js (keycloak#23223)
  Bump @testing-library/cypress from 9.0.0 to 10.0.1 in /js (keycloak#23224)
  ...
@Robbilie Robbilie mentioned this pull request May 7, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade welcome theme to PatternFly 5

4 participants