Skip to content

i18n: Add Thai language - #23165

Merged
ahus1 merged 1 commit into
keycloak:mainfrom
weeix:i18n-add-thai-language
Sep 14, 2023
Merged

i18n: Add Thai language#23165
ahus1 merged 1 commit into
keycloak:mainfrom
weeix:i18n-add-thai-language

Conversation

@weeix

@weeix weeix commented Sep 12, 2023

Copy link
Copy Markdown
Contributor

This PR is intended to incorporate the Thai language into Keycloak, specifically in the following Themes:

  • Base > Account
  • Base > Email
  • Base > Login
  • Keycloak.v2

@weeix
weeix requested a review from a team as a code owner September 12, 2023 08:55
@jonkoops

jonkoops commented Sep 12, 2023

Copy link
Copy Markdown
Contributor

Hi @weeix, thanks for your PR. We require changes to localization to have at least one reviewer which is a native speaker of the language. If you know someone who can review your work here, please ask them to do so.

@weeix

weeix commented Sep 13, 2023

Copy link
Copy Markdown
Contributor Author

Hello @jonkoops, I have shared invitations for reviewing this PR in several Facebook groups. These groups consist of Thai individuals who may potentially utilize Keycloak in their professional capacities.

nickethachin
nickethachin approved these changes Sep 13, 2023
View reviewed changes

@nickethachin nickethachin left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm Thai native speaker and theses translation look good to me.
Both context and meaning is correct and to the point.

ghost
ghost approved these changes Sep 13, 2023
View reviewed changes

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m Thai and this commit looks good to me.

ahus1
ahus1 previously approved these changes Sep 13, 2023
View reviewed changes

@ahus1 ahus1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as of community reviews

@ahus1
ahus1 enabled auto-merge (squash) September 13, 2023 07:46
amincheloh
amincheloh reviewed Sep 13, 2023
View reviewed changes
Comment thread themes/src/main/resources-community/theme/base/account/messages/messages_th.properties Outdated
@amincheloh

amincheloh commented Sep 13, 2023

Copy link
Copy Markdown

According to the Royal Society of Thailand (ราชบัณฑิตยสภา), the word 'Application' should be transliterated as 'แอปพลิเคชัน'.

amincheloh
amincheloh reviewed Sep 13, 2023
View reviewed changes
Comment thread themes/src/main/resources-community/theme/base/account/messages/messages_th.properties Outdated
@ahus1
ahus1 disabled auto-merge September 13, 2023 08:17
@ahus1

ahus1 commented Sep 13, 2023

Copy link
Copy Markdown
Member

@weeix - I see additional comments from the community. Please let me know if you want to address them in this pull request or a future pull request.

@ghost ghost added the flaky-test label Sep 13, 2023
@ghost ghost mentioned this pull request Sep 13, 2023
Closed
@ghost

ghost commented Sep 13, 2023

Copy link
Copy Markdown

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.x509.X509BrowserCRLTest#loginSuccessWithCRLSignedWithIntermediateCA3FromTruststore

Keycloak CI - FIPS IT (strict)

java.lang.RuntimeException: Could not create statement
	at org.jboss.arquillian.junit.Arquillian.methodBlock(Arquillian.java:313)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
...

Report flaky test

ghost
ghost reviewed Sep 13, 2023
View reviewed changes

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@weeix

weeix commented Sep 13, 2023

Copy link
Copy Markdown
Contributor Author

@weeix - I see additional comments from the community. Please let me know if you want to address them in this pull request or a future pull request.

I will address them in this pull request.

@sapondanaisriwan

sapondanaisriwan commented Sep 13, 2023

Copy link
Copy Markdown

แอพพลิเคชัน -> แอปพลิเคชัน

bouroo
bouroo suggested changes Sep 13, 2023
View reviewed changes
Comment thread themes/src/main/resources-community/theme/keycloak.v2/account/messages/messages_th.properties Outdated
Comment thread themes/src/main/resources-community/theme/base/account/messages/messages_th.properties Outdated
Comment thread themes/src/main/resources-community/theme/base/account/messages/messages_th.properties Outdated
Comment thread themes/src/main/resources-community/theme/base/account/messages/messages_th.properties Outdated
Comment thread themes/src/main/resources-community/theme/base/account/messages/messages_th.properties Outdated
Comment thread themes/src/main/resources-community/theme/base/account/messages/messages_th.properties Outdated
Comment thread themes/src/main/resources-community/theme/base/account/messages/messages_th.properties Outdated
Comment thread themes/src/main/resources-community/theme/base/login/messages/messages_th.properties Outdated
Comment thread themes/src/main/resources-community/theme/base/login/messages/messages_th.properties Outdated
@weeix

weeix commented Sep 13, 2023

Copy link
Copy Markdown
Contributor Author

Thank you. Additional suggestions are always welcome.

Changes (force-pushed):

  • Translations have been enhanced based on community review suggestions.
  • All changes have been consolidated into a single commit.
  • The totpAppMicrosoftAuthenticatorName translation, previously missing, has now been added to the Base > Account section.
  • The access-denied-when-idp-auth translation, previously missing, has now been added to the Base > Account section.
  • The totpAppMicrosoftAuthenticatorName translation, previously missing, has now been added to the Base > Login section.
  • A newline has been inserted in the Base > Account section for alignment with the English translation.
  • All trailing spaces have been removed.

chalut01
chalut01 approved these changes Sep 13, 2023
View reviewed changes

@chalut01 chalut01 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amincheloh

amincheloh commented Sep 13, 2023

Copy link
Copy Markdown

LGTM

@ahus1 ahus1 self-assigned this Sep 14, 2023
ahus1
ahus1 approved these changes Sep 14, 2023
View reviewed changes

@ahus1 ahus1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for these changes and the review from the community!

@ahus1
ahus1 enabled auto-merge (squash) September 14, 2023 06:55
bouroo
bouroo reviewed Sep 14, 2023
View reviewed changes
Comment thread themes/src/main/resources-community/theme/base/login/messages/messages_th.properties Outdated

@bouroo bouroo Sep 14, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ลงทะเบียนแบบไม่ใช้รหัสผ่านด้วย WebAuthn

This was referenced Sep 14, 2023
Closed
Closed
@jonkoops

jonkoops commented Sep 14, 2023

Copy link
Copy Markdown
Contributor

Giving this a quick rebase to hopefully pass the CI.

@ahus1
ahus1 merged commit 722422a into keycloak:main Sep 14, 2023
@ahus1

ahus1 commented Sep 14, 2023

Copy link
Copy Markdown
Member

Thank you for this PR. As there were some additional comments which weren't included in this PR, please create additional PRs as needed to address those comments. We'll be happy to merge them once they - like this one - have been reviewed by native speaker.

paulbares added a commit to paulbares/keycloak that referenced this pull request Sep 15, 2023
@paulbares
Merge branch 'master' into KEYCLOAK-15985
85eff31 
* master: (7978 commits)
  CLI args not recognized when running Quarkus dev mode (keycloak#23254)
  Bump github/codeql-action from 2.21.5 to 2.21.6
  Race condition inside Keycloak build chain execution (keycloak#23260)
  doc(js-providers): Add OIDC object mapper documentation
  Fix NPE by calling delegate in DeploymentDelegate.getAdapterConfig()
  Add new version of Welcome theme based on PatternFly 5 (keycloak#23008)
  Toggle visibility of password input fields in login-ftl-based pages
  i18n: Add Thai language (keycloak#23165)
  Registration page not showing username when edit username is not enabled
  Bump @4tw/cypress-drag-drop from 2.2.4 to 2.2.5 in /js (keycloak#23237)
  Make `minValidity` parameter in `updateToken()` optional (keycloak#23050)
  Bump cypress from 13.1.0 to 13.2.0 in /js (keycloak#23186)
  Add 22.0.3 to release notes (keycloak#23238)
  Removed namespaces from messages (keycloak#23205)
  Send Client ID in token request with JWT Authentication
  Bump @types/tar-fs from 2.0.1 to 2.0.2 in /js (keycloak#23189)
  Bump uuid from 9.0.0 to 9.0.1 in /js (keycloak#23190)
  Bump wireit from 0.13.0 to 0.14.0 in /js (keycloak#23191)
  Bump @playwright/test from 1.37.1 to 1.38.0 in /js (keycloak#23223)
  Bump @testing-library/cypress from 9.0.0 to 10.0.1 in /js (keycloak#23224)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahus1 ahus1 ahus1 approved these changes
+7 more reviewers
@amincheloh amincheloh amincheloh left review comments
@bouroo bouroo bouroo requested changes
@jonkoops jonkoops jonkoops approved these changes
@chalut01 chalut01 chalut01 approved these changes
@nickethachin nickethachin nickethachin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@ahus1 ahus1

Labels

area/translations flaky-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@weeix @jonkoops @amincheloh @ahus1 @sapondanaisriwan @bouroo @chalut01 @nickethachin