Make Keycloak.updateToken minValidity parameter optional - #23050
Merged
Conversation
jonkoops
suggested changes
Sep 11, 2023
jonkoops
left a comment
Contributor
There was a problem hiding this comment.
The value is actually optional, the type definition is wrong and should be corrected instead.
Contributor
|
@ddubrava could you also log an issue for this? It will make it easier for us to backport this change to a patch release. |
Contributor
Author
|
sure! |
2 tasks
Contributor
|
Thanks for that. Do you intend to update this PR to change this, or do you prefer to open up a new one? |
Contributor
Author
I'll fix it in this one |
Contributor
Author
|
The param description is copied from this method |
jonkoops
approved these changes
Sep 14, 2023
jonkoops
enabled auto-merge (squash)
September 14, 2023 09:33
Contributor
|
I've set the PR to merge automatically once CI passes, thanks for your contribution @ddubrava! |
1 flaky test on run #8947 ↗︎Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Realm settings general tab tests > Test all general tab switches |
Test Replay
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
paulbares
added a commit
to paulbares/keycloak
that referenced
this pull request
Sep 15, 2023
* master: (7978 commits) CLI args not recognized when running Quarkus dev mode (keycloak#23254) Bump github/codeql-action from 2.21.5 to 2.21.6 Race condition inside Keycloak build chain execution (keycloak#23260) doc(js-providers): Add OIDC object mapper documentation Fix NPE by calling delegate in DeploymentDelegate.getAdapterConfig() Add new version of Welcome theme based on PatternFly 5 (keycloak#23008) Toggle visibility of password input fields in login-ftl-based pages i18n: Add Thai language (keycloak#23165) Registration page not showing username when edit username is not enabled Bump @4tw/cypress-drag-drop from 2.2.4 to 2.2.5 in /js (keycloak#23237) Make `minValidity` parameter in `updateToken()` optional (keycloak#23050) Bump cypress from 13.1.0 to 13.2.0 in /js (keycloak#23186) Add 22.0.3 to release notes (keycloak#23238) Removed namespaces from messages (keycloak#23205) Send Client ID in token request with JWT Authentication Bump @types/tar-fs from 2.0.1 to 2.0.2 in /js (keycloak#23189) Bump uuid from 9.0.0 to 9.0.1 in /js (keycloak#23190) Bump wireit from 0.13.0 to 0.14.0 in /js (keycloak#23191) Bump @playwright/test from 1.37.1 to 1.38.0 in /js (keycloak#23223) Bump @testing-library/cypress from 9.0.0 to 10.0.1 in /js (keycloak#23224) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the JavaScript adapter documentation it's said that
minValidityinupdateTokenis optional, while it's not.Closes #23149