Skip to content

CLI args not recognized when running Quarkus dev mode - #23254

Merged
vmuzikar merged 1 commit into
keycloak:mainfrom
pedroigor:issue-23253
Sep 14, 2023
Merged

CLI args not recognized when running Quarkus dev mode#23254
vmuzikar merged 1 commit into
keycloak:mainfrom
pedroigor:issue-23253

Conversation

@pedroigor

@pedroigor pedroigor commented Sep 14, 2023

Copy link
Copy Markdown
Contributor

Closes #23253

@pedroigor
pedroigor requested review from a team as code owners September 14, 2023 13:21
@vmuzikar
vmuzikar requested a review from mabartos September 14, 2023 13:55
mabartos
mabartos approved these changes Sep 14, 2023
View reviewed changes

@mabartos mabartos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The approach works for me; I don't see any problems with that. Everything works as expected. Thanks

vmuzikar
vmuzikar approved these changes Sep 14, 2023
View reviewed changes

@vmuzikar vmuzikar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on @mabartos' review.

Thanks @pedroigor!

@vmuzikar
vmuzikar enabled auto-merge (squash) September 14, 2023 14:25
@mabartos

mabartos commented Sep 14, 2023

Copy link
Copy Markdown
Member

Omg, we need to get rid of building the dependent modules during the Quarkus tests. The failures are caused by it in CI again :)

@pedroigor

pedroigor commented Sep 14, 2023

Copy link
Copy Markdown
Contributor Author

Omg, we need to get rid of building the dependent modules during the Quarkus tests. The failures are caused by it in CI again :)

Sorry, could you elaborate? Anything I can do in a separate PR?

@vmuzikar
vmuzikar merged commit 2f4144a into keycloak:main Sep 14, 2023
@ghost ghost added the flaky-test label Sep 14, 2023
@ghost ghost mentioned this pull request Sep 14, 2023
Closed
paulbares added a commit to paulbares/keycloak that referenced this pull request Sep 15, 2023
@paulbares
Merge branch 'master' into KEYCLOAK-15985
85eff31 
* master: (7978 commits)
  CLI args not recognized when running Quarkus dev mode (keycloak#23254)
  Bump github/codeql-action from 2.21.5 to 2.21.6
  Race condition inside Keycloak build chain execution (keycloak#23260)
  doc(js-providers): Add OIDC object mapper documentation
  Fix NPE by calling delegate in DeploymentDelegate.getAdapterConfig()
  Add new version of Welcome theme based on PatternFly 5 (keycloak#23008)
  Toggle visibility of password input fields in login-ftl-based pages
  i18n: Add Thai language (keycloak#23165)
  Registration page not showing username when edit username is not enabled
  Bump @4tw/cypress-drag-drop from 2.2.4 to 2.2.5 in /js (keycloak#23237)
  Make `minValidity` parameter in `updateToken()` optional (keycloak#23050)
  Bump cypress from 13.1.0 to 13.2.0 in /js (keycloak#23186)
  Add 22.0.3 to release notes (keycloak#23238)
  Removed namespaces from messages (keycloak#23205)
  Send Client ID in token request with JWT Authentication
  Bump @types/tar-fs from 2.0.1 to 2.0.2 in /js (keycloak#23189)
  Bump uuid from 9.0.0 to 9.0.1 in /js (keycloak#23190)
  Bump wireit from 0.13.0 to 0.14.0 in /js (keycloak#23191)
  Bump @playwright/test from 1.37.1 to 1.38.0 in /js (keycloak#23223)
  Bump @testing-library/cypress from 9.0.0 to 10.0.1 in /js (keycloak#23224)
  ...
@mabartos

mabartos commented Sep 15, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

@pedroigor It's not related to this PR.

The thing is that when we execute the Quarkus tests, we use the -am Maven parameter. It'll build all dependent modules again on the particular module. For integration tests, all these modules are rebuilt:

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Build Order:
[INFO] 
[INFO] Keycloak                                                           [pom]
[INFO] Keycloak Common                                                    [jar]
[INFO] Keycloak Core                                                      [jar]
[INFO] Keycloak Server SPI                                                [jar]
[INFO] Keycloak Server Private SPI                                        [jar]
[INFO] Keycloak Crypto Parent                                             [pom]
[INFO] Keycloak Crypto Default                                            [jar]
[INFO] Keycloak SAML Core Public API                                      [jar]
[INFO] Keycloak SAML Core                                                 [jar]
[INFO] Keycloak REST Services                                             [jar]
[INFO] Keycloak Crypto FIPS 140-2 Integration                             [jar]
[INFO] Keycloak JavaScript Adapter (JAR)                                  [jar]
[INFO] Keycloak Themes                                                    [jar]
[INFO] Keycloak Model Parent                                              [pom]
[INFO] Keycloak Legacy Database Support                                   [jar]
[INFO] Keycloak Legacy Database Support - Private classes                 [jar]
[INFO] Keycloak Model JPA                                                 [jar]
[INFO] Keycloak Model Java Annotations and Processor                      [jar]
[INFO] Keycloak Model Map                                                 [jar]
[INFO] Keycloak Model Map JPA                                             [jar]
[INFO] Keycloak Kerberos Federation                                       [jar]
[INFO] Keycloak LDAP UserStoreProvider                                    [jar]
[INFO] Keycloak Legacy Database Support - REST services                   [jar]
[INFO] Keycloak Model Infinispan                                          [jar]
[INFO] Keycloak Model Hot Rod                                             [jar]
[INFO] Keycloak Model Map File                                            [jar]
[INFO] Keycloak SSSD Federation                                           [jar]
[INFO] Keycloak Authz: Parent                                             [pom]
[INFO] Keycloak AuthZ: Policy Provider Parent                             [pom]
[INFO] Keycloak AuthZ: Common Policy Providers                            [jar]
[INFO] Keycloak Quarkus Parent                                            [pom]
[INFO] Keycloak Configuration API                                         [jar]
[INFO] Keycloak JavaScript Parent                                         [pom]
[INFO] Keycloak Account UI                                                [jar]
[INFO] Keycloak Admin UI                                                  [jar]
[INFO] Keycloak Administration UI                                         [pom]
[INFO] Admin UI REST extensions                                           [jar]
[INFO] Keycloak Quarkus Server Extension                                  [jar]
[INFO] Keycloak Quarkus Server Deployment                                 [jar]
[INFO] Keycloak Integration                                               [pom]
[INFO] Keycloak Client CLI                                                [pom]
[INFO] Keycloak Client Registration CLI                                   [jar]
[INFO] Keycloak Admin CLI                                                 [jar]
[INFO] Keycloak Client CLI Distribution                                   [pom]
[INFO] Keycloak Quarkus Server App                                        [jar]
[INFO] Keycloak Quarkus Server Distribution                               [pom]
[INFO] Keycloak Quarkus Test Parent                                       [pom]
[INFO] Keycloak Quarkus Server JUnit 5 Internal Test Framework            [jar]
[INFO] Keycloak Quarkus Server Integration tests                          [jar]
[INFO]

You can notice the Themes module is included there, which consumes much time, and also UI modules, which are often unstable during the build for these tests.

Instead, we can leverage the cached artifacts.
I've tried to make an improvement[1] around that, but there were some problems with ClassLoader and some modules.
I'll look at it more deeply.

Attached issue: https://github.com/keycloak/keycloak/issues/23276

[1] 95fafa4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vmuzikar vmuzikar vmuzikar approved these changes
@mabartos mabartos mabartos approved these changes

Assignees

No one assigned

Labels

flaky-test team/cloud-native

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CLI args not recognized when running Quarkus dev mode

3 participants

@pedroigor @mabartos @vmuzikar