Conversation
Performance and stability improvements on all platforms.
Cr-Commit-Position: refs/heads/5.7.514@{#1}
Cr-Branched-From: 51a4b9f-refs/heads/master@{#42479}
hubot
pushed a commit
that referenced
this pull request
Mar 7, 2017
Revision: 7d8a302 BUG=chromium:698587 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2735103003 . Cr-Commit-Position: refs/branch-heads/5.8@{#13} Cr-Branched-From: eda659c-refs/heads/5.8.283@{#1} Cr-Branched-From: 4310cd0-refs/heads/master@{#43429}
isegal
pushed a commit
to isegal/v8
that referenced
this pull request
Mar 9, 2017
…ent counts (patchset v8#13 id:240001 of https://codereview.chromium.org/2684993002/ ) Reason for revert: Due to arm64 failures Original issue's description: > [interpreter] Create custom call opcodes for specific argument counts > > Specifically, add bytecodes for Call0, Call1, Call2, CallProperty0, CallProperty1, > and CallProperty2. Also share the bytecode handler code between between > equivalent CallX and CallPropertyX handlers. > > Review-Url: https://codereview.chromium.org/2684993002 > Cr-Commit-Position: refs/heads/master@{#43290} > Committed: https://chromium.googlesource.com/v8/v8/+/00d6f1f80a00c4ac398af588dbd6815395791015 TBR=rmcilroy@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/2709533002 Cr-Commit-Position: refs/heads/master@{#43308}
Contributor
|
Closing. Please keep in mind that this is only a GitHub mirror of V8's 'real' repository. In order to submit changes please follow the instructions at https://github.com/v8/v8/wiki/Contributing. |
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Mar 21, 2017
…ttps://codereview.chromium.org/2748473004/ ) Reason for revert: Breaks layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/14312 See https://github.com/v8/v8/wiki/Blink-layout-tests Original issue's description: > [wasm] Transferrable modules > > We want to restrict structured cloning in Chrome to: > - postMessage senders and receivers that are co-located > in the same process > - indexedDB (just https). > > For context, on the Chrome side, we will achieve the postMessage part > by using a mechanism similar to transferrables: the > SerializedScriptValue will have a list of wasm modules, separate from > the serialized data stream; and this list won't be copied cross > process boundaries. The IDB part is achieved by explicitly opting in > reading/writing to the serialization stream. To block attack vectors > in IPC cases, the default for deserialization will be to expect data > in the wasm transfers list. > > This change is the V8 side necessary to enabling this design. We > introduce TransferrableModule, an opaque datatype exposed to the > embedder. Internally, TransferrableModules are just serialized data, > because we don't have a better mechanism, at the moment, for > de-contextualizing/re-contextualizing wasm modules (wrt Isolate and > Context). > > The chrome defaults will be implemented in the > serialization/deserialization delegates on that side. For the v8 side > of things, in the absence of a serialization delegate, the V8 > serializer will write to serialization stream. In the absence of a > deserialization delegate, the deserializer won't work. This asymmetry > is intentional - it communicates to the embedder the need to make a > policy decision, otherwise wasm serialization/deserialization won't > work "out of the box". > > BUG=v8:6079 > > Review-Url: https://codereview.chromium.org/2748473004 > Cr-Commit-Position: refs/heads/master@{#43955} > Committed: https://chromium.googlesource.com/v8/v8/+/99743ad460ea5b9795ba9d70a074e75d7362a3d1 TBR=jbroman@chromium.org,bradnelson@chromium.org,mtrofin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:6079 Review-Url: https://codereview.chromium.org/2762163002 Cr-Commit-Position: refs/heads/master@{#43981}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Mar 21, 2017
…odereview.chromium.org/2762163002/ ) Reason for revert: Temporarily disabled tests on chromium side (https://codereview.chromium.org/2764933002) Original issue's description: > Revert of [wasm] Transferrable modules (patchset v8#13 id:280001 of https://codereview.chromium.org/2748473004/ ) > > Reason for revert: > Breaks layout tests: > https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/14312 > > See https://github.com/v8/v8/wiki/Blink-layout-tests > > Original issue's description: > > [wasm] Transferrable modules > > > > We want to restrict structured cloning in Chrome to: > > - postMessage senders and receivers that are co-located > > in the same process > > - indexedDB (just https). > > > > For context, on the Chrome side, we will achieve the postMessage part > > by using a mechanism similar to transferrables: the > > SerializedScriptValue will have a list of wasm modules, separate from > > the serialized data stream; and this list won't be copied cross > > process boundaries. The IDB part is achieved by explicitly opting in > > reading/writing to the serialization stream. To block attack vectors > > in IPC cases, the default for deserialization will be to expect data > > in the wasm transfers list. > > > > This change is the V8 side necessary to enabling this design. We > > introduce TransferrableModule, an opaque datatype exposed to the > > embedder. Internally, TransferrableModules are just serialized data, > > because we don't have a better mechanism, at the moment, for > > de-contextualizing/re-contextualizing wasm modules (wrt Isolate and > > Context). > > > > The chrome defaults will be implemented in the > > serialization/deserialization delegates on that side. For the v8 side > > of things, in the absence of a serialization delegate, the V8 > > serializer will write to serialization stream. In the absence of a > > deserialization delegate, the deserializer won't work. This asymmetry > > is intentional - it communicates to the embedder the need to make a > > policy decision, otherwise wasm serialization/deserialization won't > > work "out of the box". > > > > BUG=v8:6079 > > > > Review-Url: https://codereview.chromium.org/2748473004 > > Cr-Commit-Position: refs/heads/master@{#43955} > > Committed: https://chromium.googlesource.com/v8/v8/+/99743ad460ea5b9795ba9d70a074e75d7362a3d1 > > TBR=jbroman@chromium.org,bradnelson@chromium.org,mtrofin@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:6079 > > Review-Url: https://codereview.chromium.org/2762163002 > Cr-Commit-Position: refs/heads/master@{#43981} > Committed: https://chromium.googlesource.com/v8/v8/+/e538b70e1a45289dfe0fa9789563f023a5e9c22b TBR=jbroman@chromium.org,bradnelson@chromium.org,machenbach@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:6079 Review-Url: https://codereview.chromium.org/2762273002 Cr-Commit-Position: refs/heads/master@{#43994}
hubot
pushed a commit
that referenced
this pull request
Apr 20, 2017
Revision: 07aea44 BUG=v8:6264 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=mtrofin@chromium.org Change-Id: I7e461db18d28a2377b5738737e5cfd6c520ccf0b Reviewed-on: https://chromium-review.googlesource.com/483043 Reviewed-by: Mircea Trofin <mtrofin@chromium.org> Commit-Queue: Brad Nelson <bradnelson@chromium.org> Cr-Commit-Position: refs/branch-heads/5.9@{#13} Cr-Branched-From: fe9bb7e-refs/heads/5.9.211@{#1} Cr-Branched-From: 70ad237-refs/heads/master@{#44591}
hubot
pushed a commit
that referenced
this pull request
Apr 28, 2017
Merged 75219da Merged 1ef7e4e Merged 04b655c Merged 4fa104c PPC64: disable big-array-literal testcase due to stack overflow AIX: Adding bbigtoc link step option to fix TOC overflow error PPC/AIX: [heap] Uncommit unused large object page memory. S390: Fix MathMaxMin's frame R=bjaideep@ca.ibm.com, hablich@chromium.org, joransiu@ca.ibm.com, mbrandy@us.ibm.com, michael_dawson@ca.ibm.com BUG= NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2131533002 Cr-Commit-Position: refs/branch-heads/5.3@{#13} Cr-Branched-From: 820a23a-refs/heads/5.3.332@{#2} Cr-Branched-From: 37538cb-refs/heads/master@{#37308}
hubot
pushed a commit
that referenced
this pull request
Apr 28, 2017
Revision: bcac03e NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=hablich@chromium.org BUG=v8:5314 Review-Url: https://codereview.chromium.org/2291143002 Cr-Commit-Position: refs/branch-heads/5.4@{#13} Cr-Branched-From: 5ce2827-refs/heads/5.4.500@{#2} Cr-Branched-From: ad07b49-refs/heads/master@{#38841}
hubot
pushed a commit
that referenced
this pull request
Apr 28, 2017
Merged: Return kBadChar for longest subpart of incomplete utf-8 character. Revision: fd40ebb Merged: Fix out-of-range access in unibrow::Utf8::CalculateValue. Revision: 9d524bd BUG=chromium:662822,chromium:667260 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=marja@chromium.org, hablich@chromium.org Review URL: https://codereview.chromium.org/2522193002 . Cr-Commit-Position: refs/branch-heads/5.6@{#13} Cr-Branched-From: bdd3886-refs/heads/5.6.326@{#1} Cr-Branched-From: 879f659-refs/heads/master@{#41014}
hubot
pushed a commit
that referenced
this pull request
Apr 28, 2017
Merged 460bff5 [compiler] Make feedback vector cope with flag changes. BUG=chromium:600995,chromium:601331 LOG=N R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1903293003 . Cr-Commit-Position: refs/branch-heads/5.1@{#13} Cr-Branched-From: 167dc63-refs/heads/5.1.281@{#1} Cr-Branched-From: 03953f5-refs/heads/master@{#35282}
hubot
pushed a commit
that referenced
this pull request
Apr 28, 2017
R=hablich@chromium.org, machenbach@chromium.org Review URL: https://codereview.chromium.org/2010463003 . Cr-Commit-Position: refs/branch-heads/5.2@{#13} Cr-Branched-From: 2cd36d6-refs/heads/5.2.361@{#1} Cr-Branched-From: 3fef34e-refs/heads/master@{#36332}
hubot
pushed a commit
that referenced
this pull request
Apr 28, 2017
Merged 55b4df7 Merged d00da47 Merged 4da2e3d Merged c1507e1 [runtime] Unify comparison operator runtime entries. [turbofan] Don't use the CompareIC in JSGenericLowering. PPC: [runtime] Unify comparison operator runtime entries. PPC: [turbofan] Don't use the CompareIC in JSGenericLowering. R=hablich@chromium.org BUG=chromium:590832,v8:4788 LOG=N Review URL: https://codereview.chromium.org/1777503002 . Cr-Commit-Position: refs/branch-heads/5.0@{#13} Cr-Branched-From: ad16e6c-refs/heads/5.0.71@{#1} Cr-Branched-From: bd9df50-refs/heads/master@{#34215}
hubot
pushed a commit
that referenced
this pull request
Apr 28, 2017
This is essentially a cherry-pick that was applied before plus the removal of a test that is now failing because it depends on more involved changes. The test case checks comparison of different undetectable JSReceivers, which is not relevant in practice, as there's only one of these at most, which is document.all. Merged 55b4df7 Merged d00da47 Merged 4da2e3d Merged c1507e1 [runtime] Unify comparison operator runtime entries. [turbofan] Don't use the CompareIC in JSGenericLowering. PPC: [runtime] Unify comparison operator runtime entries. PPC: [turbofan] Don't use the CompareIC in JSGenericLowering. R=yangguo@chromium.org BUG=chromium:590832,v8:4788,chromium:606181 LOG=N NOTRY=true NOPRESUBMIT=true Cr-Commit-Position: refs/branch-heads/5.0@{#13} Cr-Branched-From: ad16e6c-refs/heads/5.0.71@{#1} Cr-Branched-From: bd9df50-refs/heads/master@{#34215} Review URL: https://codereview.chromium.org/1925463003 Cr-Commit-Position: refs/branch-heads/5.0@{#44} Cr-Branched-From: ad16e6c-refs/heads/5.0.71@{#1} Cr-Branched-From: bd9df50-refs/heads/master@{#34215}
hubot
pushed a commit
that referenced
this pull request
Jun 1, 2017
Revision: 2f3f974 NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true TBR=jochen@chromium.org Bug: Change-Id: I5e59034b0e9cbd3062a1b61c2b5a19990ba1737b Reviewed-on: https://chromium-review.googlesource.com/520943 Reviewed-by: Peter Marshall <petermarshall@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/branch-heads/6.0@{#13} Cr-Branched-From: 97dbf62-refs/heads/6.0.286@{#1} Cr-Branched-From: 12e6f1c-refs/heads/master@{#45439}
hubot
pushed a commit
that referenced
this pull request
Jul 26, 2017
TBR=machenbach@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Iccbbc9ba074330d2ccbaa0a6d0510ea80391bb62 Reviewed-on: https://chromium-review.googlesource.com/585978 Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/branch-heads/6.1@{#13} Cr-Branched-From: 1bf2e10-refs/heads/6.1.534@{#1} Cr-Branched-From: e825c43-refs/heads/master@{#46746}
hubot
pushed a commit
that referenced
this pull request
Sep 11, 2017
…nter/Leave calls Revision: e7fa71d BUG=chromium:669329 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=cbruni@chromium.org Change-Id: I813d8d1c7078ed455aa4fd51c42dee912f90526c Reviewed-on: https://chromium-review.googlesource.com/657679 Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/branch-heads/6.2@{#13} Cr-Branched-From: efa2ac4-refs/heads/6.2.414@{#1} Cr-Branched-From: a861ebb-refs/heads/master@{#47693}
hubot
pushed a commit
that referenced
this pull request
Oct 17, 2017
TBR=machenbach@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I7579594e7dafe60bfb2b65df09fb3425d8c04d40 Reviewed-on: https://chromium-review.googlesource.com/722082 Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/branch-heads/6.3@{#13} Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1} Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}
hubot
pushed a commit
that referenced
this pull request
Dec 12, 2017
TBR=machenbach@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I366b491c1d2502f1ad2e5a57a183d611dcd917ec Reviewed-on: https://chromium-review.googlesource.com/821694 Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/branch-heads/6.4@{#13} Cr-Branched-From: 0407506-refs/heads/6.4.388@{#1} Cr-Branched-From: a5fc4e0-refs/heads/master@{#49724}
hubot
pushed a commit
that referenced
this pull request
Jan 30, 2018
…side-effect" Revision: 92d8e45 NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=jarin@chromium.org Bug: chromium:803840 Change-Id: I7442fb1903802e8de0f817764eae9bd1b23334e4 Reviewed-on: https://chromium-review.googlesource.com/893183 Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/branch-heads/6.5@{#13} Cr-Branched-From: 73c55f5-refs/heads/6.5.254@{#1} Cr-Branched-From: 594a1a0-refs/heads/master@{#50664}
hubot
pushed a commit
that referenced
this pull request
Mar 12, 2018
On 32-bit systems, the computation {count + type_list->size()} can
overflow, leading to memory corruption later on.
R=ahaas@chromium.org
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
Bug: chromium:819869
Change-Id: I7be8660d25af4ab5a9129b44b24d0820997f3517
Originally-reviewed-on: https://chromium-review.googlesource.com/955025
Reviewed-on: https://chromium-review.googlesource.com/958343
Reviewed-by: Andreas Haas <ahaas@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/branch-heads/6.6@{#13}
Cr-Branched-From: d500271-refs/heads/6.6.346@{#1}
Cr-Branched-From: 265ef0b-refs/heads/master@{#51624}
hubot
pushed a commit
that referenced
this pull request
Apr 16, 2018
TBR=machenbach@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I9b2e7e0163f17b6146b84252a0b2273a841c16ab Reviewed-on: https://chromium-review.googlesource.com/1013746 Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/branch-heads/6.7@{#13} Cr-Branched-From: 8457e81-refs/heads/6.7.288@{#2} Cr-Branched-From: e921be5-refs/heads/master@{#52547}
hubot
pushed a commit
that referenced
this pull request
Jun 5, 2018
1) [wasm] Avoid respill and reload for WASM instance parameter This CL adds support for "secondary parameter locations" for the WASM instance parameter. Since this parameter is spilled onto the stack by the function prologue, it is not necessary to allocate additional spill slots for it. This saves both code space and runtime. Originally-reviewed-on: https://chromium-review.googlesource.com/1075056 2) [wasm] Check representation for secondary parameter locations A previous CL (https://chromium-review.googlesource.com/c/v8/v8/+/1075056) introduced an optimization the spill slot where the WASM instance is stored using the "secondary parameter location" mechanism used for JS functions and contexts. However the optimization checked the full machine type of the parameter, which was too narrow. As a result, the optimization never activated. This CL fixes that by only checking the machine representation. Originally-reviewed-on: https://chromium-review.googlesource.com/1076008 R=mstarzinger@chromium.org Change-Id: I4e744908d5f0eefa5c8bdc6644e905f8544ff78f No-Try: true No-Presubmit: true No-Treechecks: true Bug: chromium:830331 Reviewed-on: https://chromium-review.googlesource.com/1085348 Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/branch-heads/6.8@{#13} Cr-Branched-From: 44d7d7d-refs/heads/6.8.275@{#1} Cr-Branched-From: 5754f66-refs/heads/master@{#53286}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Jul 4, 2018
This reverts commit 52a10e5. Reason for revert: https://test-results.appspot.com/data/layout_results/V8-Blink_Linux_64__dbg_/12434/layout-test-results/results.html Crash e.g. in http/tests/devtools/oopif/oopif-performance-cpu-profiles.js crash log for devtools (pid <unknown>): STDOUT: <empty> STDERR: STDERR: STDERR: # STDERR: # Fatal error in ../../v8/src/compilation-dependencies.cc, line 281 STDERR: # Debug check failed: descriptor == owner->LastAdded() (10 vs. 22). STDERR: # STDERR: # STDERR: # STDERR: #FailureMessage Object: 0x7fff86878630#0 0x0000031c642c base::debug::StackTrace::StackTrace() STDERR: #1 0x0000046a56bb gin::(anonymous namespace)::PrintStackTrace() STDERR: v8#2 0x00000469c528 V8_Fatal() STDERR: v8#3 0x00000469c285 v8::base::(anonymous namespace)::DefaultDcheckHandler() STDERR: v8#4 0x000001cc5253 v8::internal::CompilationDependencies::DependOnFieldType() STDERR: v8#5 0x000001cdcc46 v8::internal::compiler::AccessInfoFactory::ComputePropertyAccessInfo() STDERR: v8#6 0x000001cde661 v8::internal::compiler::AccessInfoFactory::ComputePropertyAccessInfos() STDERR: v8#7 0x000001dd982b v8::internal::compiler::JSNativeContextSpecialization::ReduceNamedAccess() STDERR: v8#8 0x000001ddb715 v8::internal::compiler::JSNativeContextSpecialization::ReduceNamedAccessFromNexus() STDERR: v8#9 0x000001dd656d v8::internal::compiler::JSNativeContextSpecialization::ReduceJSLoadNamed() STDERR: v8#10 0x000001d53872 v8::internal::compiler::GraphReducer::Reduce() STDERR: v8#11 0x000001d534a5 v8::internal::compiler::GraphReducer::ReduceTop() STDERR: v8#12 0x000001d52e58 v8::internal::compiler::GraphReducer::ReduceNode() STDERR: v8#13 0x000001e4c201 v8::internal::compiler::InliningPhase::Run() STDERR: v8#14 0x000001e44f79 v8::internal::compiler::PipelineImpl::Run<>() STDERR: v8#15 0x000001e41058 v8::internal::compiler::PipelineImpl::CreateGraph() STDERR: v8#16 0x000001e40c75 v8::internal::compiler::PipelineCompilationJob::PrepareJobImpl() STDERR: v8#17 0x000001ccd437 v8::internal::OptimizedCompilationJob::PrepareJob() STDERR: v8#18 0x000001cd071e v8::internal::(anonymous namespace)::GetOptimizedCode() STDERR: v8#19 0x000001cd0c6f v8::internal::Compiler::CompileOptimized() STDERR: v8#20 0x00000231fb62 v8::internal::__RT_impl_Runtime_CompileOptimized_Concurrent() STDERR: v8#21 0x00000288e535 <unknown> Original change's description: > [turbofan] Rewrite CompilationDependencies > > Instead of installing code dependencies during graph reduction, > install them after code generation. > > Bug: v8:7902, v8:7790 > Change-Id: I8a3798254abb5b9ec7c295a1592aeb6b51f24c7a > Reviewed-on: https://chromium-review.googlesource.com/1119913 > Commit-Queue: Georg Neis <neis@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54170} TBR=mstarzinger@chromium.org,jarin@chromium.org,neis@chromium.org Change-Id: Ic58c2bfadbd34bb6ba7dc0d2b74871cc90b0a74f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7902, v8:7790 Reviewed-on: https://chromium-review.googlesource.com/1125680 Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#54192}
hubot
pushed a commit
that referenced
this pull request
Jul 30, 2018
Revision: 1e34cea NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true TBR=jarin@chromium.org Bug: chromium:868541 Change-Id: Ia536ccaa49109eb35c420a94fd27fe933de9fef1 Reviewed-on: https://chromium-review.googlesource.com/1155124 Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/branch-heads/6.9@{#13} Cr-Branched-From: d7b61ab-refs/heads/6.9.427@{#1} Cr-Branched-From: b7e108d-refs/heads/master@{#54504}
peterwmwong
pushed a commit
to peterwmwong/v8
that referenced
this pull request
Dec 9, 2018
This reverts commit caed2cc. Reason for revert: Breaks layout tests, e.g. https://test-results.appspot.com/data/layout_results/V8-Blink_Linux_64__dbg_/14924/webkit_layout_tests%20%28with%20patch%29/layout-test-results/results.html crash log for renderer (pid <unknown>): STDOUT: <empty> STDERR: STDERR: STDERR: # STDERR: # Fatal error in ../../v8/src/base/platform/elapsed-timer.h, line 24 STDERR: # Debug check failed: !IsStarted(). STDERR: # STDERR: # STDERR: # STDERR: #FailureMessage Object: 0x7ffc46707640#0 0x565409263b6f base::debug::StackTrace::StackTrace() STDERR: #1 0x56540a8a32fb gin::(anonymous namespace)::PrintStackTrace() STDERR: #2 0x56540a8980d8 V8_Fatal() STDERR: #3 0x56540a897e35 v8::base::(anonymous namespace)::DefaultDcheckHandler() STDERR: v8#4 0x565407971f02 v8::base::ElapsedTimer::Start() STDERR: v8#5 0x565407d08edf v8::internal::TimedHistogram::Start() STDERR: v8#6 0x565407e500d5 v8::internal::IncrementalMarking::AdvanceIncrementalMarkingOnAllocation() STDERR: v8#7 0x565407e4f977 v8::internal::IncrementalMarking::Observer::Step() STDERR: v8#8 0x565407e48092 v8::internal::AllocationObserver::AllocationStep() STDERR: v8#9 0x565407eb0751 v8::internal::SpaceWithLinearArea::InlineAllocationStep() STDERR: v8#10 0x565407eb3e44 v8::internal::NewSpace::EnsureAllocation() STDERR: v8#11 0x565407e258ff v8::internal::NewSpace::AllocateRaw() STDERR: v8#12 0x565407e06b2d v8::internal::Heap::AllocateRaw() STDERR: v8#13 0x565407e432ef v8::internal::Heap::AllocateRawWithLightRetry() STDERR: v8#14 0x565407e433cf v8::internal::Heap::AllocateRawWithRetryOrFail() STDERR: v8#15 0x565407e04d48 v8::internal::Factory::NewFixedArrayWithFiller() STDERR: v8#16 0x565407fd6339 v8::internal::HashTable<>::New() STDERR: v8#17 0x565407fd7be8 v8::internal::HashTable<>::EnsureCapacity() STDERR: v8#18 0x565407fc7e95 v8::internal::Dictionary<>::Add() STDERR: v8#19 0x565407fcf453 v8::internal::BaseNameDictionary<>::Add() STDERR: v8#20 0x565407f89ee4 v8::internal::LookupIterator::ApplyTransitionToDataProperty() STDERR: v8#21 0x5654080036e2 v8::internal::Object::AddDataProperty() STDERR: v8#22 0x56540793061f v8::internal::(anonymous namespace)::DefineDataProperty() STDERR: v8#23 0x56540792da59 v8::internal::(anonymous namespace)::InstantiateObject() STDERR: v8#24 0x56540792b75a v8::internal::(anonymous namespace)::InstantiateFunction() STDERR: v8#25 0x56540792b4db v8::internal::ApiNatives::InstantiateFunction() STDERR: v8#26 0x5654079594bf v8::FunctionTemplate::GetFunction() STDERR: v8#27 0x56540a7af74e blink::V8ObjectConstructor::CreateInterfaceObject() STDERR: v8#28 0x56540a7afe01 blink::V8PerContextData::ConstructorForTypeSlowCase() STDERR: v8#29 0x56540a7afdd6 blink::V8PerContextData::ConstructorForTypeSlowCase() STDERR: v8#30 0x56540a7afdd6 blink::V8PerContextData::ConstructorForTypeSlowCase() STDERR: v8#31 0x56540a7afcb4 blink::V8PerContextData::CreateWrapperFromCacheSlowCase() STDERR: v8#32 0x56540a7aef73 blink::V8DOMWrapper::CreateWrapper() STDERR: v8#33 0x56540a7abf6b blink::ScriptWrappable::Wrap() STDERR: v8#34 0x56540a677199 blink::V8Document::documentElementAttributeGetterCallback() STDERR: v8#35 0x565407a0aec3 v8::internal::FunctionCallbackArguments::Call() STDERR: v8#36 0x565407a097be v8::internal::(anonymous namespace)::HandleApiCallHelper<>() STDERR: v8#37 0x565407a0877b v8::internal::Builtins::InvokeApiFunction() STDERR: v8#38 0x565407fe785a v8::internal::Object::GetPropertyWithAccessor() STDERR: v8#39 0x565407fe697e v8::internal::Object::GetProperty() STDERR: v8#40 0x565407ec8c71 v8::internal::LoadIC::Load() STDERR: v8#41 0x565407ed6401 v8::internal::__RT_impl_Runtime_LoadIC_Miss() STDERR: v8#42 0x5654087593f2 <unknown> STDERR: [16162:16185:1122/143518.356897:WARNING:crash_handler_host_linux.cc(341)] Could not translate tid, attempt = 1 retry ... Original change's description: > [heap] Improve embedder tracing during incremental marking > > Add a path into embedder tracing on allocation. This is safe as as Blink > is not allowed to call into V8 during object construction. > > Bug: chromium:843903 > Change-Id: I5af053c3169f5a33778ebce5d7c5c43e4efb1aa4 > Reviewed-on: https://chromium-review.googlesource.com/c/1348749 > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57757} TBR=ulan@chromium.org,mlippautz@chromium.org Change-Id: Ide2c0b284b52bee17573adcc89f14be4e40dab91 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:843903 Reviewed-on: https://chromium-review.googlesource.com/c/1349189 Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#57759}
ceejatec
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Sep 24, 2020
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I2e861df37224dd3fc4772a4e7a3f36f32f519c68 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1771337 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7.7@{v8#13} Cr-Branched-From: 4035531-refs/heads/7.7.299@{#1} Cr-Branched-From: 1320c91-refs/heads/master@{#62881}
ceejatec
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Sep 24, 2020
…s on AIX. Revision: 07ee86a BUG=v8:9766 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=jyan@ca.ibm.com Change-Id: I4b9d625917280bef2f7c0a4d1c6dec262b1a0ec9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1866813 Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/branch-heads/7.9@{v8#13} Cr-Branched-From: be181e2-refs/heads/7.9.317@{#1} Cr-Branched-From: 0d7889d-refs/heads/master@{#64307}
ceejatec
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Sep 24, 2020
…scriptors on AIX." This reverts commit 539cefa. Reason for revert: Waiting for LGTM from hablich@ Original change's description: > Merged: PPC: allow for calling CFunctions without function descriptors on AIX. > > Revision: 07ee86a > > BUG=v8:9766 > LOG=N > NOTRY=true > NOPRESUBMIT=true > NOTREECHECKS=true > R=jyan@ca.ibm.com > > Change-Id: I4b9d625917280bef2f7c0a4d1c6dec262b1a0ec9 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1866813 > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> > Cr-Commit-Position: refs/branch-heads/7.9@{v8#13} > Cr-Branched-From: be181e2-refs/heads/7.9.317@{#1} > Cr-Branched-From: 0d7889d-refs/heads/master@{#64307} TBR=mstarzinger@chromium.org,hablich@chromium.org,jyan@ca.ibm.com,jgruber@chromium.org,miladfar@ca.ibm.com Change-Id: I2e26c400a21f25d98a81956055de16cc93d103ab No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9766 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1871754 Reviewed-by: Milad Farazmand <miladfar@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/branch-heads/7.9@{v8#15} Cr-Branched-From: be181e2-refs/heads/7.9.317@{#1} Cr-Branched-From: 0d7889d-refs/heads/master@{#64307}
ceejatec
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Sep 24, 2020
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: If8859f7d46b399efbe7a67c5c9a0aba1944f7b59 Reviewed-on: https://chromium-review.googlesource.com/c/1454263 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7.3@{v8#13} Cr-Branched-From: 9df9418-refs/heads/7.3.492@{v8#2} Cr-Branched-From: be213cf-refs/heads/master@{#59024}
ceejatec
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Sep 24, 2020
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I77a3c94b3bd9ea98a0339c63302d33aae01a96d8 Reviewed-on: https://chromium-review.googlesource.com/c/1297992 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7.1@{v8#13} Cr-Branched-From: f70aaa8-refs/heads/7.1.302@{#1} Cr-Branched-From: 1dbcc78-refs/heads/master@{#56462}
ceejatec
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Sep 24, 2020
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I7f6aeaec6d2d4150b916c6bc91e19e594ed4e488 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1662180 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7.6@{v8#13} Cr-Branched-From: 2cb2573-refs/heads/7.6.303@{#1} Cr-Branched-From: 201c509-refs/heads/master@{#61902}
ceejatec
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Sep 24, 2020
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I36536b60df4c20d82f4397ad8b381e68affe0ca2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1588733 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7.5@{v8#13} Cr-Branched-From: 35b9bf5-refs/heads/7.5.288@{#1} Cr-Branched-From: 912b391-refs/heads/master@{#60911}
ceejatec
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Sep 24, 2020
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: Ia34693c0844d4c70b19cb587e0b400f4aaa3ea0a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2162722 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/8.3@{v8#13} Cr-Branched-From: 1668abd-refs/heads/8.3.110@{#1} Cr-Branched-From: 04a7a68-refs/heads/master@{#66926}
ceejatec
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Sep 24, 2020
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: Ibf27c29d826f605efd65d7817c9a1c4100b8e532 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2208938 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/8.4@{v8#13} Cr-Branched-From: 88ed2e3-refs/heads/8.4.371@{#1} Cr-Branched-From: 35f88bf-refs/heads/master@{#67773}
Kwizatz
pushed a commit
to AeonGames/v8
that referenced
this pull request
Oct 28, 2020
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: Ibca2f46a93cd38f5105999e888889d8b1f881a79 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2417934 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/8.6@{v8#13} Cr-Branched-From: a64aed2-refs/heads/8.6.395@{#1} Cr-Branched-From: a626bc0-refs/heads/master@{#69472}
Kwizatz
pushed a commit
to AeonGames/v8
that referenced
this pull request
Feb 6, 2021
(cherry picked from commit e82a3b4) Fixed: chromium:1151890 Change-Id: I26f5c76494a9ff3f5a141f381e1c9a543e368571 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2561618 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#71422} Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2565132 Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/branch-heads/8.8@{v8#13} Cr-Branched-From: 2dbcdc1-refs/heads/8.8.278@{#1} Cr-Branched-From: 366d30c-refs/heads/master@{#71094}
Kwizatz
pushed a commit
to AeonGames/v8
that referenced
this pull request
Apr 29, 2021
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: Ic3554f3a498e655dd4bb4a550857967776effd78 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2742667 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/9.0@{v8#13} Cr-Branched-From: bd0108b-refs/heads/9.0.257@{#1} Cr-Branched-From: 349bcc6-refs/heads/master@{#73001}
Kwizatz
pushed a commit
to AeonGames/v8
that referenced
this pull request
Jul 25, 2021
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: If56510ef3c1dfff58ae68dba065638af7c0896a7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2823653 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/9.1@{v8#13} Cr-Branched-From: 0e4ac64-refs/heads/9.1.269@{#1} Cr-Branched-From: f565e72-refs/heads/master@{#73847}
salewski
pushed a commit
to salewski/v8
that referenced
this pull request
Aug 26, 2021
Revision: 12bbe90 BUG=chromium:1239287 R=mlippautz@chromium.org Change-Id: Ia3ed1676666df8f9e5ea0e4a23fe2661494e8d8b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3101486 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/branch-heads/9.4@{v8#13} Cr-Branched-From: 3b51863-refs/heads/9.4.146@{#1} Cr-Branched-From: 2890419-refs/heads/master@{#76233}
Kwizatz
pushed a commit
to AeonGames/v8
that referenced
this pull request
Jun 27, 2022
Change-Id: I4c263a5b0b3bc65783f5d9b249fe21956cd46921 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3571205 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/10.1@{v8#13} Cr-Branched-From: b003970-refs/heads/10.1.124@{#1} Cr-Branched-From: e62f556-refs/heads/main@{#79503}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: Ib585bc8fd72e000ca4a73737c51adc9fd87e8bf1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2937561 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/9.2@{v8#13} Cr-Branched-From: 5123834-refs/heads/9.2.230@{#1} Cr-Branched-From: 587a04f-refs/heads/master@{#74656}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
Change-Id: I165d0a9b898e4bb5e9aaa2af0447ae3254c92a8d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3834634 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/10.5@{v8#13} Cr-Branched-From: 51c4d6c-refs/heads/10.5.218@{#1} Cr-Branched-From: c641530-refs/heads/main@{#81851}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I98f0df3f9ea361ddd723a0319a6368889ca22d8f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2633727 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/8.9@{v8#13} Cr-Branched-From: 16b9bbb-refs/heads/8.9.255@{#1} Cr-Branched-From: d16a2a6-refs/heads/master@{#72039}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
Change-Id: I92228d389a8aacd9936b9e4b61c906e8ba8e3245 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3671982 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/10.3@{v8#13} Cr-Branched-From: 1a8f4ca-refs/heads/10.3.174@{#1} Cr-Branched-From: 8fbefa4-refs/heads/main@{#80471}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
Change-Id: I48db4176c5a01092de8d6a98602980ad7ac59436 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3550696 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/10.0@{v8#13} Cr-Branched-From: 6ea73a7-refs/heads/10.0.139@{#1} Cr-Branched-From: ccc6890-refs/heads/main@{#79131}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I650513f2fc7ec6e71a2189ca1e0e327db3cb59d6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3164277 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/9.5@{v8#13} Cr-Branched-From: 4a03d61-refs/heads/9.5.172@{#1} Cr-Branched-From: 9a60704-refs/heads/main@{#76741}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
Change-Id: I1c727f2fa22f4d7f89e603f95936a54f01b30eb6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3447522 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/9.9@{v8#13} Cr-Branched-From: c4208cc-refs/heads/9.9.115@{#1} Cr-Branched-From: 19c6fd7-refs/heads/main@{#78682}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I1c8ee0f902f8696fa363117986ed3473cdda8544 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3231480 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/9.6@{v8#13} Cr-Branched-From: 0b7bda0-refs/heads/9.6.180@{#1} Cr-Branched-From: 41a5a24-refs/heads/main@{#77244}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
Change-Id: I98e1963fac36a8605205dd0160966aea21cc5fb9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3686496 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/10.2@{v8#13} Cr-Branched-From: 374091f-refs/heads/10.2.154@{#1} Cr-Branched-From: f0c353f-refs/heads/main@{#79976}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
In addition to checking that a node is owned, CanCover() also needs to check if there are any side-effects in between the current node and the merged node. When merging inputs of inputs, this check was done with the wrong side-effect level of the in-between node. We partially fixed this before with `CanCoverTransitively`. This CL addresses the issue by always comparing to the side-effect level of the node from which we started, making `CanCoverTransitively` superfluous. Bug: chromium:1336869 (cherry picked from commit 6048f75) Change-Id: I59ec8bdf9699052ea7a2302d16854991f8ec45ff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3714243 Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/branch-heads/10.4@{v8#13} Cr-Branched-From: b1413ed-refs/heads/10.4.132@{#1} Cr-Branched-From: 9d0a093-refs/heads/main@{#80972}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
Change-Id: I412910cbed87bbcd5289512556053b7028e96a8f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3402378 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/9.8@{v8#13} Cr-Branched-From: e218afa-refs/heads/9.8.177@{#1} Cr-Branched-From: 86ebfc9-refs/heads/main@{#78312}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I48c57620068f9a5230675569b12cbce26be8360e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3057755 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/9.3@{v8#13} Cr-Branched-From: 7744dce-refs/heads/9.3.345@{#1} Cr-Branched-From: 4b6b4ca-refs/heads/master@{#75728}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
This reverts commit 82ce475. Reason for revert: trigger builders Original change's description: > Whitespace to trigger builders > > No-Try: true > No-Presubmit: true > No-Tree-Checks: true > Change-Id: I9de26b1e86783768fc41ec704e1f5b24aabd3cda > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3289182 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Liviu Rau <liviurau@chromium.org> > Cr-Commit-Position: refs/branch-heads/9.7@{v8#12} > Cr-Branched-From: 49162da-refs/heads/9.7.106@{#1} > Cr-Branched-From: a7e9b8f-refs/heads/main@{#77674} Change-Id: I31afa1623dbf70835312cd87b8897d6416a204c8 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3293087 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Liviu Rau <liviurau@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/branch-heads/9.7@{v8#13} Cr-Branched-From: 49162da-refs/heads/9.7.106@{#1} Cr-Branched-From: a7e9b8f-refs/heads/main@{#77674}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: If49c67dd0a80f6fe1ce5eb3bef9596be96cdf7ba Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2481873 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/8.7@{v8#13} Cr-Branched-From: 0d81cd7-refs/heads/8.7.220@{#1} Cr-Branched-From: 942c2ef-refs/heads/master@{#70196}
unicornx
pushed a commit
to unicornx/v8
that referenced
this pull request
Feb 16, 2023
Change-Id: I7d43f5a73f07ec31375a2b5f7ff0fa02175bb92c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4108728 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/10.9@{v8#13} Cr-Branched-From: 8ade6bf-refs/heads/10.9.194@{aosp-riscv#1} Cr-Branched-From: 9ff2515-refs/heads/main@{#84164}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performance and stability improvements on all platforms.
Cr-Commit-Position: refs/heads/5.7.514@{#1}
Cr-Branched-From: 51a4b9f-refs/heads/master@{#42479}