Undefined name: 'Error' use 'Exception' instead#44
Closed
cclauss wants to merge 1 commit into
Closed
Conversation
@ jakobkummerow https://docs.python.org/3/library/exceptions.html#Exception is the base class for most Python errors and `Error` is undefined in this context so NameError will be raised instead of the desired exception message.
ceejatec
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Sep 24, 2020
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: Iba323fefeb9f4d7c62b5de4521b75faf74740e16 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1899251 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7.8@{v8#44} Cr-Branched-From: 73694fd-refs/heads/7.8.279@{#1} Cr-Branched-From: 2314928-refs/heads/master@{#63555}
ceejatec
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Sep 24, 2020
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I9258332b859d3c66fb06487f11991802aed3e9db Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1912945 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7.9@{v8#44} Cr-Branched-From: be181e2-refs/heads/7.9.317@{#1} Cr-Branched-From: 0d7889d-refs/heads/master@{#64307}
ceejatec
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Sep 24, 2020
Revision: 6239ec1 BUG=chromium:1050164 NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true TBR=hablich@chromium.org Change-Id: I99c666c2fed8a7528a5ab4a070dda78cff34f0b5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2056860 Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/branch-heads/8.0@{v8#44} Cr-Branched-From: 69827db-refs/heads/8.0.426@{v8#2} Cr-Branched-From: 2fe1552-refs/heads/master@{#65318}
ceejatec
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Sep 24, 2020
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: Iee323c2f23ef0d5d59c515b817670fafdb5cceb5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2094659 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/8.1@{v8#44} Cr-Branched-From: a4dcd39-refs/heads/8.1.307@{#1} Cr-Branched-From: f22c213-refs/heads/master@{#66031}
ceejatec
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Sep 24, 2020
Revision: 07e7102 BUG=chromium:1099623 NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=machenbach@chromium.org Change-Id: I5cabff11455b16042f67b48aa8ca6809e5015195 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2410189 Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> Cr-Commit-Position: refs/branch-heads/8.5@{v8#44} Cr-Branched-From: a7f8bc4-refs/heads/8.5.210@{#1} Cr-Branched-From: dd58472-refs/heads/master@{#68510}
ceejatec
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Sep 24, 2020
TBR: clemensb@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I17095b9edc4b222ffd5cc29ff955e14042b34884 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2330018 Reviewed-by: Liviu Rau <liviurau@chromium.org> Commit-Queue: Liviu Rau <liviurau@chromium.org> Cr-Commit-Position: refs/branch-heads/8.4@{v8#44} Cr-Branched-From: 88ed2e3-refs/heads/8.4.371@{#1} Cr-Branched-From: 35f88bf-refs/heads/master@{#67773}
Author
|
This is just a mirror |
Kwizatz
pushed a commit
to AeonGames/v8
that referenced
this pull request
Jul 25, 2021
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I79e179fce92c8cc27d3ea3590a1d71061ed2e8d7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2871400 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/9.1@{v8#44} Cr-Branched-From: 0e4ac64-refs/heads/9.1.269@{#1} Cr-Branched-From: f565e72-refs/heads/master@{#73847}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
This refactors the {GetMemOp} function once again:
Instead of computing (mem_start + (offset_reg + offset_imm)), do compute
((mem_start + offset_imm) + offset_reg). This avoids an overflow in
(offset_reg + offset_imm) when using 32-bit computations, which hides
OOB memory accesses when relying on the trap handler.
As a nice side-effect, this change makes the whole method a lot nicer to
read.
We also need to change {StoreTaggedPointer} now, which was relying on the
inner working of {GetMemOp}. The new version makes the semantics more
transparent at the cost of repeating some logic from (the previous version
of) {GetMemOp}.
TBR=jkummerow@chromium.org
(cherry picked from commit c8d60d7)
Bug: chromium:1227465, chromium:1224882
Change-Id: I3ed1c42cebab6d626a1a6aec8e874b868c077526
No-Try: true
No-Tree-Checks: true
No-Presubmit: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3059695
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/branch-heads/9.2@{v8#44}
Cr-Branched-From: 5123834-refs/heads/9.2.230@{#1}
Cr-Branched-From: 587a04f-refs/heads/master@{#74656}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I548b682a49cf1e8e4a57559daad866689f694a7b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2781747 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/8.9@{v8#44} Cr-Branched-From: 16b9bbb-refs/heads/8.9.255@{#1} Cr-Branched-From: d16a2a6-refs/heads/master@{#72039}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
The function index encoded into the serialized module is already offset by num_imported_functions. For lazy compilation, however, we added the number of imported functions another time, which was incorrect. (cherry picked from commit 9380e55) No-Try: true No-Presubmit: true No-Tree-Checks: true Change-Id: Idcf478c05fd070d99cba0a1a1823cf4e57aa1dc3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3207001 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/branch-heads/9.4@{v8#44} Cr-Branched-From: 3b51863-refs/heads/9.4.146@{#1} Cr-Branched-From: 2890419-refs/heads/master@{#76233}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
…ted to module exports Revision: e4dba97 BUG=chromium:1260577 NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=ishell@chromium.org Change-Id: I65dd7fef6b2612d204a025e053bdd96310d622bb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3236721 Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/branch-heads/9.5@{v8#44} Cr-Branched-From: 4a03d61-refs/heads/9.5.172@{#1} Cr-Branched-From: 9a60704-refs/heads/main@{#76741}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
When searching for a target map during map update, attempt to update field representations in-place to the more general representation, where possible. Bug: chromium:1143772 No-Try: true No-Presubmit: true No-Tree-Checks: true TBR=leszeks@chromium.org, fgm@chromium.org (cherry picked from commit 8e3ae62) Change-Id: I659890c2f08c14d1cf94242fb875c19837df2dbb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2509599 Reviewed-by: Francis McCabe <fgm@chromium.org> Reviewed-by: Michael Hablich <hablich@chromium.org> Reviewed-by: Bill Budge <bbudge@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/branch-heads/8.6@{v8#44} Cr-Branched-From: a64aed2-refs/heads/8.6.395@{#1} Cr-Branched-From: a626bc0-refs/heads/master@{#69472}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
Revision: 4feccb9 BUG=chromium:1259587 NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=verwaest@chromium.org Change-Id: I941058dedebdde5c2d4567a57a953a2ce212e4d3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3350459 Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/branch-heads/9.6@{v8#44} Cr-Branched-From: 0b7bda0-refs/heads/9.6.180@{#1} Cr-Branched-From: 41a5a24-refs/heads/main@{#77244}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I51026440e6c657a1d015f9bb12fc1348386c6279 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2845318 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/9.0@{v8#44} Cr-Branched-From: bd0108b-refs/heads/9.0.257@{#1} Cr-Branched-From: 349bcc6-refs/heads/master@{#73001}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I60bf5913cfcff78dd04bef4e03dc71d225946e7a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2528896 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/8.7@{v8#44} Cr-Branched-From: 0d81cd7-refs/heads/8.7.220@{#1} Cr-Branched-From: 942c2ef-refs/heads/master@{#70196}
patrik-lengweiler
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
May 31, 2023
Change-Id: Ie5fac1cbf8a8009ec4152ad5806cb6cc4c646b42 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4101300 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/10.2@{v8#44} Cr-Branched-From: 374091f-refs/heads/10.2.154@{#1} Cr-Branched-From: f0c353f-refs/heads/main@{#79976}
patrik-lengweiler
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
May 31, 2023
Change-Id: Ia4fe97ed9dc4e33c542a0bc3607fb2639525016c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4507153 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/11.2@{v8#44} Cr-Branched-From: 755511a-refs/heads/11.2.214@{#1} Cr-Branched-From: e6b1cce-refs/heads/main@{#86014}
patrik-lengweiler
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
May 31, 2023
Change-Id: I216da8845635669fb415e28bb07a4761d98390e8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3982419 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/10.6@{v8#44} Cr-Branched-From: 41bc743-refs/heads/10.6.194@{#1} Cr-Branched-From: d5f29b9-refs/heads/main@{#82548}
patrik-lengweiler
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
May 31, 2023
Otherwise it's propagated to the parent Bug: chromium:1394973 (cherry picked from commit e1e0890) Change-Id: I723e7b289b9aa3016cc466bd349898d7c7e0ffe9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4108349 Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/branch-heads/10.8@{v8#44} Cr-Branched-From: f1bc03f-refs/heads/10.8.168@{#1} Cr-Branched-From: 237de89-refs/heads/main@{#83672}
patrik-lengweiler
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
May 31, 2023
Change-Id: I26236d2c4d2d44e7666196f8dc50e171648ba60e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3880188 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/10.4@{v8#44} Cr-Branched-From: b1413ed-refs/heads/10.4.132@{#1} Cr-Branched-From: 9d0a093-refs/heads/main@{#80972}
patrik-lengweiler
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
Jun 10, 2023
Change-Id: If20edaecc533feac51cb7db1998132acc2763018 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4605051 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/11.4@{v8#44} Cr-Branched-From: 8a8a1e7-refs/heads/11.4.183@{#1} Cr-Branched-From: 5483d8e-refs/heads/main@{#87241}
reposynch Bot
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
Aug 6, 2023
Change-Id: Iba6edc626d535d6da9da425582812899815552a2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4730656 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/11.5@{v8#44} Cr-Branched-From: 0c4044b-refs/heads/11.5.150@{#1} Cr-Branched-From: b71d303-refs/heads/main@{#87781}
reposynch Bot
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
Jan 14, 2024
Change-Id: Ia1e53286fc73b298fbf85b4c5eb5d388ba9126dd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5189145 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/12.1@{v8#44} Cr-Branched-From: b74ef6f-refs/heads/12.1.285@{#1} Cr-Branched-From: 32857fb-refs/heads/main@{#91313}
hubot
pushed a commit
that referenced
this pull request
Mar 11, 2024
Because the home object has special scope lookup rules due to class heritage position, VariableProxies of the home object are currently directly created on the correct scope during parsing. However, during off-thread parsing the main thread is parked, and the correct scope may try to dereference a main-thread Handle. This CL moves the logic into ResolveVariable instead, which happens during postprocessing, with the main thread unparked. Fixed: chromium:327740539 (cherry picked from commit 8f477f9) Change-Id: I16805ad35f5d70d1acadaf1f5440dfc159dbfa6c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5363634 Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/branch-heads/12.2@{#44} Cr-Branched-From: 6eb5a96-refs/heads/12.2.281@{#1} Cr-Branched-From: 44cf56d-refs/heads/main@{#91934}
hubot
pushed a commit
that referenced
this pull request
Apr 10, 2024
(cherry picked from commit b852ad7) (cherry picked from commit 75fe5a5) Bug: chromium:330575498 Change-Id: I395f0ed6d823b7d1e139da6551486e3627d65724 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5378419 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Auto-Submit: Manos Koukoutos <manoskouk@chromium.org> Cr-Original-Original-Commit-Position: refs/heads/main@{#92941} Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5380190 Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Original-Commit-Position: refs/branch-heads/12.2@{#50} Cr-Original-Branched-From: 6eb5a96-refs/heads/12.2.281@{#1} Cr-Original-Branched-From: 44cf56d-refs/heads/main@{#91934} Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5394499 Commit-Queue: Zakhar Voit <voit@google.com> Reviewed-by: Victor Gabriel Savu <vsavu@google.com> Reviewed-by: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/branch-heads/12.0@{#44} Cr-Branched-From: ed7b4ca-refs/heads/12.0.267@{#1} Cr-Branched-From: 210e75b-refs/heads/main@{#90651}
hubot
pushed a commit
that referenced
this pull request
Jun 28, 2024
Turboshaft's loop unrolling has some logic to remove loops with 0 iterations, and it was broken. The idea is that is there is a loop whose termination condition is something like "stop when i <= 0" where `i` is a loop phi and `i`'s initial value is less than or equal to 0, then this loop has 0 iterations. EXCEPT that this is only true if `i` is a loop phi FOR THIS LOOP. And, in the repro, the `i` comes from a previous loop, so what matters is not its initial value but rather its "final" value (which is not known unless we know how many iterations this previous has, but regardless, the current loop doesn't have 0 iterations!). Bug: chromium:42202729, chromium:347905990 (cherry picked from commit 73be673) Change-Id: I406e2276eb43d7edeaaef0bc0fc637af2cbd379c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5664950 Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Darius Mercadier <dmercadier@chromium.org> Auto-Submit: Darius Mercadier <dmercadier@chromium.org> Cr-Commit-Position: refs/branch-heads/12.6@{#44} Cr-Branched-From: 3c9fa12-refs/heads/12.6.228@{#2} Cr-Branched-From: 981bb15-refs/heads/main@{#93835}
hubot
pushed a commit
that referenced
this pull request
Aug 26, 2024
This reverts part of 2b43121, because there are still some ValueType uses of canonicalized type indices left. So for now we allow a maximum of 1'000'000 canonicalized types. Fixed: 360533914 (cherry picked from commit 79f3f12) Change-Id: I8578d4b77233e7f3815dbf5ec6335f2c4cef963a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5813422 Commit-Queue: Matthias Liedtke <mliedtke@chromium.org> Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Matthias Liedtke <mliedtke@chromium.org> Cr-Commit-Position: refs/branch-heads/12.8@{#44} Cr-Branched-From: 70cbb39-refs/heads/12.8.374@{#1} Cr-Branched-From: 451b63e-refs/heads/main@{#95151}
hubot
pushed a commit
that referenced
this pull request
Sep 23, 2024
Change-Id: I5a44873acc49fb9810db328a0e4efb8843d01482 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5881326 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/12.9@{#44} Cr-Branched-From: 64a21d7-refs/heads/12.9.202@{#1} Cr-Branched-From: da4200b-refs/heads/main@{#95679}
hubot
pushed a commit
that referenced
this pull request
Dec 16, 2024
Version incremented at https://cr-buildbucket.appspot.com/build/8728370718217603537 Change-Id: I738df6cc288765a7af413f1e15d30245385768b2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6097757 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/13.0@{#44} Cr-Branched-From: 4be854b-refs/heads/13.0.245@{#1} Cr-Branched-From: 1f5183f-refs/heads/main@{#96103}
hubot
pushed a commit
that referenced
this pull request
Dec 16, 2024
… properly While https://crrev.com/c/6087921 fixed a bug where the type in the loop header revisit was reflecting "older" knowledge, it didn't address the general issue of loop phis dependencies in single block loops where it might require many iterations until all type information has stabilized. The fix linked above also introduce too specific DCHECKs, as even outside of single-block loops we can end up with phis where a phi input appears in the same block before the phi itself. The binaryen fuzzer found the following pattern: v113 = Phi(v26, v113) v114 = Phi(v26, v113) In follow-up changes it should be ensured that the useless phi v113 doesn't get emitted, then v114 wouldn't have that issue (and it could also be removed.) Fixed: 383356864 Bug: 383814042 (cherry picked from commit c84e01e) Change-Id: I909737ccd25e31a02a31498dd12567da9286de41 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6097336 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Eva Herencsárová <evih@chromium.org> Commit-Queue: Eva Herencsárová <evih@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/branch-heads/13.2@{#44} Cr-Branched-From: 24068c5-refs/heads/13.2.152@{#1} Cr-Branched-From: 6054ba9-refs/heads/main@{#97085}
hubot
pushed a commit
that referenced
this pull request
Feb 24, 2025
More precisely: prevent eliding objects that contain TrustedHeapConstant, because it can lead to this constant flowing into a Phis where other inputs are regular HeapConstant, which confuses decompression optimization and leads to memory corruption. Bug: chromium:390743124 (cherry picked from commit b75e527) Change-Id: I2546cf6480fe18602b4bbedd354bf8580403cd6b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6297384 Reviewed-by: Patrick Thier <pthier@chromium.org> Auto-Submit: Darius Mercadier <dmercadier@chromium.org> Commit-Queue: Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/branch-heads/13.3@{#44} Cr-Branched-From: 41dacff-refs/heads/13.3.415@{#1} Cr-Branched-From: 3348638-refs/heads/main@{#97937}
hubot
pushed a commit
that referenced
this pull request
Jun 27, 2025
Version incremented at https://cr-buildbucket.appspot.com/build/8710908341343451153 Change-Id: I092dc7c5555f87c29eb84713a5f5cf6e638a3f84 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6680826 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/13.8@{#44} Cr-Branched-From: 61ddd47-refs/heads/13.8.258@{#1} Cr-Branched-From: fdb5de2-refs/heads/main@{#100480}
hubot
pushed a commit
that referenced
this pull request
Dec 12, 2025
Version incremented at https://cr-buildbucket.appspot.com/build/8695678991150170033 Change-Id: I7471018b5555ad1e25fb6ef3b2afdc490d75e920 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7254064 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/14.2@{#44} Cr-Branched-From: 37f82db-refs/heads/14.2.231@{#1} Cr-Branched-From: d1a6089-refs/heads/main@{#102804}
hubot
pushed a commit
that referenced
this pull request
Jan 23, 2026
Original change's description: > [heap] Change priority of the release task in MemoryPool > > This is to avoid a priority inversion with the main thread when holding > the global mutex on MacOS. > > Bug: 477326598 > Change-Id: I6a0f5e4b2e1faf9a783259af0e9fc5496e5565df > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7502545 > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/main@{#104821} (cherry picked from commit fd08194) Bug: 478197684,477326598 Change-Id: I6a0f5e4b2e1faf9a783259af0e9fc5496e5565df Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7511790 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Chrome Cherry Picker <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/14.4@{#44} Cr-Branched-From: 80acc26-refs/heads/14.4.258@{#1} Cr-Branched-From: ce7e597-refs/heads/main@{#104020}
hubot
pushed a commit
that referenced
this pull request
Mar 13, 2026
Version incremented at https://cr-buildbucket.appspot.com/build/8687444293052065953 Change-Id: I5f51964cdbc98abd7bd1f8a430a2abecae9e33ec Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7666379 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/14.6@{#44} Cr-Branched-From: e04c3a1-refs/heads/14.6.202@{#1} Cr-Branched-From: 3b0b01e-refs/heads/main@{#105132}
hubot
pushed a commit
that referenced
this pull request
May 12, 2026
…isions) https://chromium.googlesource.com/external/github.com/WebKit/JetStream.git/+log/2145cedef4ca..91552391bf2f 2026-05-06 cbruni@chromium.org Fix wrong update-ui performance.mark and measure nesting 2026-03-26 cbruni@chromium.org Improve memory script 2026-03-19 cbruni@chromium.org Address comments for memory measurement script 2026-03-19 cbruni@chromium.org Add memory measurement script 2026-03-18 cbruni@chromium.org Actually fix --dump-test-list 2026-03-18 cbruni@chromium.org Fix --dump-test-list and --test in v3.0-custom 2026-03-17 cbruni@chromium.org Update v3.0-custom to latest v3.0 branch 2026-01-30 kmiller68@users.noreply.github.com Merge pull request #272 from danleh/JetStream3.0 2026-01-19 cbruni@chromium.org Reland: Improve Benchmark constructor and instance variables #255 (#263) 2026-01-19 cbruni@chromium.org Reland: Add resource loading bar (#264) 2026-01-19 danleh@users.noreply.github.com Merge pull request #261 from danleh/dotnet-mime-fix 2026-01-17 kmiller68@users.noreply.github.com Merge pull request #262 from kmiller68/revert-replace-prefetch-logic 2026-01-15 kmiller68@users.noreply.github.com Merge pull request #245 from kmiller68/add-open-governance-policy 2026-01-15 danleh@users.noreply.github.com Merge pull request #260 from danleh/readme-addendum 2026-01-14 danleh@users.noreply.github.com Merge pull request #258 from danleh/repo-readme 2026-01-14 cbruni@chromium.org Improve Benchmark constructor and instance variables (#255) 2026-01-14 kmiller68@users.noreply.github.com Merge pull request #254 from kmiller68/scatter-plot-should-increase-with-score 2026-01-14 danleh@users.noreply.github.com Merge pull request #257 from danleh/remove-unused-deps 2026-01-14 cbruni@chromium.org Fix dev server output (#252) 2026-01-14 danleh@users.noreply.github.com Merge pull request #256 from danleh/fix-npm-audit 2026-01-14 cbruni@chromium.org Add resource loading bar (#246) 2026-01-13 cbruni@chromium.org Replace prefetch logic (#251) 2026-01-06 kmiller68@users.noreply.github.com Merge pull request #249 from kmiller68/add-verbose-option-to-server 2026-01-06 camillobruni@users.noreply.github.com Add BrowserFileLoader (#242) 2025-12-18 camillobruni@users.noreply.github.com Add --force-gc support (#248) 2025-12-10 kmiller68@users.noreply.github.com Merge pull request #244 from kmiller68/nonStandard-error-rotate-back-to-red 2025-12-10 camillobruni@users.noreply.github.com fewer shell warnings (#234) 2025-11-13 kmiller68@users.noreply.github.com Merge pull request #238 from kmiller68/transformers-js-loads-resources-at-runtime 2025-11-13 ysuzuki@apple.com Merge pull request #239 from Constellation/mod-256 2025-11-12 kmiller68@users.noreply.github.com Merge pull request #225 from kmiller68/reduce-kotlin-iteration-count 2025-11-07 ysuzuki@apple.com Merge pull request #236 from Constellation/use-integer 2025-11-05 camillobruni@users.noreply.github.com sync-fs and async-fs improvements (#217) 2025-11-04 camillobruni@users.noreply.github.com More ubuntu tests (#235) 2025-11-04 kmiller68@users.noreply.github.com Merge pull request #188 from kmiller68/dotnet-legacy-exceptions 2025-10-30 camillobruni@users.noreply.github.com Github Workflow: split tests (#227) 2025-10-30 camillobruni@users.noreply.github.com Enable mobx-startup (#233) 2025-10-30 camillobruni@users.noreply.github.com More top-level cleanup (#229) 2025-10-30 camillobruni@users.noreply.github.com Improve preload code (#230) 2025-10-30 kmiller68@users.noreply.github.com Merge pull request #226 from kmiller68/console-warn-and-error-stderr-clis 2025-10-30 camillobruni@users.noreply.github.com Fix npm run test:build (#232) 2025-10-30 kmiller68@users.noreply.github.com Merge pull request #212 from kmiller68/disable-whisper-wasm 2025-10-29 camillobruni@users.noreply.github.com New Workload: Babylon class-heavy workload (#143) 2025-10-29 camillobruni@users.noreply.github.com Avoid new Date and improve filename extraction in doxbee benchmarks (#231) 2025-10-28 camillobruni@users.noreply.github.com New Workload: mobx observer + startup (#151) 2025-10-28 camillobruni@users.noreply.github.com StartupBenchmark refactoring (#218) 2025-10-27 camillobruni@users.noreply.github.com Add post-quit sleep for Safari (#220) 2025-10-27 kmiller68@users.noreply.github.com Enable jsdom-d3-startup by default. (#223) 2025-10-27 camillobruni@users.noreply.github.com More consistent LICENSE.txt files (#221) 2025-10-27 camillobruni@users.noreply.github.com Move more code to utils (#219) 2025-10-23 camillobruni@users.noreply.github.com Add npm run test:build script (#189) 2025-10-23 kmiller68@users.noreply.github.com Merge pull request #216 from kmiller68/total-to-overall-summary 2025-10-23 camillobruni@users.noreply.github.com render non default params (#197) 2025-10-23 camillobruni@users.noreply.github.com New Workload: JSDOM + d3 (#124) 2025-10-22 camillobruni@users.noreply.github.com Update test.yml (#190) 2025-10-22 camillobruni@users.noreply.github.com Await driver.quit (#209) 2025-10-22 camillobruni@users.noreply.github.com Add explicit version checks (#211) 2025-10-22 camillobruni@users.noreply.github.com Improve iterationCount and worstCaseCount params parsing (#215) 2025-10-22 camillobruni@users.noreply.github.com More consistent total score printing (#213) 2025-10-22 camillobruni@users.noreply.github.com Do not trigger logo animations again after loading all resources (#214) 2025-10-22 camillobruni@users.noreply.github.com support startAutomatically (#201) 2025-10-22 camillobruni@users.noreply.github.com Conditionally show more metric details (#167) 2025-10-22 camillobruni@users.noreply.github.com fix gaussian-blur input data (#207) 2025-10-22 camillobruni@users.noreply.github.com Improve tags (#206) 2025-10-22 camillobruni@users.noreply.github.com update selenium-webdriver version (#208) 2025-10-21 camillobruni@users.noreply.github.com Auto decompress files as part of test running (#195) 2025-10-17 camillobruni@users.noreply.github.com Support multiple comma separate tests in URL params (#198) 2025-10-15 danleh@users.noreply.github.com Merge pull request #77 from Constellation/base64 2025-10-15 camillobruni@users.noreply.github.com Fix prismjs sample file name(#202) 2025-10-08 camillobruni@users.noreply.github.com Add prettier config (#176) 2025-10-07 kmiller68@users.noreply.github.com Merge pull request #170 from eqrion/zlib-compress 2025-10-03 kmiller68@users.noreply.github.com Merge pull request #194 from victorvianna/main 2025-10-03 ysuzuki@apple.com Change shouldReport to report back 2025-10-03 camillobruni@users.noreply.github.com Compact display for non-default params (#191) 2025-10-01 camillobruni@users.noreply.github.com Add group-details parameter to conditionally display grouped benchmarks (#157) 2025-10-01 camillobruni@users.noreply.github.com New Workload: prismjs source code highlighting (#149) 2025-10-01 camillobruni@users.noreply.github.com New Workload: validatorjs regexp heavy workload (#147) 2025-09-23 ysuzuki@apple.com Merge pull request #192 from Constellation/dump-test-list 2025-09-22 camillobruni@users.noreply.github.com New Workload: TypeScript standalone (#117) 2025-09-19 kmiller68@users.noreply.github.com Merge pull request #187 from kmiller68/fix-web-ssr-for-options-bag 2025-09-17 keith_miller@apple.com Test is causing jetsams on iOS. Disabling for now while I investigate. 2025-09-17 camillobruni@users.noreply.github.com Add JetStreamParams (#171) 2025-09-17 camillobruni@users.noreply.github.com New Workload: React Server Side Rendering Startup (#116) 2025-09-17 danleh@users.noreply.github.com Merge pull request #130 from danleh/j2cl-box2d 2025-09-16 danleh@users.noreply.github.com Merge pull request #182 from danleh/recompile-dotnet 2025-09-16 danleh@users.noreply.github.com Merge pull request #148 from danleh/transformersjs-rebase 2025-09-11 camillobruni@users.noreply.github.com Experimental Workload: Intl (#146) 2025-09-10 danleh@users.noreply.github.com Merge pull request #178 from danleh/disable-gcc-loops-quicksort 2025-09-08 kmiller68@users.noreply.github.com Merge pull request #168 from kmiller68/reduce-dotnet-runtime 2025-09-03 camillobruni@users.noreply.github.com More consistent metric reporting (#175) 2025-09-03 camillobruni@users.noreply.github.com Minor browser test improvements (#177) 2025-09-03 danleh@users.noreply.github.com Merge pull request #173 from danleh/text-decoder-polyfill-move 2025-09-03 camillobruni@users.noreply.github.com Remove unused scripts (#174) 2025-09-02 danleh@users.noreply.github.com Merge pull request #172 from danleh/compress-js 2025-09-01 camillobruni@users.noreply.github.com Update/rewrite web-tooling-benchmark (#153) 2025-09-01 camillobruni@users.noreply.github.com Support custom benchmark arguments (#165) 2025-09-01 camillobruni@users.noreply.github.com Status update and CSS fixes (#169) 2025-08-27 camillobruni@users.noreply.github.com Use event.key instead of event.which #166 2025-08-27 danleh@users.noreply.github.com Merge pull request #144 from danleh/logo-text-to-path 2025-08-26 camillobruni@users.noreply.github.com StartupBenchmark: add better assertion failures (#164) 2025-08-26 camillobruni@users.noreply.github.com Add UTF16 sources test (#162) 2025-08-26 camillobruni@users.noreply.github.com Convert startup-helper/BabelCacheBuster.js to esm (#163) 2025-08-26 camillobruni@users.noreply.github.com Add startup benchmark helper (#158) 2025-08-20 danleh@users.noreply.github.com Merge pull request #159 from danleh/dotnet-wasm-rename 2025-08-15 camillobruni@users.noreply.github.com Expose JetStream global to workloads (#139) 2025-08-15 ysuzuki@apple.com Merge pull request #145 from Constellation/tfjs 2025-08-14 camillobruni@users.noreply.github.com Only expose a console copy in the realm (#137) 2025-08-14 kmiller68@users.noreply.github.com Merge pull request #133 from kmiller68/add-grouped-benchmark-for-sunspider 2025-08-14 danleh@users.noreply.github.com Merge pull request #142 from danleh/Dart-remove-unused-runner 2025-08-14 danleh@users.noreply.github.com Merge pull request #140 from danleh/disable-HashSet-wasm 2025-08-14 camillobruni@users.noreply.github.com merge async-fs code (#135) 2025-08-14 camillobruni@users.noreply.github.com Enable UniPoker validation by default (#141) 2025-08-14 danleh@users.noreply.github.com Merge pull request #138 from danleh/kotlin-fix-isD8-access 2025-08-14 camillobruni@users.noreply.github.com Bump selenium-webdriver version (#136) 2025-08-14 danleh@users.noreply.github.com Merge pull request #97 from eqrion/dart-todomvc 2025-08-14 camillobruni@users.noreply.github.com Improve console (#131) 2025-08-14 camillobruni@users.noreply.github.com Improve runner code (#134) 2025-08-14 camillobruni@users.noreply.github.com Rename worst4 to just worst (#129) 2025-08-13 ysuzuki@apple.com Merge pull request #127 from Constellation/list 2025-08-13 danleh@users.noreply.github.com Merge pull request #84 from danleh/kotlin 2025-08-12 camillobruni@users.noreply.github.com CSS fixes for info button (#126) 2025-08-12 camillobruni@users.noreply.github.com Add info-button (#123) 2025-08-11 ysuzuki@apple.com Merge pull request #119 from Constellation/set-status 2025-08-11 camillobruni@users.noreply.github.com Display workload scatterplots (#120) 2025-08-11 camillobruni@users.noreply.github.com Update .gitignore (#121) 2025-08-07 kmiller68@users.noreply.github.com Merge pull request #115 from kmiller68/fix-bencharks-by-tag-testlist 2025-08-06 camillobruni@users.noreply.github.com Configurable resource prefetching (#70) 2025-08-06 camillobruni@users.noreply.github.com github workflow: keep running all tests even if there are failures (#114) 2025-08-05 camillobruni@users.noreply.github.com Add Scripts helper classes (#109) 2025-08-05 iireland@mozilla.com Add three.js benchmark (#75) 2025-08-04 camillobruni@users.noreply.github.com Add validate method for async-fs and sync-fs (#111) 2025-08-04 camillobruni@users.noreply.github.com Add more performance.measure (#110) 2025-07-31 camillobruni@users.noreply.github.com Remove LuaJSFight micro benchmarks (#104) 2025-07-31 camillobruni@users.noreply.github.com Add cli flags (#101) 2025-07-31 camillobruni@users.noreply.github.com Cleanup performance.now shimming (#108) 2025-07-30 camillobruni@users.noreply.github.com Formatting (#105) 2025-07-30 camillobruni@users.noreply.github.com Run all disabled workloads in tests (#103) 2025-07-30 camillobruni@users.noreply.github.com Add benchmarks argument to Driver (#98) 2025-07-29 kmiller68@users.noreply.github.com Merge pull request #102 from kmiller68/reenable-dotnet-tests 2025-07-29 camillobruni@users.noreply.github.com Simplify updateUIAfterRun (#99) 2025-07-29 camillobruni@users.noreply.github.com Merge customTestList and testList (#100) 2025-07-29 camillobruni@users.noreply.github.com Use tags for workload selection (#82) 2025-07-23 danleh@users.noreply.github.com Merge pull request #93 from danleh/cleanup-loadInternal 2025-07-23 kmiller68@users.noreply.github.com Merge pull request #73 from maraf/DotnetWasm 2025-07-21 camillobruni@users.noreply.github.com Fix typo in headers fetch request (#80) 2025-07-15 camillobruni@users.noreply.github.com use default performance.measure implementation (#83) 2025-07-15 camillobruni@users.noreply.github.com Use subScores directly for the UI (#81) 2025-07-15 camillobruni@users.noreply.github.com Add basic unittests (#94) 2025-07-14 camillobruni@users.noreply.github.com Fix accidental loading status clipping in wide windows (#85) 2025-07-14 camillobruni@users.noreply.github.com Simplify formatting (#79) 2025-07-12 kmiller68@users.noreply.github.com Merge pull request #90 from kmiller68/fix-prepareForNextIteration-async-benchmark 2025-07-10 kmiller68@users.noreply.github.com Merge pull request #74 from kmiller68/preload-blobs-wasm 2025-07-08 kmiller68@users.noreply.github.com Merge pull request #76 from kmiller68/zlib-check-_compressFile-to-setupModule 2025-07-02 ysuzuki@apple.com Revert #78 as it broke JetStream3 on web page 2025-07-02 camillobruni@users.noreply.github.com Remove custom run methods #78 2025-06-04 yusukesuzuki@slowstart.org Merge pull request #72 from Constellation/new-string 2025-05-13 kmiller68@users.noreply.github.com Merge pull request #71 from kmiller68/disable-extra-bigint-tests 2025-05-13 camillobruni@users.noreply.github.com Merge pull request #65: OfflineAssembler: Avoid accidental toString operation 2025-05-13 camillobruni@users.noreply.github.com Merge pull request #64: WSL: Add performance.mark 2025-05-13 camillobruni@users.noreply.github.com Merge pull request #60: date-format: Add result hashing to prevent DCE 2025-05-13 camillobruni@users.noreply.github.com Merge pull request #62: Avoid eval in date-format-tofte 2025-05-05 kmiller68@users.noreply.github.com Merge pull request #53 from mkustermann/js-strings 2025-04-24 camillobruni@users.noreply.github.com Merge pull request #67 from issackjohn/issack/add-edge 2025-04-24 camillobruni@users.noreply.github.com Merge pull request #61 from camillobruni/2025-03-26_gbemu_hash 2025-04-07 kmiller68@users.noreply.github.com Merge pull request #59 from camillobruni/2025-03-26_cli_error_handling 2025-04-07 kmiller68@users.noreply.github.com Merge pull request #42 from camillobruni/2025-01-28_cli_tests 2025-04-07 kmiller68@users.noreply.github.com Merge pull request #41 from camillobruni/2025-01-28_runner_log 2025-04-07 kmiller68@users.noreply.github.com Merge pull request #14 from camillobruni/2024-11-26_tags 2025-03-12 kmiller68@users.noreply.github.com Merge pull request #57 from kmiller68/module-url-fix-v2 2025-02-27 kmiller68@users.noreply.github.com Merge pull request #51 from danleh/main 2025-02-27 kmiller68@users.noreply.github.com Merge pull request #52 from kmiller68/pathname-browser-dart 2025-02-26 kmiller68@users.noreply.github.com Merge pull request #33 from danleh/dart-flute-wasm-squash 2025-02-26 kmiller68@users.noreply.github.com Merge pull request #47 from kmiller68/argon2-to-js-scoring-v2 2025-02-26 kmiller68@users.noreply.github.com Merge pull request #40 from danleh/8bitbench-wasm-scoring 2025-02-12 kmiller68@users.noreply.github.com Merge pull request #43 from danleh/zlib-wasm 2025-02-10 kmiller68@users.noreply.github.com Merge pull request #45 from danleh/richards-workload-size-as-input 2025-02-07 kmiller68@users.noreply.github.com Merge pull request #44 from danleh/wasm-workload-sizes 2025-01-28 kmiller68@users.noreply.github.com Merge pull request #39 from camillobruni/2025-01-28_test_runner_fix 2025-01-27 kmiller68@users.noreply.github.com Merge pull request #35 from danleh/hashset-wasm-scoring 2025-01-27 kmiller68@users.noreply.github.com Merge pull request #30 from danleh/sqlite-scoring 2025-01-27 kmiller68@users.noreply.github.com Merge pull request #28 from danleh/quicksort-wasm-scoring 2025-01-27 kmiller68@users.noreply.github.com Merge pull request #37 from WebKit/remove-octane-zlib 2025-01-24 keith_miller@apple.com Revert "Remove Octane-zlib." 2025-01-24 keith_miller@apple.com Remove Octane-zlib. 2025-01-24 kmiller68@users.noreply.github.com Merge pull request #13 from camillobruni/2024-11-22_driver_prep 2025-01-24 kmiller68@users.noreply.github.com Merge pull request #11 from camillobruni/2024-11-26_github_actions 2025-01-23 kmiller68@users.noreply.github.com Merge pull request #27 from danleh/richards-js-scoring 2025-01-22 kmiller68@users.noreply.github.com Merge pull request #34 from WebKit/fix-report-JSON 2025-01-22 kmiller68@users.noreply.github.com Merge pull request #32 from danleh/performance-mark-measure 2025-01-21 kmiller68@users.noreply.github.com Merge pull request #31 from WebKit/revert-tfjs-to-js-scoring 2025-01-21 kmiller68@users.noreply.github.com Merge pull request #16 from camillobruni/2024-11-26_ms 2025-01-21 kmiller68@users.noreply.github.com Merge pull request #26 from danleh/gcc-loops-js-scoring 2025-01-16 kmiller68@users.noreply.github.com Merge pull request #23 from WebKit/tfjs-to-js-scoring 2025-01-16 kmiller68@users.noreply.github.com Merge pull request #17 from camillobruni/2024-11-26_safe_add 2025-01-16 kmiller68@users.noreply.github.com Merge pull request #25 from danleh/spidermonkey-cli-fix 2025-01-08 kmiller68@users.noreply.github.com Merge pull request #21 from WebKit/remove-float-mm-c 2024-12-21 kmiller68@users.noreply.github.com Merge pull request #18 from WebKit/wasm-benchmarks-should-be-scored-like-js-benchmarks 2024-12-20 kmiller68@users.noreply.github.com Merge pull request #2 from danleh/sqlite-wasm 2024-12-09 kmiller68@users.noreply.github.com Merge pull request #5 from camillobruni/2024-11-22_runner_improvements 2024-12-09 kmiller68@users.noreply.github.com Merge pull request #8 from camillobruni/2024-11-22_regexp 2024-12-09 kmiller68@users.noreply.github.com Merge pull request #19 from camillobruni/2024-11-27_async_fs 2024-11-26 kmiller68@users.noreply.github.com Merge pull request #7 from camillobruni/2024-11-22_driver_vars 2024-11-25 kmiller68@users.noreply.github.com Merge pull request #4 from camillobruni/2024-11-22_3dcube_fix 2024-11-25 kmiller68@users.noreply.github.com Merge pull request #6 from camillobruni/2024-11-22_gitignore 2024-11-13 kmiller68@users.noreply.github.com Merge pull request #1 from danleh/main 2024-10-30 keith_miller@apple.com Initial copy from WebKit/PerformanceTests/JetStream3 2024-10-30 kmiller68@users.noreply.github.com Initial commit If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/jetstream-v3-0-custom-v8 Please CC mliedtke@google.com,nicohartmann@google.com,v8-waterfall-gardeners@google.com on the revert to ensure that a human is aware of the problem. To file a bug in JetStream v3.0-custom: https://issues.chromium.org/u/1/issues/new?component=1741045&pli=1&template=0 To file a bug in V8: https://issues.chromium.org/u/1/issues/new?component=1456824&pli=1&template=2109136 To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: mliedtke@google.com,nicohartmann@google.com Change-Id: Ic53c7e030a05111ba56e03ab158282762aa17360 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7823185 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Bot-Commit: chromium-autoroll@skia-public.iam.gserviceaccount.com <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#107273}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jakobkummerow https://docs.python.org/3/library/exceptions.html#Exception is the base class for most Python errors and
Erroris undefined in this context so NameError will be raised instead of the desired exception message.