Fix missing lock guard#39
Closed
NewProggie wants to merge 1 commit into
Closed
Conversation
This commit fixes a bug where the lock guard (for concurrently accessing the same scope from different threads) had basically no effect, due to being bound to a temporary only.
Member
|
Thanks for this fix. Looks legit. Please note that we do not accept PRs via github. Please consult the official docs if you wish to contribute to v8. In this case though, the code in question was imported from the wasm-c-api repository. That one in fact does accept Github PRs :) @jakobkummerow FYI |
billti
pushed a commit
to billti/v8
that referenced
this pull request
Apr 6, 2020
(cherry picked from commit 86a6ce4) No-Try: true No-Presubmit: true No-Treechecks: true Bug: chromium:1034449 Change-Id: Id121b60af0c8c8621464f15aa754056cecb04595 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2064985 Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#66386} Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2078549 Cr-Commit-Position: refs/branch-heads/8.1@{v8#39} Cr-Branched-From: a4dcd39-refs/heads/8.1.307@{#1} Cr-Branched-From: f22c213-refs/heads/master@{#66031}
ghost
referenced
this pull request
in riscv-collab/v8
Jul 15, 2020
Resolve "test-run-machops/RunFloat32Min failed" Closes #39 See merge request swlab/swe/v8!52
Kwizatz
pushed a commit
to AeonGames/v8
that referenced
this pull request
Sep 2, 2020
The resolvedOptions of Intl.NumberFormat depends on the ICU's skeleton. sffc change the output of the wildcard from + to * in ICU67 (unicode-org/icu@ac4540f) Change the v8 code to use * instead. TBR=syg@chromium.org (cherry picked from commit 87563c3) No-Try: true No-Presubmit: true No-Tree-Checks: true Bug: chromium:1108810 Change-Id: I8b0249a5bc4cc199f454c5070635100f68d1f48d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2336635 Reviewed-by: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/branch-heads/8.5@{v8#39} Cr-Branched-From: a7f8bc4-refs/heads/8.5.210@{#1} Cr-Branched-From: dd58472-refs/heads/master@{#68510}
ceejatec
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Sep 24, 2020
TBR=bbudge@chromium.org (cherry picked from commit 02a06c4) No-Try: true No-Presubmit: true No-Tree-Checks: true Change-Id: I300292b6ae93e591d95cf0cc2c0c8cc08b42c6ab Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1890099 Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/branch-heads/7.8@{v8#39} Cr-Branched-From: 73694fd-refs/heads/7.8.279@{#1} Cr-Branched-From: 2314928-refs/heads/master@{#63555}
ceejatec
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Sep 24, 2020
When switching from atomicops to std::atomic, I introduced a bug that makes us miss the actual peak memory consumption, and only report the second-highest memory usage in each zone. This CL fixes that. TBR=petermarshall@chromium.org Bug: chromium:939724 No-Try: true No-Presubmit: true No-Tree-Checks: true Change-Id: I9bdab84beadc7c78488449cd5d5be6ee64601370 Originally-reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541227 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559731 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/branch-heads/7.4@{v8#39} Cr-Branched-From: 3e8a733-refs/heads/7.4.288@{#1} Cr-Branched-From: d077f9b-refs/heads/master@{#60039}
ceejatec
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Sep 24, 2020
…tion" This reverts commit 10883f5. Bug: v8:7427, chromium:1021457 Change-Id: Ib7f54158a2030a0c427c24b108a4eb76658d3ee0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1901909 Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Joshua Litt <joshualitt@chromium.org> Cr-Commit-Position: refs/branch-heads/7.9@{v8#39} Cr-Branched-From: be181e2-refs/heads/7.9.317@{#1} Cr-Branched-From: 0d7889d-refs/heads/master@{#64307}
ceejatec
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Sep 24, 2020
Revision: 8738ab8 BUG=v8:10198,v8:9706,chromium:1045034 NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=ulan@chromium.org Change-Id: Ieeca890abf68f15a4a73834fbef3e0677fd799b0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2056851 Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/branch-heads/8.0@{v8#39} Cr-Branched-From: 69827db-refs/heads/8.0.426@{v8#2} Cr-Branched-From: 2fe1552-refs/heads/master@{#65318}
ceejatec
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Sep 24, 2020
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I4a009bfe2825d76f4efbcf91c741be63f43feeb3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1510580 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7.3@{v8#39} Cr-Branched-From: 9df9418-refs/heads/7.3.492@{v8#2} Cr-Branched-From: be213cf-refs/heads/master@{#59024}
ceejatec
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Sep 24, 2020
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: Idb520787ba89be93db5c3759d83d9d3c337a4fe5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1690701 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7.6@{v8#39} Cr-Branched-From: 2cb2573-refs/heads/7.6.303@{#1} Cr-Branched-From: 201c509-refs/heads/master@{#61902}
ceejatec
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Sep 24, 2020
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I7ddab11accce670c26f3a10fb0ebb467bc1c6b6f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1622787 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7.5@{v8#39} Cr-Branched-From: 35b9bf5-refs/heads/7.5.288@{#1} Cr-Branched-From: 912b391-refs/heads/master@{#60911}
ceejatec
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Sep 24, 2020
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: Ie6c89a872af4cc5a80e34d352c32bb913cc3948a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2309291 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/8.4@{v8#39} Cr-Branched-From: 88ed2e3-refs/heads/8.4.371@{#1} Cr-Branched-From: 35f88bf-refs/heads/master@{#67773}
Kwizatz
pushed a commit
to AeonGames/v8
that referenced
this pull request
Jul 25, 2021
(cherry picked from commit 387c803) No-Try: true No-Presubmit: true No-Tree-Checks: true Tbr: ishell@chromium.org Bug: chromium:1203122 Change-Id: I34f2dfae082cab24ef92dd627bc64e78b889b9ca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2871448 Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/branch-heads/9.1@{v8#39} Cr-Branched-From: 0e4ac64-refs/heads/9.1.269@{#1} Cr-Branched-From: f565e72-refs/heads/master@{#73847}
BenPope
pushed a commit
to BenPope/v8
that referenced
this pull request
Dec 10, 2021
Change-Id: Ic173ec8154de1d4134b47b7958a8fb3917db328d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3311129 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/9.6@{v8#39} Cr-Branched-From: 0b7bda0-refs/heads/9.6.180@{#1} Cr-Branched-From: 41a5a24-refs/heads/main@{#77244}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
This avoids a DCHECK failure if we continue using the Assembler after code generation abortion. Even though it might not be the best style to still call methods on the Assembler after abortion, it's not a problem apart from the firing DCHECK, so we apply this simple fix instead of making sure to really abort everything immediately. TBR=leszeks@chromium.org (cherry picked from commit 66f5de1) Bug: chromium:1228720, chromium:1217074 Change-Id: Ie0adfd50399b8725e40b2bb43839ff3c7c4623f4 No-Try: true No-Presubmit: true No-Tree-Checks: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3035085 Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/branch-heads/9.2@{v8#39} Cr-Branched-From: 5123834-refs/heads/9.2.230@{#1} Cr-Branched-From: 587a04f-refs/heads/master@{#74656}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
Back-merge the following commits and stage exception handling: [wasm][eh] Fix delegate opcode https://chromium-review.googlesource.com/c/v8/v8/+/2632604 [wasm][eh] Update delegate validation rules https://chromium-review.googlesource.com/c/v8/v8/+/2656318 [wasm][eh] Fix catch_all encoding https://chromium-review.googlesource.com/c/v8/v8/+/2674007 [wasm][eh] Misc fixes found by local fuzzing https://chromium-review.googlesource.com/c/v8/v8/+/2692688 [wasm][eh] Implicit rethrow after unwind https://chromium-review.googlesource.com/c/v8/v8/+/2696662 [wasm][eh] Update catch_all encoding https://chromium-review.googlesource.com/c/v8/v8/+/2699258 [wasm][eh] Fix merge with phi in delegate https://chromium-review.googlesource.com/c/v8/v8/+/2707167 R=clemensb@chromium.org No-Try: true No-Presubmit: true No-Tree-Checks: true Bug: v8:11489 Change-Id: I357acb659b5df7c23dbcae1ec0cb7c92f44c4cbc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2712785 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/branch-heads/8.9@{v8#39} Cr-Branched-From: 16b9bbb-refs/heads/8.9.255@{#1} Cr-Branched-From: d16a2a6-refs/heads/master@{#72039}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
Bug: chromium:569479 Change-Id: I3e038209b2a87b63a41817eac179eccbcc25afe7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3199882 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/branch-heads/9.4@{v8#39} Cr-Branched-From: 3b51863-refs/heads/9.4.146@{#1} Cr-Branched-From: 2890419-refs/heads/master@{#76233}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: Ic66a17876fa46d9cbeca48e5f6a9ab02b493e16c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3218786 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/9.5@{v8#39} Cr-Branched-From: 4a03d61-refs/heads/9.5.172@{#1} Cr-Branched-From: 9a60704-refs/heads/main@{#76741}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I49219925e9ff21e0e5c9bcea313b98bc4c9bf245 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2503882 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/8.6@{v8#39} Cr-Branched-From: a64aed2-refs/heads/8.6.395@{#1} Cr-Branched-From: a626bc0-refs/heads/master@{#69472}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
Revision: 5fe919f NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=junyan@redhat.com Bug: v8:13178 Change-Id: I087fc135f2cc3d72386a25ff28cbd44259e822a8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3826054 Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Reviewed-by: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/branch-heads/10.4@{v8#39} Cr-Branched-From: b1413ed-refs/heads/10.4.132@{#1} Cr-Branched-From: 9d0a093-refs/heads/main@{#80972}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
(Cherry-pick to M93.) Refactor code such that the linear algorithm is actually executed outside the method for the fixpoint iteration. Also added a CHECK which verifies that iterating the ephemerons one more time results in no further marked objects. Also force another iteration when ProcessMarkingWorklist() processed some object. In such cases we need to re-process all ephemerons otherwise ephemeron semantics might be broken. (cherry picked from commit 1054ee7) No-Try: true No-Presubmit: true No-Tree-Checks: true Bug: chromium:1252918 Change-Id: I9123dda50e34227a04825fd8b3172368286cc76f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3200290 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Owners-Override: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/branch-heads/9.3@{v8#39} Cr-Branched-From: 7744dce-refs/heads/9.3.345@{#1} Cr-Branched-From: 4b6b4ca-refs/heads/master@{#75728}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
Revision: d4aafa4 TBR=glazunov@chromium.org BUG=chromium:1198696 NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true Change-Id: I1840ffabbed3a3caab75b0abea1d37d9ed446d3f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2833911 Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/branch-heads/9.0@{v8#39} Cr-Branched-From: bd0108b-refs/heads/9.0.257@{#1} Cr-Branched-From: 349bcc6-refs/heads/master@{#73001}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
Change-Id: I5e0ab7daa109fde98a3ee07869375d30ddbc658b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3398814 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/9.7@{v8#39} Cr-Branched-From: 49162da-refs/heads/9.7.106@{#1} Cr-Branched-From: a7e9b8f-refs/heads/main@{#77674}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
The sp register's value should be modified to drop all the args from the stack. (cherry picked from commit 8557840) NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true Change-Id: If68f606c38cf7249f3e215716e47b190c874eba7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2524417 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Reviewed-by: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/branch-heads/8.7@{v8#39} Cr-Branched-From: 0d81cd7-refs/heads/8.7.220@{#1} Cr-Branched-From: 942c2ef-refs/heads/master@{#70196}
patrik-lengweiler
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
May 31, 2023
Bug: chromium:1413661 Change-Id: Ib5731db33a51b2a9fbb64ebc81e90a5d8bce2f10 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4342395 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Alexander Schulze <alexschulze@chromium.org> Cr-Commit-Position: refs/branch-heads/11.0@{v8#39} Cr-Branched-From: 06097c6-refs/heads/11.0.226@{#1} Cr-Branched-From: 6bf3344-refs/heads/main@{#84857}
patrik-lengweiler
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
May 31, 2023
M102 merge issues: Conflicts on tools/v8heapconst.py; Reverted the conflicting changes and generated a new v8heapconst.py following the tests/mkgrokdump/README instructions This is a reland of commit e08fa94 Changes since revert: Use max(remainingElements - 1, index + 1) instead of index + 1 as newCapacity computation to avoid excessive allocations causing the timeout. Original change's description: > [Promise.any] Fix errors allocation > > Bug: chromium:1379054 > Change-Id: Ibfcdd4ddc3c9a26471094074c8e7810d93abc898 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3988924 > Commit-Queue: Marja Hölttä <marja@chromium.org> > Auto-Submit: Shu-yu Guo <syg@chromium.org> > Reviewed-by: Marja Hölttä <marja@chromium.org> > Cr-Commit-Position: refs/heads/main@{#83968} (cherry picked from commit 8b35091) Bug: chromium:1379054 No-Try: true No-Presubmit: true No-Tree-Checks: true Change-Id: Ic788b8d0b42f4e24eaf8b2f2d05b24390fda247b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3990627 Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#83987} Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4020423 Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Roger Felipe Zanoni da Silva <rzanoni@google.com> Cr-Commit-Position: refs/branch-heads/10.2@{v8#39} Cr-Branched-From: 374091f-refs/heads/10.2.154@{#1} Cr-Branched-From: f0c353f-refs/heads/main@{#79976}
patrik-lengweiler
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
May 31, 2023
This is a reland of commit 91fce33 Changes since revert: - Skip added test in no-internalization builds. Original change's description: > [regexp] Handle empty ranges in unicode sets > > If a unicode set operation contains only an empty range, we generated a > set expression without operands. However the expression should match > nothing, so add the special operand not matching anything instead. > > Bug: chromium:1437346 > Change-Id: I8dd58884aaf6915277c80effbda43ea715049146 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4474547 > Commit-Queue: Patrick Thier <pthier@chromium.org> > Reviewed-by: Jakob Linke <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/main@{#87257} Bug: chromium:1437346 (cherry picked from commit cb8697b) Change-Id: I82c3262def6e78e403737507fb9ac25851550fdc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4488910 Reviewed-by: Francis McCabe <fgm@chromium.org> Commit-Queue: Francis McCabe <fgm@chromium.org> Cr-Commit-Position: refs/branch-heads/11.2@{v8#39} Cr-Branched-From: 755511a-refs/heads/11.2.214@{#1} Cr-Branched-From: e6b1cce-refs/heads/main@{#86014}
patrik-lengweiler
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
May 31, 2023
This reverts commit b579b43. Reason for revert: Don't merge to extended stable before regular stable release (See bug for details) Original change's description: > Merged: Reland "[regexp] Handle empty ranges in unicode sets" > > This is a reland of commit 91fce33 > > Changes since revert: > - Skip added test in no-internalization builds. > > Original change's description: > > [regexp] Handle empty ranges in unicode sets > > > > If a unicode set operation contains only an empty range, we generated a > > set expression without operands. However the expression should match > > nothing, so add the special operand not matching anything instead. > > > > Bug: chromium:1437346 > > Change-Id: I8dd58884aaf6915277c80effbda43ea715049146 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4474547 > > Commit-Queue: Patrick Thier <pthier@chromium.org> > > Reviewed-by: Jakob Linke <jgruber@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#87257} > > Bug: chromium:1437346 > (cherry picked from commit cb8697b) > > Change-Id: I82c3262def6e78e403737507fb9ac25851550fdc > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4488910 > Reviewed-by: Francis McCabe <fgm@chromium.org> > Commit-Queue: Francis McCabe <fgm@chromium.org> > Cr-Commit-Position: refs/branch-heads/11.2@{v8#39} > Cr-Branched-From: 755511a-refs/heads/11.2.214@{#1} > Cr-Branched-From: e6b1cce-refs/heads/main@{#86014} Bug: chromium:1437346 Change-Id: I8fe292efb2a1c5faf00c074844f0d1b116639c6a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4491843 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/branch-heads/11.2@{v8#41} Cr-Branched-From: 755511a-refs/heads/11.2.214@{#1} Cr-Branched-From: e6b1cce-refs/heads/main@{#86014}
patrik-lengweiler
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
May 31, 2023
Roll /build: https://chromium.googlesource.com/chromium/src/build/+log/339f8c6..6180903f This includes https://crrev.com/c/3874828 which fixes flaky compilation problems seen on the 10.6 V8 trybots: https://ci.chromium.org/ui/p/v8/builders/try/v8_win_compile_dbg/b8800699999726054577/overview This also rolls buildtools, libcxx and clang, since they have dependencies with changes on /build. This deps updates do not affect the Chrome release as it only updates deps used to build V8 stand-alone, not V8 in Chrome. This also also disables the extra-semi check which was enabled in the same roll as otherwise a lot of source fixes need to be merged, too. Bug: chromium:1337238 Change-Id: I92c74716fe36811761296e3bad1afe68e05beec8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3941885 Reviewed-by: Liviu Rau <liviurau@google.com> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/branch-heads/10.6@{v8#39} Cr-Branched-From: 41bc743-refs/heads/10.6.194@{#1} Cr-Branched-From: d5f29b9-refs/heads/main@{#82548}
patrik-lengweiler
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
May 31, 2023
Change-Id: I4c5ca394e3e3cc6d4bb5e2392825cc213180334e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4006734 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/10.7@{v8#39} Cr-Branched-From: 4d2145c-refs/heads/10.7.193@{#1} Cr-Branched-From: 9521696-refs/heads/main@{#83201}
patrik-lengweiler
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
Jun 9, 2023
Revision: bf6aa50 BUG=v8:7700, chromium:1440723 NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=verwaest@chromium.org Change-Id: Idfeff2d407c9b49714b7aaf75bcaf15466dc8a2d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4556326 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/branch-heads/11.4@{v8#39} Cr-Branched-From: 8a8a1e7-refs/heads/11.4.183@{#1} Cr-Branched-From: 5483d8e-refs/heads/main@{#87241}
patrik-lengweiler
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
Jul 26, 2023
(cherry picked from commit b947905) Bug: v8:7748, chromium:1466183 Change-Id: I6d7de33e0cec37747045269f441e65f7a482dd4f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4701553 Auto-Submit: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#89060} Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4714687 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/branch-heads/11.5@{v8#39} Cr-Branched-From: 0c4044b-refs/heads/11.5.150@{#1} Cr-Branched-From: b71d303-refs/heads/main@{#87781}
reposynch Bot
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
Sep 15, 2023
Change-Id: I0f4878bc1cfdab2cd8ac6c0dc49da7d770b6028e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4864262 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/11.6@{v8#39} Cr-Branched-From: e29c028-refs/heads/11.6.189@{v8#3} Cr-Branched-From: 95cbef2-refs/heads/main@{#88340}
reposynch Bot
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
Oct 1, 2023
…g check The 'EnterFrame' function of loong64 and mips64 port doesn't push context pointer on the stack. Bug: v8:14340 (cherry picked from commit ab15dc3) Change-Id: I5ef106a4f6a4d9485a149c2511566d3375e849a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4899639 Auto-Submit: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Reviewed-by: Lutz Vahl <vahl@chromium.org> Commit-Queue: Lutz Vahl <vahl@chromium.org> Cr-Commit-Position: refs/branch-heads/11.7@{v8#39} Cr-Branched-From: fe60869-refs/heads/11.7.439@{#1} Cr-Branched-From: aeb4552-refs/heads/main@{#89415}
reposynch Bot
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
Jan 14, 2024
Maglev assumes that when a SharedFunctionInfo has a BytecodeArray, then it should also have FeedbackMetadata. However, this may not hold with concurrent compilation when the SharedFunctionInfo is re-compiled after being flushed. Here the BytecodeArray was installed on the SFI before the FeedbackMetadata and a concurrent thread could observe the BytecodeArray but not the FeedbackMetadata. Drive-by: Reset the age field before setting the BytecodeArray as well. This ensures that the concurrent marker will not observe the old age for the new BytecodeArray. Bug: chromium:1507412 (cherry picked from commit 46cb67e) Change-Id: I7b876a5195ed16ae94ca9ffbca0fb51cfdb5e809 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5180368 Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/branch-heads/12.1@{v8#39} Cr-Branched-From: b74ef6f-refs/heads/12.1.285@{#1} Cr-Branched-From: 32857fb-refs/heads/main@{#91313}
hubot
pushed a commit
that referenced
this pull request
Feb 27, 2024
Change-Id: I4afdf1ff3234f950aaf9c2073014298e1d331eef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5324064 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/12.2@{#39} Cr-Branched-From: 6eb5a96-refs/heads/12.2.281@{#1} Cr-Branched-From: 44cf56d-refs/heads/main@{#91934}
hubot
pushed a commit
that referenced
this pull request
Mar 13, 2024
Change-Id: I2e8d96bf217d0db15c8ae23d48477fc933e019a6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5365127 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/12.0@{#39} Cr-Branched-From: ed7b4ca-refs/heads/12.0.267@{#1} Cr-Branched-From: 210e75b-refs/heads/main@{#90651}
hubot
pushed a commit
that referenced
this pull request
May 22, 2024
Change-Id: I75915aedfe374d3aa4dc6aded5e0a45b43f0217d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5559885 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/12.4@{#39} Cr-Branched-From: 309640d-refs/heads/12.4.254@{#1} Cr-Branched-From: 5dc2470-refs/heads/main@{#92862}
hubot
pushed a commit
that referenced
this pull request
Jun 21, 2024
Change-Id: Ief85747e2b5f6e4b6f7e92f8464b4d2001f78fb9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5646589 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/12.6@{#39} Cr-Branched-From: 3c9fa12-refs/heads/12.6.228@{#2} Cr-Branched-From: 981bb15-refs/heads/main@{#93835}
hubot
pushed a commit
that referenced
this pull request
Aug 21, 2024
Change-Id: Idd4c095893c899af33feaf41c17627e2d30ed7d0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5800815 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/12.8@{#39} Cr-Branched-From: 70cbb39-refs/heads/12.8.374@{#1} Cr-Branched-From: 451b63e-refs/heads/main@{#95151}
hubot
pushed a commit
that referenced
this pull request
Aug 26, 2024
Change-Id: I7a6cad7c47409d7af8f5e0cbef753bebdad025be Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5813662 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/12.7@{#39} Cr-Branched-From: 35cc908-refs/heads/12.7.224@{#1} Cr-Branched-From: 6d60e67-refs/heads/main@{#94324}
hubot
pushed a commit
that referenced
this pull request
Sep 23, 2024
Move the initializer id before the computed property name ids. Bug: 363538434 (cherry picked from commit 8068f48) Merged: [parser] Fix parse errors in static computed class properties Otherwise we'll try to rewrite a FailureExpression (cherry picked from commit 3b1adc1) Bug: 366323452 Change-Id: I1c172effc29ab593545700d79a10cd2aecaa6112 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5877006 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/branch-heads/12.9@{#39} Cr-Branched-From: 64a21d7-refs/heads/12.9.202@{#1} Cr-Branched-From: da4200b-refs/heads/main@{#95679}
hubot
pushed a commit
that referenced
this pull request
Nov 26, 2024
`GetMemOp` returns an `Operand` which can contain `kScratchRegister`. We should hence not clobber that register until after the last use of the `Operand`. This CL changes the scratch register to `kScratchRegister2` which has much fewer uses, and in particular none which collides with `GetMemOp`. R=mliedtke@chromium.org Bug: 378779897 (cherry picked from commit 57a017e) Change-Id: I43a52d675064dbec8828cb00cb6dcf3287b9dbbf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6050018 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Matthias Liedtke <mliedtke@chromium.org> Cr-Commit-Position: refs/branch-heads/13.0@{#39} Cr-Branched-From: 4be854b-refs/heads/13.0.245@{#1} Cr-Branched-From: 1f5183f-refs/heads/main@{#96103}
hubot
pushed a commit
that referenced
this pull request
Dec 11, 2024
Version incremented at https://cr-buildbucket.appspot.com/build/8728857298770794705 Change-Id: I3d6364f83ff2843a222a2ccf6ddc76e294279e2e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6087976 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/13.2@{#39} Cr-Branched-From: 24068c5-refs/heads/13.2.152@{#1} Cr-Branched-From: 6054ba9-refs/heads/main@{#97085}
hubot
pushed a commit
that referenced
this pull request
Dec 16, 2024
Version incremented at https://cr-buildbucket.appspot.com/build/8728365243589440721 Change-Id: Icdf5a9d3fe584273dfb76d70517cfd39b22b6d03 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6096718 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/13.1@{#39} Cr-Branched-From: 7998da6-refs/heads/13.1.201@{#1} Cr-Branched-From: 5e9af2a-refs/heads/main@{#96554}
hubot
pushed a commit
that referenced
this pull request
Feb 6, 2025
Version incremented at https://cr-buildbucket.appspot.com/build/8723677040646328481 Change-Id: I030ddaba13b42797cb6706d58b7fb210d10ce313 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6236797 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/13.3@{#39} Cr-Branched-From: 41dacff-refs/heads/13.3.415@{#1} Cr-Branched-From: 3348638-refs/heads/main@{#97937}
hubot
pushed a commit
that referenced
this pull request
Mar 11, 2025
Merged: [loong64][turboshaft] Isel support EmitMoveParamToFPR Revision: 1dbffe0 Merged: [loong64][mips64] Support int f(double) builtins in simulators Revision: e4061e1 Merged: [mips64] Disable leaptiering Revision: aaefb87 R=vahl@chromium.org Bug: 399819897 Change-Id: I736f51e7a6e3a909bfe7c6b87bc553795a672365 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6311791 Commit-Queue: Lutz Vahl <vahl@chromium.org> Reviewed-by: Lutz Vahl <vahl@chromium.org> Cr-Commit-Position: refs/branch-heads/13.4@{#39} Cr-Branched-From: 0f87a54-refs/heads/13.4.114@{#1} Cr-Branched-From: 27af2e9-refs/heads/main@{#98459}
hubot
pushed a commit
that referenced
this pull request
Jun 26, 2025
This partial specialization can cause ODR violations if being used for types defined outside of V8 (like `std::pair`, `std::tuple` or integral types). As we cannot restrict it to V8 types, this CL removes it completely and explicitly uses `base::hash` where needed. R=ahaas@chromium.org Bug: 424006386, 427641862 (cherry picked from commit 65ce14d) Change-Id: If2638558e25ac682e0c83a7c0444c506036a9772 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6678672 Reviewed-by: Andreas Haas <ahaas@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Clemens Backes <clemensb@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/branch-heads/13.8@{#39} Cr-Branched-From: 61ddd47-refs/heads/13.8.258@{#1} Cr-Branched-From: fdb5de2-refs/heads/main@{#100480}
hubot
pushed a commit
that referenced
this pull request
Aug 18, 2025
Version incremented at https://cr-buildbucket.appspot.com/build/8706214663906239041 Change-Id: I9d301335332176f52572efafd79593ceb0ec1f94 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6857398 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/13.9@{#39} Cr-Branched-From: 76ea409-refs/heads/13.9.205@{#1} Cr-Branched-From: 2824212-refs/heads/main@{#100941}
hubot
pushed a commit
that referenced
this pull request
Nov 14, 2025
Bug: 460166688 (cherry picked from commit 8245592) Change-Id: I74580704ed59fa1b130d4cd524ba415240d2a0f5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7156416 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/branch-heads/14.2@{#39} Cr-Branched-From: 37f82db-refs/heads/14.2.231@{#1} Cr-Branched-From: d1a6089-refs/heads/main@{#102804}
hubot
pushed a commit
that referenced
this pull request
Jan 15, 2026
Version incremented at https://cr-buildbucket.appspot.com/build/8692603225444203169 Change-Id: If0f4eab26b144b99e358982c0bdac2a0c360980f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7485608 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/14.4@{#39} Cr-Branched-From: 80acc26-refs/heads/14.4.258@{#1} Cr-Branched-From: ce7e597-refs/heads/main@{#104020}
hubot
pushed a commit
that referenced
this pull request
Mar 10, 2026
…UserOf Bug: 488803413 (cherry picked from commit 23ec84a) Change-Id: I082bbd2947d85b3394fd438740401389bfade5e9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7650475 Reviewed-by: Raphael Herouart <rherouart@chromium.org> Auto-Submit: Darius Mercadier <dmercadier@chromium.org> Commit-Queue: Raphael Herouart <rherouart@chromium.org> Cr-Commit-Position: refs/branch-heads/14.6@{#39} Cr-Branched-From: e04c3a1-refs/heads/14.6.202@{#1} Cr-Branched-From: 3b0b01e-refs/heads/main@{#105132}
hubot
pushed a commit
that referenced
this pull request
Apr 16, 2026
Version incremented at https://cr-buildbucket.appspot.com/build/8684372669303914977 Change-Id: I8fcd4b8652c0290b81640d455cdaf7f00f204811 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7768549 Bot-Commit: v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/14.7@{#39} Cr-Branched-From: 723547b-refs/heads/14.7.173@{#1} Cr-Branched-From: 3fc49d4-refs/heads/main@{#105661}
hubot
pushed a commit
that referenced
this pull request
May 12, 2026
…isions) https://chromium.googlesource.com/external/github.com/WebKit/JetStream.git/+log/2145cedef4ca..91552391bf2f 2026-05-06 cbruni@chromium.org Fix wrong update-ui performance.mark and measure nesting 2026-03-26 cbruni@chromium.org Improve memory script 2026-03-19 cbruni@chromium.org Address comments for memory measurement script 2026-03-19 cbruni@chromium.org Add memory measurement script 2026-03-18 cbruni@chromium.org Actually fix --dump-test-list 2026-03-18 cbruni@chromium.org Fix --dump-test-list and --test in v3.0-custom 2026-03-17 cbruni@chromium.org Update v3.0-custom to latest v3.0 branch 2026-01-30 kmiller68@users.noreply.github.com Merge pull request #272 from danleh/JetStream3.0 2026-01-19 cbruni@chromium.org Reland: Improve Benchmark constructor and instance variables #255 (#263) 2026-01-19 cbruni@chromium.org Reland: Add resource loading bar (#264) 2026-01-19 danleh@users.noreply.github.com Merge pull request #261 from danleh/dotnet-mime-fix 2026-01-17 kmiller68@users.noreply.github.com Merge pull request #262 from kmiller68/revert-replace-prefetch-logic 2026-01-15 kmiller68@users.noreply.github.com Merge pull request #245 from kmiller68/add-open-governance-policy 2026-01-15 danleh@users.noreply.github.com Merge pull request #260 from danleh/readme-addendum 2026-01-14 danleh@users.noreply.github.com Merge pull request #258 from danleh/repo-readme 2026-01-14 cbruni@chromium.org Improve Benchmark constructor and instance variables (#255) 2026-01-14 kmiller68@users.noreply.github.com Merge pull request #254 from kmiller68/scatter-plot-should-increase-with-score 2026-01-14 danleh@users.noreply.github.com Merge pull request #257 from danleh/remove-unused-deps 2026-01-14 cbruni@chromium.org Fix dev server output (#252) 2026-01-14 danleh@users.noreply.github.com Merge pull request #256 from danleh/fix-npm-audit 2026-01-14 cbruni@chromium.org Add resource loading bar (#246) 2026-01-13 cbruni@chromium.org Replace prefetch logic (#251) 2026-01-06 kmiller68@users.noreply.github.com Merge pull request #249 from kmiller68/add-verbose-option-to-server 2026-01-06 camillobruni@users.noreply.github.com Add BrowserFileLoader (#242) 2025-12-18 camillobruni@users.noreply.github.com Add --force-gc support (#248) 2025-12-10 kmiller68@users.noreply.github.com Merge pull request #244 from kmiller68/nonStandard-error-rotate-back-to-red 2025-12-10 camillobruni@users.noreply.github.com fewer shell warnings (#234) 2025-11-13 kmiller68@users.noreply.github.com Merge pull request #238 from kmiller68/transformers-js-loads-resources-at-runtime 2025-11-13 ysuzuki@apple.com Merge pull request #239 from Constellation/mod-256 2025-11-12 kmiller68@users.noreply.github.com Merge pull request #225 from kmiller68/reduce-kotlin-iteration-count 2025-11-07 ysuzuki@apple.com Merge pull request #236 from Constellation/use-integer 2025-11-05 camillobruni@users.noreply.github.com sync-fs and async-fs improvements (#217) 2025-11-04 camillobruni@users.noreply.github.com More ubuntu tests (#235) 2025-11-04 kmiller68@users.noreply.github.com Merge pull request #188 from kmiller68/dotnet-legacy-exceptions 2025-10-30 camillobruni@users.noreply.github.com Github Workflow: split tests (#227) 2025-10-30 camillobruni@users.noreply.github.com Enable mobx-startup (#233) 2025-10-30 camillobruni@users.noreply.github.com More top-level cleanup (#229) 2025-10-30 camillobruni@users.noreply.github.com Improve preload code (#230) 2025-10-30 kmiller68@users.noreply.github.com Merge pull request #226 from kmiller68/console-warn-and-error-stderr-clis 2025-10-30 camillobruni@users.noreply.github.com Fix npm run test:build (#232) 2025-10-30 kmiller68@users.noreply.github.com Merge pull request #212 from kmiller68/disable-whisper-wasm 2025-10-29 camillobruni@users.noreply.github.com New Workload: Babylon class-heavy workload (#143) 2025-10-29 camillobruni@users.noreply.github.com Avoid new Date and improve filename extraction in doxbee benchmarks (#231) 2025-10-28 camillobruni@users.noreply.github.com New Workload: mobx observer + startup (#151) 2025-10-28 camillobruni@users.noreply.github.com StartupBenchmark refactoring (#218) 2025-10-27 camillobruni@users.noreply.github.com Add post-quit sleep for Safari (#220) 2025-10-27 kmiller68@users.noreply.github.com Enable jsdom-d3-startup by default. (#223) 2025-10-27 camillobruni@users.noreply.github.com More consistent LICENSE.txt files (#221) 2025-10-27 camillobruni@users.noreply.github.com Move more code to utils (#219) 2025-10-23 camillobruni@users.noreply.github.com Add npm run test:build script (#189) 2025-10-23 kmiller68@users.noreply.github.com Merge pull request #216 from kmiller68/total-to-overall-summary 2025-10-23 camillobruni@users.noreply.github.com render non default params (#197) 2025-10-23 camillobruni@users.noreply.github.com New Workload: JSDOM + d3 (#124) 2025-10-22 camillobruni@users.noreply.github.com Update test.yml (#190) 2025-10-22 camillobruni@users.noreply.github.com Await driver.quit (#209) 2025-10-22 camillobruni@users.noreply.github.com Add explicit version checks (#211) 2025-10-22 camillobruni@users.noreply.github.com Improve iterationCount and worstCaseCount params parsing (#215) 2025-10-22 camillobruni@users.noreply.github.com More consistent total score printing (#213) 2025-10-22 camillobruni@users.noreply.github.com Do not trigger logo animations again after loading all resources (#214) 2025-10-22 camillobruni@users.noreply.github.com support startAutomatically (#201) 2025-10-22 camillobruni@users.noreply.github.com Conditionally show more metric details (#167) 2025-10-22 camillobruni@users.noreply.github.com fix gaussian-blur input data (#207) 2025-10-22 camillobruni@users.noreply.github.com Improve tags (#206) 2025-10-22 camillobruni@users.noreply.github.com update selenium-webdriver version (#208) 2025-10-21 camillobruni@users.noreply.github.com Auto decompress files as part of test running (#195) 2025-10-17 camillobruni@users.noreply.github.com Support multiple comma separate tests in URL params (#198) 2025-10-15 danleh@users.noreply.github.com Merge pull request #77 from Constellation/base64 2025-10-15 camillobruni@users.noreply.github.com Fix prismjs sample file name(#202) 2025-10-08 camillobruni@users.noreply.github.com Add prettier config (#176) 2025-10-07 kmiller68@users.noreply.github.com Merge pull request #170 from eqrion/zlib-compress 2025-10-03 kmiller68@users.noreply.github.com Merge pull request #194 from victorvianna/main 2025-10-03 ysuzuki@apple.com Change shouldReport to report back 2025-10-03 camillobruni@users.noreply.github.com Compact display for non-default params (#191) 2025-10-01 camillobruni@users.noreply.github.com Add group-details parameter to conditionally display grouped benchmarks (#157) 2025-10-01 camillobruni@users.noreply.github.com New Workload: prismjs source code highlighting (#149) 2025-10-01 camillobruni@users.noreply.github.com New Workload: validatorjs regexp heavy workload (#147) 2025-09-23 ysuzuki@apple.com Merge pull request #192 from Constellation/dump-test-list 2025-09-22 camillobruni@users.noreply.github.com New Workload: TypeScript standalone (#117) 2025-09-19 kmiller68@users.noreply.github.com Merge pull request #187 from kmiller68/fix-web-ssr-for-options-bag 2025-09-17 keith_miller@apple.com Test is causing jetsams on iOS. Disabling for now while I investigate. 2025-09-17 camillobruni@users.noreply.github.com Add JetStreamParams (#171) 2025-09-17 camillobruni@users.noreply.github.com New Workload: React Server Side Rendering Startup (#116) 2025-09-17 danleh@users.noreply.github.com Merge pull request #130 from danleh/j2cl-box2d 2025-09-16 danleh@users.noreply.github.com Merge pull request #182 from danleh/recompile-dotnet 2025-09-16 danleh@users.noreply.github.com Merge pull request #148 from danleh/transformersjs-rebase 2025-09-11 camillobruni@users.noreply.github.com Experimental Workload: Intl (#146) 2025-09-10 danleh@users.noreply.github.com Merge pull request #178 from danleh/disable-gcc-loops-quicksort 2025-09-08 kmiller68@users.noreply.github.com Merge pull request #168 from kmiller68/reduce-dotnet-runtime 2025-09-03 camillobruni@users.noreply.github.com More consistent metric reporting (#175) 2025-09-03 camillobruni@users.noreply.github.com Minor browser test improvements (#177) 2025-09-03 danleh@users.noreply.github.com Merge pull request #173 from danleh/text-decoder-polyfill-move 2025-09-03 camillobruni@users.noreply.github.com Remove unused scripts (#174) 2025-09-02 danleh@users.noreply.github.com Merge pull request #172 from danleh/compress-js 2025-09-01 camillobruni@users.noreply.github.com Update/rewrite web-tooling-benchmark (#153) 2025-09-01 camillobruni@users.noreply.github.com Support custom benchmark arguments (#165) 2025-09-01 camillobruni@users.noreply.github.com Status update and CSS fixes (#169) 2025-08-27 camillobruni@users.noreply.github.com Use event.key instead of event.which #166 2025-08-27 danleh@users.noreply.github.com Merge pull request #144 from danleh/logo-text-to-path 2025-08-26 camillobruni@users.noreply.github.com StartupBenchmark: add better assertion failures (#164) 2025-08-26 camillobruni@users.noreply.github.com Add UTF16 sources test (#162) 2025-08-26 camillobruni@users.noreply.github.com Convert startup-helper/BabelCacheBuster.js to esm (#163) 2025-08-26 camillobruni@users.noreply.github.com Add startup benchmark helper (#158) 2025-08-20 danleh@users.noreply.github.com Merge pull request #159 from danleh/dotnet-wasm-rename 2025-08-15 camillobruni@users.noreply.github.com Expose JetStream global to workloads (#139) 2025-08-15 ysuzuki@apple.com Merge pull request #145 from Constellation/tfjs 2025-08-14 camillobruni@users.noreply.github.com Only expose a console copy in the realm (#137) 2025-08-14 kmiller68@users.noreply.github.com Merge pull request #133 from kmiller68/add-grouped-benchmark-for-sunspider 2025-08-14 danleh@users.noreply.github.com Merge pull request #142 from danleh/Dart-remove-unused-runner 2025-08-14 danleh@users.noreply.github.com Merge pull request #140 from danleh/disable-HashSet-wasm 2025-08-14 camillobruni@users.noreply.github.com merge async-fs code (#135) 2025-08-14 camillobruni@users.noreply.github.com Enable UniPoker validation by default (#141) 2025-08-14 danleh@users.noreply.github.com Merge pull request #138 from danleh/kotlin-fix-isD8-access 2025-08-14 camillobruni@users.noreply.github.com Bump selenium-webdriver version (#136) 2025-08-14 danleh@users.noreply.github.com Merge pull request #97 from eqrion/dart-todomvc 2025-08-14 camillobruni@users.noreply.github.com Improve console (#131) 2025-08-14 camillobruni@users.noreply.github.com Improve runner code (#134) 2025-08-14 camillobruni@users.noreply.github.com Rename worst4 to just worst (#129) 2025-08-13 ysuzuki@apple.com Merge pull request #127 from Constellation/list 2025-08-13 danleh@users.noreply.github.com Merge pull request #84 from danleh/kotlin 2025-08-12 camillobruni@users.noreply.github.com CSS fixes for info button (#126) 2025-08-12 camillobruni@users.noreply.github.com Add info-button (#123) 2025-08-11 ysuzuki@apple.com Merge pull request #119 from Constellation/set-status 2025-08-11 camillobruni@users.noreply.github.com Display workload scatterplots (#120) 2025-08-11 camillobruni@users.noreply.github.com Update .gitignore (#121) 2025-08-07 kmiller68@users.noreply.github.com Merge pull request #115 from kmiller68/fix-bencharks-by-tag-testlist 2025-08-06 camillobruni@users.noreply.github.com Configurable resource prefetching (#70) 2025-08-06 camillobruni@users.noreply.github.com github workflow: keep running all tests even if there are failures (#114) 2025-08-05 camillobruni@users.noreply.github.com Add Scripts helper classes (#109) 2025-08-05 iireland@mozilla.com Add three.js benchmark (#75) 2025-08-04 camillobruni@users.noreply.github.com Add validate method for async-fs and sync-fs (#111) 2025-08-04 camillobruni@users.noreply.github.com Add more performance.measure (#110) 2025-07-31 camillobruni@users.noreply.github.com Remove LuaJSFight micro benchmarks (#104) 2025-07-31 camillobruni@users.noreply.github.com Add cli flags (#101) 2025-07-31 camillobruni@users.noreply.github.com Cleanup performance.now shimming (#108) 2025-07-30 camillobruni@users.noreply.github.com Formatting (#105) 2025-07-30 camillobruni@users.noreply.github.com Run all disabled workloads in tests (#103) 2025-07-30 camillobruni@users.noreply.github.com Add benchmarks argument to Driver (#98) 2025-07-29 kmiller68@users.noreply.github.com Merge pull request #102 from kmiller68/reenable-dotnet-tests 2025-07-29 camillobruni@users.noreply.github.com Simplify updateUIAfterRun (#99) 2025-07-29 camillobruni@users.noreply.github.com Merge customTestList and testList (#100) 2025-07-29 camillobruni@users.noreply.github.com Use tags for workload selection (#82) 2025-07-23 danleh@users.noreply.github.com Merge pull request #93 from danleh/cleanup-loadInternal 2025-07-23 kmiller68@users.noreply.github.com Merge pull request #73 from maraf/DotnetWasm 2025-07-21 camillobruni@users.noreply.github.com Fix typo in headers fetch request (#80) 2025-07-15 camillobruni@users.noreply.github.com use default performance.measure implementation (#83) 2025-07-15 camillobruni@users.noreply.github.com Use subScores directly for the UI (#81) 2025-07-15 camillobruni@users.noreply.github.com Add basic unittests (#94) 2025-07-14 camillobruni@users.noreply.github.com Fix accidental loading status clipping in wide windows (#85) 2025-07-14 camillobruni@users.noreply.github.com Simplify formatting (#79) 2025-07-12 kmiller68@users.noreply.github.com Merge pull request #90 from kmiller68/fix-prepareForNextIteration-async-benchmark 2025-07-10 kmiller68@users.noreply.github.com Merge pull request #74 from kmiller68/preload-blobs-wasm 2025-07-08 kmiller68@users.noreply.github.com Merge pull request #76 from kmiller68/zlib-check-_compressFile-to-setupModule 2025-07-02 ysuzuki@apple.com Revert #78 as it broke JetStream3 on web page 2025-07-02 camillobruni@users.noreply.github.com Remove custom run methods #78 2025-06-04 yusukesuzuki@slowstart.org Merge pull request #72 from Constellation/new-string 2025-05-13 kmiller68@users.noreply.github.com Merge pull request #71 from kmiller68/disable-extra-bigint-tests 2025-05-13 camillobruni@users.noreply.github.com Merge pull request #65: OfflineAssembler: Avoid accidental toString operation 2025-05-13 camillobruni@users.noreply.github.com Merge pull request #64: WSL: Add performance.mark 2025-05-13 camillobruni@users.noreply.github.com Merge pull request #60: date-format: Add result hashing to prevent DCE 2025-05-13 camillobruni@users.noreply.github.com Merge pull request #62: Avoid eval in date-format-tofte 2025-05-05 kmiller68@users.noreply.github.com Merge pull request #53 from mkustermann/js-strings 2025-04-24 camillobruni@users.noreply.github.com Merge pull request #67 from issackjohn/issack/add-edge 2025-04-24 camillobruni@users.noreply.github.com Merge pull request #61 from camillobruni/2025-03-26_gbemu_hash 2025-04-07 kmiller68@users.noreply.github.com Merge pull request #59 from camillobruni/2025-03-26_cli_error_handling 2025-04-07 kmiller68@users.noreply.github.com Merge pull request #42 from camillobruni/2025-01-28_cli_tests 2025-04-07 kmiller68@users.noreply.github.com Merge pull request #41 from camillobruni/2025-01-28_runner_log 2025-04-07 kmiller68@users.noreply.github.com Merge pull request #14 from camillobruni/2024-11-26_tags 2025-03-12 kmiller68@users.noreply.github.com Merge pull request #57 from kmiller68/module-url-fix-v2 2025-02-27 kmiller68@users.noreply.github.com Merge pull request #51 from danleh/main 2025-02-27 kmiller68@users.noreply.github.com Merge pull request #52 from kmiller68/pathname-browser-dart 2025-02-26 kmiller68@users.noreply.github.com Merge pull request #33 from danleh/dart-flute-wasm-squash 2025-02-26 kmiller68@users.noreply.github.com Merge pull request #47 from kmiller68/argon2-to-js-scoring-v2 2025-02-26 kmiller68@users.noreply.github.com Merge pull request #40 from danleh/8bitbench-wasm-scoring 2025-02-12 kmiller68@users.noreply.github.com Merge pull request #43 from danleh/zlib-wasm 2025-02-10 kmiller68@users.noreply.github.com Merge pull request #45 from danleh/richards-workload-size-as-input 2025-02-07 kmiller68@users.noreply.github.com Merge pull request #44 from danleh/wasm-workload-sizes 2025-01-28 kmiller68@users.noreply.github.com Merge pull request #39 from camillobruni/2025-01-28_test_runner_fix 2025-01-27 kmiller68@users.noreply.github.com Merge pull request #35 from danleh/hashset-wasm-scoring 2025-01-27 kmiller68@users.noreply.github.com Merge pull request #30 from danleh/sqlite-scoring 2025-01-27 kmiller68@users.noreply.github.com Merge pull request #28 from danleh/quicksort-wasm-scoring 2025-01-27 kmiller68@users.noreply.github.com Merge pull request #37 from WebKit/remove-octane-zlib 2025-01-24 keith_miller@apple.com Revert "Remove Octane-zlib." 2025-01-24 keith_miller@apple.com Remove Octane-zlib. 2025-01-24 kmiller68@users.noreply.github.com Merge pull request #13 from camillobruni/2024-11-22_driver_prep 2025-01-24 kmiller68@users.noreply.github.com Merge pull request #11 from camillobruni/2024-11-26_github_actions 2025-01-23 kmiller68@users.noreply.github.com Merge pull request #27 from danleh/richards-js-scoring 2025-01-22 kmiller68@users.noreply.github.com Merge pull request #34 from WebKit/fix-report-JSON 2025-01-22 kmiller68@users.noreply.github.com Merge pull request #32 from danleh/performance-mark-measure 2025-01-21 kmiller68@users.noreply.github.com Merge pull request #31 from WebKit/revert-tfjs-to-js-scoring 2025-01-21 kmiller68@users.noreply.github.com Merge pull request #16 from camillobruni/2024-11-26_ms 2025-01-21 kmiller68@users.noreply.github.com Merge pull request #26 from danleh/gcc-loops-js-scoring 2025-01-16 kmiller68@users.noreply.github.com Merge pull request #23 from WebKit/tfjs-to-js-scoring 2025-01-16 kmiller68@users.noreply.github.com Merge pull request #17 from camillobruni/2024-11-26_safe_add 2025-01-16 kmiller68@users.noreply.github.com Merge pull request #25 from danleh/spidermonkey-cli-fix 2025-01-08 kmiller68@users.noreply.github.com Merge pull request #21 from WebKit/remove-float-mm-c 2024-12-21 kmiller68@users.noreply.github.com Merge pull request #18 from WebKit/wasm-benchmarks-should-be-scored-like-js-benchmarks 2024-12-20 kmiller68@users.noreply.github.com Merge pull request #2 from danleh/sqlite-wasm 2024-12-09 kmiller68@users.noreply.github.com Merge pull request #5 from camillobruni/2024-11-22_runner_improvements 2024-12-09 kmiller68@users.noreply.github.com Merge pull request #8 from camillobruni/2024-11-22_regexp 2024-12-09 kmiller68@users.noreply.github.com Merge pull request #19 from camillobruni/2024-11-27_async_fs 2024-11-26 kmiller68@users.noreply.github.com Merge pull request #7 from camillobruni/2024-11-22_driver_vars 2024-11-25 kmiller68@users.noreply.github.com Merge pull request #4 from camillobruni/2024-11-22_3dcube_fix 2024-11-25 kmiller68@users.noreply.github.com Merge pull request #6 from camillobruni/2024-11-22_gitignore 2024-11-13 kmiller68@users.noreply.github.com Merge pull request #1 from danleh/main 2024-10-30 keith_miller@apple.com Initial copy from WebKit/PerformanceTests/JetStream3 2024-10-30 kmiller68@users.noreply.github.com Initial commit If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/jetstream-v3-0-custom-v8 Please CC mliedtke@google.com,nicohartmann@google.com,v8-waterfall-gardeners@google.com on the revert to ensure that a human is aware of the problem. To file a bug in JetStream v3.0-custom: https://issues.chromium.org/u/1/issues/new?component=1741045&pli=1&template=0 To file a bug in V8: https://issues.chromium.org/u/1/issues/new?component=1456824&pli=1&template=2109136 To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: mliedtke@google.com,nicohartmann@google.com Change-Id: Ic53c7e030a05111ba56e03ab158282762aa17360 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7823185 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Bot-Commit: chromium-autoroll@skia-public.iam.gserviceaccount.com <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#107273}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug where the lock guard (for concurrently accessing
the same scope from different threads) had basically no effect, due to
being bound to a temporary only.