Rv li 2#43
Closed
DrRezaYazdani1 wants to merge 434 commits into
Closed
Conversation
…n-test-macro-assembler-cc' into 'riscv-porting-dev' Resolve "Add test cases for `ReverseByte32` and `ReverseByte64` in `test-macro-assembler.cc`" Closes riscv-collab#57 See merge request swlab/swe/v8!59
Resolve "ERROR: mfhc1 generated" Closes riscv-collab#42 See merge request swlab/swe/v8!60
In many places, uses of `v0` were previously set to ue `t0`, but we need to use `a0`, as that is where the return value is placed.
The simulator can now insert and handle `ecall` instructions to trigger external calls.
This was caused by the MIPS64 using `s0` as a temp, but in RISC-V, `s0` is `fp`, so there were various places where the frame pointer was accidentally over-written.
…reachable' into 'riscv-porting-dev' Remove remaining MIPS instructions that are marked as `UNREACHABLE()` Closes riscv-collab#68 See merge request swlab/swe/v8!61
Since `a0` already has the return value, we don't need a move to use it as the first parameter.
External funcs Closes riscv-collab#62 See merge request swlab/swe/v8!62
FSGN instructions are essentially bit-manipulation, so it does not need Canonicalization for the inputs/result
Since kScatchReg is used in code-gen, liftoff-assembler, and reg-exp-assembler that in turn invokes macro-assembler APIs, direct use of kscratchReg inside macro-assembler may cause conflict. In this bug, liftoff-assembler used kScratchReg then invokes JumpIfEqual which again write to kScratchReg while it is still live.
Previous implementation uses `Move_s` even when inputs are doubles
…' into 'riscv-porting-dev' Resolve "Verification failure: RunWasmLiftoff_Float32Neg fails" Closes riscv-collab#72 See merge request swlab/swe/v8!65
This fixes two places where the `auipc` instruction is used to calculate a PC offset. Fixes riscv-collab#59
…porting-dev' Fix incorrect address calculations from PC offsets Closes riscv-collab#59 See merge request swlab/swe/v8!66
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I86c26fca5c29c36e4837c6efc14a47ba549bbcfa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3233917 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/9.5@{v8#43} Cr-Branched-From: 4a03d61-refs/heads/9.5.172@{#1} Cr-Branched-From: 9a60704-refs/heads/main@{#76741}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I317f70305a4bf6efc5a462458f73ddb7a3835813 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2506495 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/8.6@{v8#43} Cr-Branched-From: a64aed2-refs/heads/8.6.395@{#1} Cr-Branched-From: a626bc0-refs/heads/master@{#69472}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
Merged: [const-tracking] Mark const field as mutable when reconfiguring Revision: 7535b91 Merged: [const-tracking] Fix incorrect DCHECK in MapUpdater Revision: f95db89 BUG=chromium:1161847,chromium:1185463,v8:9233 NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=ishell@chromium.org (cherry picked from commit 5651802) Change-Id: I7f46a701646e1dd67a049b2aa4ac32d05b6885f3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2748079 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Original-Commit-Position: refs/branch-heads/8.9@{v8#43} Cr-Original-Branched-From: 16b9bbb-refs/heads/8.9.255@{#1} Cr-Original-Branched-From: d16a2a6-refs/heads/master@{#72039} Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2794428 Reviewed-by: Victor-Gabriel Savu <vsavu@google.com> Commit-Queue: Artem Sumaneev <asumaneev@google.com> Cr-Commit-Position: refs/branch-heads/8.6@{v8#73} Cr-Branched-From: a64aed2-refs/heads/8.6.395@{#1} Cr-Branched-From: a626bc0-refs/heads/master@{#69472}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
Change-Id: I1e76b68704a71e9d386085fd9872cb60a1321ef9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3338321 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/9.6@{v8#43} Cr-Branched-From: 0b7bda0-refs/heads/9.6.180@{#1} Cr-Branched-From: 41a5a24-refs/heads/main@{#77244}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
Revision: 798fbcb BUG=chromium:1198705 NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true TBR=nicohartmann@chromium.org Change-Id: Ifc210e7932f43088e858f6bdac6d9bcdec6e63f5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2844654 Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/branch-heads/9.0@{v8#43} Cr-Branched-From: bd0108b-refs/heads/9.0.257@{#1} Cr-Branched-From: 349bcc6-refs/heads/master@{#73001}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
Change-Id: I5c466d94ba2d6df1f8b72fff8adf610eb3e9aa80 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3405614 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/9.7@{v8#43} Cr-Branched-From: 49162da-refs/heads/9.7.106@{#1} Cr-Branched-From: a7e9b8f-refs/heads/main@{#77674}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
The value of a node was accessed without prior HasValue check. With WebAssembly this node is not guaranteed to be a value. Bug: chromium:1147206 R=mslekova@chromium.org NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true (cherry picked from commit 633f67c) Change-Id: I62170183f3940a04b0550dfbb78cb49d2f5d7f72 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2504250 Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#70833} Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2527090 Cr-Commit-Position: refs/branch-heads/8.7@{v8#43} Cr-Branched-From: 0d81cd7-refs/heads/8.7.220@{#1} Cr-Branched-From: 942c2ef-refs/heads/master@{#70196}
patrik-lengweiler
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
May 31, 2023
Due to mismatch in strictness we otherwise invalidly mark scopes as calling sloppy eval. (cherry picked from commit 27fa951) Bug: chromium:1394403 No-Try: true No-Presubmit: true No-Tree-Checks: true Change-Id: Iece45df87f171616a2917c2aba5540636880a7c6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4066044 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#84575} Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4068122 Commit-Queue: Roger Felipe Zanoni da Silva <rzanoni@google.com> Reviewed-by: Artem Sumaneev <asumaneev@google.com> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/branch-heads/10.2@{v8#43} Cr-Branched-From: 374091f-refs/heads/10.2.154@{#1} Cr-Branched-From: f0c353f-refs/heads/main@{#79976}
patrik-lengweiler
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
May 31, 2023
Bug: chromium:1439691 (cherry picked from commit 2c8a019) Change-Id: Ia418ae04bf4352e3618700c55ecd37447023e6eb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4503810 Reviewed-by: Jakob Linke <jgruber@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/branch-heads/11.2@{v8#43} Cr-Branched-From: 755511a-refs/heads/11.2.214@{#1} Cr-Branched-From: e6b1cce-refs/heads/main@{#86014}
patrik-lengweiler
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
May 31, 2023
chromium removed the config in https://crrev.com/c/3755181. (cherry picked from commit 2eaf21e) Bug: b:255447284 Change-Id: I54a50e7035de8f7db96ab81ded74d9c63bcbecdd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3977074 Reviewed-by: Michael Achenbach <machenbach@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#83897} Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3981118 Cr-Commit-Position: refs/branch-heads/10.6@{v8#43} Cr-Branched-From: 41bc743-refs/heads/10.6.194@{#1} Cr-Branched-From: d5f29b9-refs/heads/main@{#82548}
patrik-lengweiler
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
May 31, 2023
Change-Id: I9959ca7f1aba9e51f5f3179a079a120882bdc160 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4086503 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/10.8@{v8#43} Cr-Branched-From: f1bc03f-refs/heads/10.8.168@{#1} Cr-Branched-From: 237de89-refs/heads/main@{#83672}
patrik-lengweiler
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
May 31, 2023
Revision: 3ec02e3 BUG=chromium:1359294,v8:12578 NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=mlippautz@chromium.org Change-Id: I04093833a1bfef4269eb578fa5a002872015199e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3882977 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/branch-heads/10.4@{v8#43} Cr-Branched-From: b1413ed-refs/heads/10.4.132@{#1} Cr-Branched-From: 9d0a093-refs/heads/main@{#80972}
patrik-lengweiler
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
May 31, 2023
Change-Id: I87bf47e7b1c92aed20ac975261322a722386e0c0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4009245 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/10.7@{v8#43} Cr-Branched-From: 4d2145c-refs/heads/10.7.193@{#1} Cr-Branched-From: 9521696-refs/heads/main@{#83201}
patrik-lengweiler
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
Jun 10, 2023
Merged: [runtime] Create unoptimized data even if compilation is aborted Revision: 0e07abe Merged: [class] Export SharedFunctionInfo::CreateAndSetUncompiledData Revision: 1b55293 BUG=chromium:1441254 NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=verwaest@chromium.org Change-Id: I39c4ab864776a9138d07c3c1dccd3a2be4acfe7c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4604769 Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/branch-heads/11.4@{v8#43} Cr-Branched-From: 8a8a1e7-refs/heads/11.4.183@{#1} Cr-Branched-From: 5483d8e-refs/heads/main@{#87241}
reposynch Bot
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
Aug 6, 2023
Fixed: v8:14197 Bug: v8:7700 (cherry picked from commit 3462172) Change-Id: Iaeb009e55fc6c9b5b038aaaa87235558b27f9e14 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4727936 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/branch-heads/11.5@{v8#43} Cr-Branched-From: 0c4044b-refs/heads/11.5.150@{#1} Cr-Branched-From: b71d303-refs/heads/main@{#87781}
reposynch Bot
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
Jan 14, 2024
Bug: v8:7700 Fixed: chromium:1515930 (cherry picked from commit 78dd4b3) Change-Id: I64561e7ee71405e6eceeb2132b953ff0806e3a7b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5185347 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/branch-heads/12.1@{v8#43} Cr-Branched-From: b74ef6f-refs/heads/12.1.285@{#1} Cr-Branched-From: 32857fb-refs/heads/main@{#91313}
hubot
pushed a commit
that referenced
this pull request
Mar 8, 2024
Change-Id: I73cf80443287175da8cae3d43cf340d30fc59b9f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5356195 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/12.2@{#43} Cr-Branched-From: 6eb5a96-refs/heads/12.2.281@{#1} Cr-Branched-From: 44cf56d-refs/heads/main@{#91934}
hubot
pushed a commit
that referenced
this pull request
Apr 9, 2024
Change-Id: Icda88a094b2290211b67e3e1bfcf50178416a5ff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5440217 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/12.0@{#43} Cr-Branched-From: ed7b4ca-refs/heads/12.0.267@{#1} Cr-Branched-From: 210e75b-refs/heads/main@{#90651}
hubot
pushed a commit
that referenced
this pull request
Jun 26, 2024
Change-Id: I75a8b6df45ae15a7a31361e9f0d5502503dc4b53 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5658957 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/12.6@{#43} Cr-Branched-From: 3c9fa12-refs/heads/12.6.228@{#2} Cr-Branched-From: 981bb15-refs/heads/main@{#93835}
hubot
pushed a commit
that referenced
this pull request
Aug 23, 2024
Change-Id: I11c0c6d8e9b412a5f674ed8b2c057314c172414a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5804198 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/12.8@{#43} Cr-Branched-From: 70cbb39-refs/heads/12.8.374@{#1} Cr-Branched-From: 451b63e-refs/heads/main@{#95151}
hubot
pushed a commit
that referenced
this pull request
Sep 23, 2024
This reverts commit a44a16f. (cherry picked from commit 6cdc1db) Bug: 367758074 Change-Id: Iac12a082d2eb17c723f2328d607bbc61d995e3ed Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5883296 Auto-Submit: Adam Klein <adamk@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/12.9@{#43} Cr-Branched-From: 64a21d7-refs/heads/12.9.202@{#1} Cr-Branched-From: da4200b-refs/heads/main@{#95679}
hubot
pushed a commit
that referenced
this pull request
Dec 16, 2024
The Object.assign fastcase should not override the hash of the to object. Bug: 383647255 (cherry picked from commit 357d0dd) Change-Id: I2bbf10614d7997a396800cef33144875309010d9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6097572 Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/branch-heads/13.0@{#43} Cr-Branched-From: 4be854b-refs/heads/13.0.245@{#1} Cr-Branched-From: 1f5183f-refs/heads/main@{#96103}
hubot
pushed a commit
that referenced
this pull request
Dec 16, 2024
Version incremented at https://cr-buildbucket.appspot.com/build/8728365434245330865 Change-Id: I55e33f5c9878913f0c083735bc8f0940812b6756 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6097759 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/13.2@{#43} Cr-Branched-From: 24068c5-refs/heads/13.2.152@{#1} Cr-Branched-From: 6054ba9-refs/heads/main@{#97085}
hubot
pushed a commit
that referenced
this pull request
Jan 6, 2025
Version incremented at https://cr-buildbucket.appspot.com/build/8726487245867387921 Change-Id: Idd704437aae0e5a4631a246600d3373dc787232d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6148828 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/13.1@{#43} Cr-Branched-From: 7998da6-refs/heads/13.1.201@{#1} Cr-Branched-From: 5e9af2a-refs/heads/main@{#96554}
hubot
pushed a commit
that referenced
this pull request
Feb 14, 2025
Version incremented at https://cr-buildbucket.appspot.com/build/8722948490140372497 Change-Id: I8fb9a3d068f94f66a5e9040b8d1f77f6d7a8f213 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6269957 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/13.3@{#43} Cr-Branched-From: 41dacff-refs/heads/13.3.415@{#1} Cr-Branched-From: 3348638-refs/heads/main@{#97937}
hubot
pushed a commit
that referenced
this pull request
Jun 27, 2025
Fixed: 420356925 (cherry picked from commit 957b311) Change-Id: I52296105c945be205b036ff248951a0dedb0031c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6683183 Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by: Carl Smith <cffsmith@chromium.org> Cr-Commit-Position: refs/branch-heads/13.8@{#43} Cr-Branched-From: 61ddd47-refs/heads/13.8.258@{#1} Cr-Branched-From: fdb5de2-refs/heads/main@{#100480}
hubot
pushed a commit
that referenced
this pull request
Dec 12, 2025
Bug: 466786677 (cherry picked from commit e0052e7) Change-Id: Ie8667cbb0b6426eec7ac193efb1f23a1b8f95714 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7252673 Reviewed-by: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Darius Mercadier <dmercadier@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/branch-heads/14.2@{#43} Cr-Branched-From: 37f82db-refs/heads/14.2.231@{#1} Cr-Branched-From: d1a6089-refs/heads/main@{#102804}
hubot
pushed a commit
that referenced
this pull request
Jan 15, 2026
Version incremented at https://cr-buildbucket.appspot.com/build/8692584349818240497 Change-Id: If83ccc35ff0120cd8b63d4ed5194f2ae1143b611 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7486109 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/14.4@{#43} Cr-Branched-From: 80acc26-refs/heads/14.4.258@{#1} Cr-Branched-From: ce7e597-refs/heads/main@{#104020}
hubot
pushed a commit
that referenced
this pull request
Mar 13, 2026
…eEqualsInt32" NOTE THAT THIS IS NOT A CLEAN CHERRY-PICK: RecordSmiUse didn't exist in M146 so I manually inlined it in the cherry-pick. This is a reland of commit 0fff08a This reland just fixes the -2.js test on non-pointer-compression builds, where there is no such thing as a non-smi int32. Original change's description: > [maglev] Stop eliding Smi checks because of CheckValueEqualsInt32 > > If a Phi goes through a CheckValueEqualsInt32 then we record a > constant int32 alternative for this Phi. > > If the Phi is then the input to a BuildCheckSmi, we'll update the KNA > to record that this Phi is a Smi but won't insert a Smi check if the > int32 constant alternative is in range. Notably, this doesn't call > UseRequiresSmi, which means that when materializing this Phi, we won't > really know that it needs to be a Smi rather than a HeapObject. > > Where is goes wrong is if this phi has a use that requires it to be > materialized to HeapObject (this isn't easy to construct, cf the -2.js > repro in this CL: I used a secondary Phi to trigger this), then we'll > always materialize it as a HeapObject and never as a Smi, which can > be wrong if we store it in a Smi field. > > Fixed: 490558172 > Change-Id: Idcc7077187a3e952f7d3eb42150525d33cefe430 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7653635 > Auto-Submit: Darius Mercadier <dmercadier@chromium.org> > Reviewed-by: Victor Gomes <victorgomes@chromium.org> > Commit-Queue: Victor Gomes <victorgomes@chromium.org> > Cr-Commit-Position: refs/heads/main@{#105717} (cherry picked from commit 509d135) Bug: 490558172 Change-Id: I48e71a636968322808a4b9422e5cc52577abaab0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7661945 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Auto-Submit: Darius Mercadier <dmercadier@chromium.org> Reviewed-by: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/branch-heads/14.6@{#43} Cr-Branched-From: e04c3a1-refs/heads/14.6.202@{#1} Cr-Branched-From: 3b0b01e-refs/heads/main@{#105132}
hubot
pushed a commit
that referenced
this pull request
May 12, 2026
…isions) https://chromium.googlesource.com/external/github.com/WebKit/JetStream.git/+log/2145cedef4ca..91552391bf2f 2026-05-06 cbruni@chromium.org Fix wrong update-ui performance.mark and measure nesting 2026-03-26 cbruni@chromium.org Improve memory script 2026-03-19 cbruni@chromium.org Address comments for memory measurement script 2026-03-19 cbruni@chromium.org Add memory measurement script 2026-03-18 cbruni@chromium.org Actually fix --dump-test-list 2026-03-18 cbruni@chromium.org Fix --dump-test-list and --test in v3.0-custom 2026-03-17 cbruni@chromium.org Update v3.0-custom to latest v3.0 branch 2026-01-30 kmiller68@users.noreply.github.com Merge pull request #272 from danleh/JetStream3.0 2026-01-19 cbruni@chromium.org Reland: Improve Benchmark constructor and instance variables #255 (#263) 2026-01-19 cbruni@chromium.org Reland: Add resource loading bar (#264) 2026-01-19 danleh@users.noreply.github.com Merge pull request #261 from danleh/dotnet-mime-fix 2026-01-17 kmiller68@users.noreply.github.com Merge pull request #262 from kmiller68/revert-replace-prefetch-logic 2026-01-15 kmiller68@users.noreply.github.com Merge pull request #245 from kmiller68/add-open-governance-policy 2026-01-15 danleh@users.noreply.github.com Merge pull request #260 from danleh/readme-addendum 2026-01-14 danleh@users.noreply.github.com Merge pull request #258 from danleh/repo-readme 2026-01-14 cbruni@chromium.org Improve Benchmark constructor and instance variables (#255) 2026-01-14 kmiller68@users.noreply.github.com Merge pull request #254 from kmiller68/scatter-plot-should-increase-with-score 2026-01-14 danleh@users.noreply.github.com Merge pull request #257 from danleh/remove-unused-deps 2026-01-14 cbruni@chromium.org Fix dev server output (#252) 2026-01-14 danleh@users.noreply.github.com Merge pull request #256 from danleh/fix-npm-audit 2026-01-14 cbruni@chromium.org Add resource loading bar (#246) 2026-01-13 cbruni@chromium.org Replace prefetch logic (#251) 2026-01-06 kmiller68@users.noreply.github.com Merge pull request #249 from kmiller68/add-verbose-option-to-server 2026-01-06 camillobruni@users.noreply.github.com Add BrowserFileLoader (#242) 2025-12-18 camillobruni@users.noreply.github.com Add --force-gc support (#248) 2025-12-10 kmiller68@users.noreply.github.com Merge pull request #244 from kmiller68/nonStandard-error-rotate-back-to-red 2025-12-10 camillobruni@users.noreply.github.com fewer shell warnings (#234) 2025-11-13 kmiller68@users.noreply.github.com Merge pull request #238 from kmiller68/transformers-js-loads-resources-at-runtime 2025-11-13 ysuzuki@apple.com Merge pull request #239 from Constellation/mod-256 2025-11-12 kmiller68@users.noreply.github.com Merge pull request #225 from kmiller68/reduce-kotlin-iteration-count 2025-11-07 ysuzuki@apple.com Merge pull request #236 from Constellation/use-integer 2025-11-05 camillobruni@users.noreply.github.com sync-fs and async-fs improvements (#217) 2025-11-04 camillobruni@users.noreply.github.com More ubuntu tests (#235) 2025-11-04 kmiller68@users.noreply.github.com Merge pull request #188 from kmiller68/dotnet-legacy-exceptions 2025-10-30 camillobruni@users.noreply.github.com Github Workflow: split tests (#227) 2025-10-30 camillobruni@users.noreply.github.com Enable mobx-startup (#233) 2025-10-30 camillobruni@users.noreply.github.com More top-level cleanup (#229) 2025-10-30 camillobruni@users.noreply.github.com Improve preload code (#230) 2025-10-30 kmiller68@users.noreply.github.com Merge pull request #226 from kmiller68/console-warn-and-error-stderr-clis 2025-10-30 camillobruni@users.noreply.github.com Fix npm run test:build (#232) 2025-10-30 kmiller68@users.noreply.github.com Merge pull request #212 from kmiller68/disable-whisper-wasm 2025-10-29 camillobruni@users.noreply.github.com New Workload: Babylon class-heavy workload (#143) 2025-10-29 camillobruni@users.noreply.github.com Avoid new Date and improve filename extraction in doxbee benchmarks (#231) 2025-10-28 camillobruni@users.noreply.github.com New Workload: mobx observer + startup (#151) 2025-10-28 camillobruni@users.noreply.github.com StartupBenchmark refactoring (#218) 2025-10-27 camillobruni@users.noreply.github.com Add post-quit sleep for Safari (#220) 2025-10-27 kmiller68@users.noreply.github.com Enable jsdom-d3-startup by default. (#223) 2025-10-27 camillobruni@users.noreply.github.com More consistent LICENSE.txt files (#221) 2025-10-27 camillobruni@users.noreply.github.com Move more code to utils (#219) 2025-10-23 camillobruni@users.noreply.github.com Add npm run test:build script (#189) 2025-10-23 kmiller68@users.noreply.github.com Merge pull request #216 from kmiller68/total-to-overall-summary 2025-10-23 camillobruni@users.noreply.github.com render non default params (#197) 2025-10-23 camillobruni@users.noreply.github.com New Workload: JSDOM + d3 (#124) 2025-10-22 camillobruni@users.noreply.github.com Update test.yml (#190) 2025-10-22 camillobruni@users.noreply.github.com Await driver.quit (#209) 2025-10-22 camillobruni@users.noreply.github.com Add explicit version checks (#211) 2025-10-22 camillobruni@users.noreply.github.com Improve iterationCount and worstCaseCount params parsing (#215) 2025-10-22 camillobruni@users.noreply.github.com More consistent total score printing (#213) 2025-10-22 camillobruni@users.noreply.github.com Do not trigger logo animations again after loading all resources (#214) 2025-10-22 camillobruni@users.noreply.github.com support startAutomatically (#201) 2025-10-22 camillobruni@users.noreply.github.com Conditionally show more metric details (#167) 2025-10-22 camillobruni@users.noreply.github.com fix gaussian-blur input data (#207) 2025-10-22 camillobruni@users.noreply.github.com Improve tags (#206) 2025-10-22 camillobruni@users.noreply.github.com update selenium-webdriver version (#208) 2025-10-21 camillobruni@users.noreply.github.com Auto decompress files as part of test running (#195) 2025-10-17 camillobruni@users.noreply.github.com Support multiple comma separate tests in URL params (#198) 2025-10-15 danleh@users.noreply.github.com Merge pull request #77 from Constellation/base64 2025-10-15 camillobruni@users.noreply.github.com Fix prismjs sample file name(#202) 2025-10-08 camillobruni@users.noreply.github.com Add prettier config (#176) 2025-10-07 kmiller68@users.noreply.github.com Merge pull request #170 from eqrion/zlib-compress 2025-10-03 kmiller68@users.noreply.github.com Merge pull request #194 from victorvianna/main 2025-10-03 ysuzuki@apple.com Change shouldReport to report back 2025-10-03 camillobruni@users.noreply.github.com Compact display for non-default params (#191) 2025-10-01 camillobruni@users.noreply.github.com Add group-details parameter to conditionally display grouped benchmarks (#157) 2025-10-01 camillobruni@users.noreply.github.com New Workload: prismjs source code highlighting (#149) 2025-10-01 camillobruni@users.noreply.github.com New Workload: validatorjs regexp heavy workload (#147) 2025-09-23 ysuzuki@apple.com Merge pull request #192 from Constellation/dump-test-list 2025-09-22 camillobruni@users.noreply.github.com New Workload: TypeScript standalone (#117) 2025-09-19 kmiller68@users.noreply.github.com Merge pull request #187 from kmiller68/fix-web-ssr-for-options-bag 2025-09-17 keith_miller@apple.com Test is causing jetsams on iOS. Disabling for now while I investigate. 2025-09-17 camillobruni@users.noreply.github.com Add JetStreamParams (#171) 2025-09-17 camillobruni@users.noreply.github.com New Workload: React Server Side Rendering Startup (#116) 2025-09-17 danleh@users.noreply.github.com Merge pull request #130 from danleh/j2cl-box2d 2025-09-16 danleh@users.noreply.github.com Merge pull request #182 from danleh/recompile-dotnet 2025-09-16 danleh@users.noreply.github.com Merge pull request #148 from danleh/transformersjs-rebase 2025-09-11 camillobruni@users.noreply.github.com Experimental Workload: Intl (#146) 2025-09-10 danleh@users.noreply.github.com Merge pull request #178 from danleh/disable-gcc-loops-quicksort 2025-09-08 kmiller68@users.noreply.github.com Merge pull request #168 from kmiller68/reduce-dotnet-runtime 2025-09-03 camillobruni@users.noreply.github.com More consistent metric reporting (#175) 2025-09-03 camillobruni@users.noreply.github.com Minor browser test improvements (#177) 2025-09-03 danleh@users.noreply.github.com Merge pull request #173 from danleh/text-decoder-polyfill-move 2025-09-03 camillobruni@users.noreply.github.com Remove unused scripts (#174) 2025-09-02 danleh@users.noreply.github.com Merge pull request #172 from danleh/compress-js 2025-09-01 camillobruni@users.noreply.github.com Update/rewrite web-tooling-benchmark (#153) 2025-09-01 camillobruni@users.noreply.github.com Support custom benchmark arguments (#165) 2025-09-01 camillobruni@users.noreply.github.com Status update and CSS fixes (#169) 2025-08-27 camillobruni@users.noreply.github.com Use event.key instead of event.which #166 2025-08-27 danleh@users.noreply.github.com Merge pull request #144 from danleh/logo-text-to-path 2025-08-26 camillobruni@users.noreply.github.com StartupBenchmark: add better assertion failures (#164) 2025-08-26 camillobruni@users.noreply.github.com Add UTF16 sources test (#162) 2025-08-26 camillobruni@users.noreply.github.com Convert startup-helper/BabelCacheBuster.js to esm (#163) 2025-08-26 camillobruni@users.noreply.github.com Add startup benchmark helper (#158) 2025-08-20 danleh@users.noreply.github.com Merge pull request #159 from danleh/dotnet-wasm-rename 2025-08-15 camillobruni@users.noreply.github.com Expose JetStream global to workloads (#139) 2025-08-15 ysuzuki@apple.com Merge pull request #145 from Constellation/tfjs 2025-08-14 camillobruni@users.noreply.github.com Only expose a console copy in the realm (#137) 2025-08-14 kmiller68@users.noreply.github.com Merge pull request #133 from kmiller68/add-grouped-benchmark-for-sunspider 2025-08-14 danleh@users.noreply.github.com Merge pull request #142 from danleh/Dart-remove-unused-runner 2025-08-14 danleh@users.noreply.github.com Merge pull request #140 from danleh/disable-HashSet-wasm 2025-08-14 camillobruni@users.noreply.github.com merge async-fs code (#135) 2025-08-14 camillobruni@users.noreply.github.com Enable UniPoker validation by default (#141) 2025-08-14 danleh@users.noreply.github.com Merge pull request #138 from danleh/kotlin-fix-isD8-access 2025-08-14 camillobruni@users.noreply.github.com Bump selenium-webdriver version (#136) 2025-08-14 danleh@users.noreply.github.com Merge pull request #97 from eqrion/dart-todomvc 2025-08-14 camillobruni@users.noreply.github.com Improve console (#131) 2025-08-14 camillobruni@users.noreply.github.com Improve runner code (#134) 2025-08-14 camillobruni@users.noreply.github.com Rename worst4 to just worst (#129) 2025-08-13 ysuzuki@apple.com Merge pull request #127 from Constellation/list 2025-08-13 danleh@users.noreply.github.com Merge pull request #84 from danleh/kotlin 2025-08-12 camillobruni@users.noreply.github.com CSS fixes for info button (#126) 2025-08-12 camillobruni@users.noreply.github.com Add info-button (#123) 2025-08-11 ysuzuki@apple.com Merge pull request #119 from Constellation/set-status 2025-08-11 camillobruni@users.noreply.github.com Display workload scatterplots (#120) 2025-08-11 camillobruni@users.noreply.github.com Update .gitignore (#121) 2025-08-07 kmiller68@users.noreply.github.com Merge pull request #115 from kmiller68/fix-bencharks-by-tag-testlist 2025-08-06 camillobruni@users.noreply.github.com Configurable resource prefetching (#70) 2025-08-06 camillobruni@users.noreply.github.com github workflow: keep running all tests even if there are failures (#114) 2025-08-05 camillobruni@users.noreply.github.com Add Scripts helper classes (#109) 2025-08-05 iireland@mozilla.com Add three.js benchmark (#75) 2025-08-04 camillobruni@users.noreply.github.com Add validate method for async-fs and sync-fs (#111) 2025-08-04 camillobruni@users.noreply.github.com Add more performance.measure (#110) 2025-07-31 camillobruni@users.noreply.github.com Remove LuaJSFight micro benchmarks (#104) 2025-07-31 camillobruni@users.noreply.github.com Add cli flags (#101) 2025-07-31 camillobruni@users.noreply.github.com Cleanup performance.now shimming (#108) 2025-07-30 camillobruni@users.noreply.github.com Formatting (#105) 2025-07-30 camillobruni@users.noreply.github.com Run all disabled workloads in tests (#103) 2025-07-30 camillobruni@users.noreply.github.com Add benchmarks argument to Driver (#98) 2025-07-29 kmiller68@users.noreply.github.com Merge pull request #102 from kmiller68/reenable-dotnet-tests 2025-07-29 camillobruni@users.noreply.github.com Simplify updateUIAfterRun (#99) 2025-07-29 camillobruni@users.noreply.github.com Merge customTestList and testList (#100) 2025-07-29 camillobruni@users.noreply.github.com Use tags for workload selection (#82) 2025-07-23 danleh@users.noreply.github.com Merge pull request #93 from danleh/cleanup-loadInternal 2025-07-23 kmiller68@users.noreply.github.com Merge pull request #73 from maraf/DotnetWasm 2025-07-21 camillobruni@users.noreply.github.com Fix typo in headers fetch request (#80) 2025-07-15 camillobruni@users.noreply.github.com use default performance.measure implementation (#83) 2025-07-15 camillobruni@users.noreply.github.com Use subScores directly for the UI (#81) 2025-07-15 camillobruni@users.noreply.github.com Add basic unittests (#94) 2025-07-14 camillobruni@users.noreply.github.com Fix accidental loading status clipping in wide windows (#85) 2025-07-14 camillobruni@users.noreply.github.com Simplify formatting (#79) 2025-07-12 kmiller68@users.noreply.github.com Merge pull request #90 from kmiller68/fix-prepareForNextIteration-async-benchmark 2025-07-10 kmiller68@users.noreply.github.com Merge pull request #74 from kmiller68/preload-blobs-wasm 2025-07-08 kmiller68@users.noreply.github.com Merge pull request #76 from kmiller68/zlib-check-_compressFile-to-setupModule 2025-07-02 ysuzuki@apple.com Revert #78 as it broke JetStream3 on web page 2025-07-02 camillobruni@users.noreply.github.com Remove custom run methods #78 2025-06-04 yusukesuzuki@slowstart.org Merge pull request #72 from Constellation/new-string 2025-05-13 kmiller68@users.noreply.github.com Merge pull request #71 from kmiller68/disable-extra-bigint-tests 2025-05-13 camillobruni@users.noreply.github.com Merge pull request #65: OfflineAssembler: Avoid accidental toString operation 2025-05-13 camillobruni@users.noreply.github.com Merge pull request #64: WSL: Add performance.mark 2025-05-13 camillobruni@users.noreply.github.com Merge pull request #60: date-format: Add result hashing to prevent DCE 2025-05-13 camillobruni@users.noreply.github.com Merge pull request #62: Avoid eval in date-format-tofte 2025-05-05 kmiller68@users.noreply.github.com Merge pull request #53 from mkustermann/js-strings 2025-04-24 camillobruni@users.noreply.github.com Merge pull request #67 from issackjohn/issack/add-edge 2025-04-24 camillobruni@users.noreply.github.com Merge pull request #61 from camillobruni/2025-03-26_gbemu_hash 2025-04-07 kmiller68@users.noreply.github.com Merge pull request #59 from camillobruni/2025-03-26_cli_error_handling 2025-04-07 kmiller68@users.noreply.github.com Merge pull request #42 from camillobruni/2025-01-28_cli_tests 2025-04-07 kmiller68@users.noreply.github.com Merge pull request #41 from camillobruni/2025-01-28_runner_log 2025-04-07 kmiller68@users.noreply.github.com Merge pull request #14 from camillobruni/2024-11-26_tags 2025-03-12 kmiller68@users.noreply.github.com Merge pull request #57 from kmiller68/module-url-fix-v2 2025-02-27 kmiller68@users.noreply.github.com Merge pull request #51 from danleh/main 2025-02-27 kmiller68@users.noreply.github.com Merge pull request #52 from kmiller68/pathname-browser-dart 2025-02-26 kmiller68@users.noreply.github.com Merge pull request #33 from danleh/dart-flute-wasm-squash 2025-02-26 kmiller68@users.noreply.github.com Merge pull request #47 from kmiller68/argon2-to-js-scoring-v2 2025-02-26 kmiller68@users.noreply.github.com Merge pull request #40 from danleh/8bitbench-wasm-scoring 2025-02-12 kmiller68@users.noreply.github.com Merge pull request #43 from danleh/zlib-wasm 2025-02-10 kmiller68@users.noreply.github.com Merge pull request #45 from danleh/richards-workload-size-as-input 2025-02-07 kmiller68@users.noreply.github.com Merge pull request #44 from danleh/wasm-workload-sizes 2025-01-28 kmiller68@users.noreply.github.com Merge pull request #39 from camillobruni/2025-01-28_test_runner_fix 2025-01-27 kmiller68@users.noreply.github.com Merge pull request #35 from danleh/hashset-wasm-scoring 2025-01-27 kmiller68@users.noreply.github.com Merge pull request #30 from danleh/sqlite-scoring 2025-01-27 kmiller68@users.noreply.github.com Merge pull request #28 from danleh/quicksort-wasm-scoring 2025-01-27 kmiller68@users.noreply.github.com Merge pull request #37 from WebKit/remove-octane-zlib 2025-01-24 keith_miller@apple.com Revert "Remove Octane-zlib." 2025-01-24 keith_miller@apple.com Remove Octane-zlib. 2025-01-24 kmiller68@users.noreply.github.com Merge pull request #13 from camillobruni/2024-11-22_driver_prep 2025-01-24 kmiller68@users.noreply.github.com Merge pull request #11 from camillobruni/2024-11-26_github_actions 2025-01-23 kmiller68@users.noreply.github.com Merge pull request #27 from danleh/richards-js-scoring 2025-01-22 kmiller68@users.noreply.github.com Merge pull request #34 from WebKit/fix-report-JSON 2025-01-22 kmiller68@users.noreply.github.com Merge pull request #32 from danleh/performance-mark-measure 2025-01-21 kmiller68@users.noreply.github.com Merge pull request #31 from WebKit/revert-tfjs-to-js-scoring 2025-01-21 kmiller68@users.noreply.github.com Merge pull request #16 from camillobruni/2024-11-26_ms 2025-01-21 kmiller68@users.noreply.github.com Merge pull request #26 from danleh/gcc-loops-js-scoring 2025-01-16 kmiller68@users.noreply.github.com Merge pull request #23 from WebKit/tfjs-to-js-scoring 2025-01-16 kmiller68@users.noreply.github.com Merge pull request #17 from camillobruni/2024-11-26_safe_add 2025-01-16 kmiller68@users.noreply.github.com Merge pull request #25 from danleh/spidermonkey-cli-fix 2025-01-08 kmiller68@users.noreply.github.com Merge pull request #21 from WebKit/remove-float-mm-c 2024-12-21 kmiller68@users.noreply.github.com Merge pull request #18 from WebKit/wasm-benchmarks-should-be-scored-like-js-benchmarks 2024-12-20 kmiller68@users.noreply.github.com Merge pull request #2 from danleh/sqlite-wasm 2024-12-09 kmiller68@users.noreply.github.com Merge pull request #5 from camillobruni/2024-11-22_runner_improvements 2024-12-09 kmiller68@users.noreply.github.com Merge pull request #8 from camillobruni/2024-11-22_regexp 2024-12-09 kmiller68@users.noreply.github.com Merge pull request #19 from camillobruni/2024-11-27_async_fs 2024-11-26 kmiller68@users.noreply.github.com Merge pull request #7 from camillobruni/2024-11-22_driver_vars 2024-11-25 kmiller68@users.noreply.github.com Merge pull request #4 from camillobruni/2024-11-22_3dcube_fix 2024-11-25 kmiller68@users.noreply.github.com Merge pull request #6 from camillobruni/2024-11-22_gitignore 2024-11-13 kmiller68@users.noreply.github.com Merge pull request #1 from danleh/main 2024-10-30 keith_miller@apple.com Initial copy from WebKit/PerformanceTests/JetStream3 2024-10-30 kmiller68@users.noreply.github.com Initial commit If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/jetstream-v3-0-custom-v8 Please CC mliedtke@google.com,nicohartmann@google.com,v8-waterfall-gardeners@google.com on the revert to ensure that a human is aware of the problem. To file a bug in JetStream v3.0-custom: https://issues.chromium.org/u/1/issues/new?component=1741045&pli=1&template=0 To file a bug in V8: https://issues.chromium.org/u/1/issues/new?component=1456824&pli=1&template=2109136 To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: mliedtke@google.com,nicohartmann@google.com Change-Id: Ic53c7e030a05111ba56e03ab158282762aa17360 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7823185 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Bot-Commit: chromium-autoroll@skia-public.iam.gserviceaccount.com <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#107273}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced RV_li function that was copyrighted by LLVM. Wrote two algorithms for the case of temporary register available and not available.