Fix assert that is ALWAYS True#45
Closed
cclauss wants to merge 1 commit into
Closed
Conversation
@mi-ac `assert` is not a function in Python so the current assertion would _ALWAYS_ be True.
ceejatec
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Sep 24, 2020
Revision: 84cd9a8 NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true TBR=bmeurer@chromium.org Bug: chromium:1015945 Change-Id: I1a2536f9a5e05a3e7e74ee35626599f3f5482c1e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1898663 Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/branch-heads/7.8@{v8#45} Cr-Branched-From: 73694fd-refs/heads/7.8.279@{#1} Cr-Branched-From: 2314928-refs/heads/master@{#63555}
ceejatec
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Sep 24, 2020
The DCHECK in the lookup method compares the stashed length of the backing store and the byte_length queried on lookup. These two are not guaranteed to be equal as there can be grow calls that update the lenght of the buffer between the length being stashed and the equality check. Bug: chromium:1010272 No-Try: true No-Presubmit: true No-Tree-Checks: true (cherry picked from commit 184e7bb) Change-Id: I5f76529d8aa4fee4ebc11fddacc54c910f3bd714 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1924098 Reviewed-by: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/branch-heads/7.9@{v8#45} Cr-Branched-From: be181e2-refs/heads/7.9.317@{#1} Cr-Branched-From: 0d7889d-refs/heads/master@{#64307}
ceejatec
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Sep 24, 2020
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I4a5a3cf7a7e53c2cfeef20a7f2b8055855c4ec1c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2057035 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/8.0@{v8#45} Cr-Branched-From: 69827db-refs/heads/8.0.426@{v8#2} Cr-Branched-From: 2fe1552-refs/heads/master@{#65318}
ceejatec
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Sep 24, 2020
…tionary This is a reland of 25d1657 Changes from original: replaced slow test with fast test Original change's description: > [runtime] Improve handling of enumeration index on global dictionary > > Bug: chromium:1056054 > Change-Id: Ie1f2da98bc54a2ad5189cbe2ee1686fe1ef7019a > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2079035 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#66504} (cherry picked from commit 5cf5767) Bug: chromium:1056054 Change-Id: I45b9a096b1e37bf1dc5e792f106cdfadd47fabf9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2080855 Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Cr-Original-Commit-Position: refs/heads/master@{#66535} Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2095359 Cr-Commit-Position: refs/branch-heads/8.1@{v8#45} Cr-Branched-From: a4dcd39-refs/heads/8.1.307@{#1} Cr-Branched-From: f22c213-refs/heads/master@{#66031}
ceejatec
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Sep 24, 2020
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I61c2b585b9346073bdb808818f784aed71203099 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2411571 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/8.5@{v8#45} Cr-Branched-From: a7f8bc4-refs/heads/8.5.210@{#1} Cr-Branched-From: dd58472-refs/heads/master@{#68510}
ceejatec
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Sep 24, 2020
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: If2a3b2f547ea523ecf92dd2fb8d48e180190e469 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2329623 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/8.4@{v8#45} Cr-Branched-From: 88ed2e3-refs/heads/8.4.371@{#1} Cr-Branched-From: 35f88bf-refs/heads/master@{#67773}
Author
|
@DeeDeeG your review, please. |
|
This is just a mirror. |
Contributor
|
Sorry for commenting on a closed issue... @cclauss I suppose the process for contributions to V8 upstream are here: https://v8.dev/docs/contribute I would be interested to improve v8 if it helps with the Python 3 transition we have been working on elsewhere (NodeJS ecosystem). To the extent my ability/time allows. |
Kwizatz
pushed a commit
to AeonGames/v8
that referenced
this pull request
Jul 25, 2021
…n debugger" This is a reland of 324768b Rename Interpreter Entry Trampolines to names used in 9.1. Original change's description: > Merged: [sparkplug][debugger] Fix deopt of inlined function in debugger > > We could end up in a baseline entry trampoline without having > baseline code, because of an unhandled interaction in the debugger > (discarding baseline code) and the deoptimizer. > > Bug: chromium:1199681 > > (cherry picked from commit c560e1f) > > No-Try: true > No-Presubmit: true > No-Tree-Checks: true > Tbr: verwaest@chromium.org > Change-Id: Ia33bb4d64903dd989728465b3d83a88b84597a8f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2871447 > Reviewed-by: Patrick Thier <pthier@chromium.org> > Commit-Queue: Patrick Thier <pthier@chromium.org> > Cr-Commit-Position: refs/branch-heads/9.1@{v8#38} > Cr-Branched-From: 0e4ac64-refs/heads/9.1.269@{#1} > Cr-Branched-From: f565e72-refs/heads/master@{#73847} Bug: chromium:1199681 No-Try: true No-Presubmit: true No-Tree-Checks: true Change-Id: I273c10b05941acd9831b16527929033987d3e0bf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2871453 Commit-Queue: Patrick Thier <pthier@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/branch-heads/9.1@{v8#45} Cr-Branched-From: 0e4ac64-refs/heads/9.1.269@{#1} Cr-Branched-From: f565e72-refs/heads/master@{#73847}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
No-Try: true Change-Id: I9cd806089061e52d73aafcb61dc8361a0cd975dc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3061479 Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/branch-heads/9.2@{v8#45} Cr-Branched-From: 5123834-refs/heads/9.2.230@{#1} Cr-Branched-From: 587a04f-refs/heads/master@{#74656}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
Revision: 8f6ecde BUG=chromium:1147917 NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=vahl@chromium.org Change-Id: Ib5052a9068c8ef2de64dc0cc05f18d73fe48f534 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2782281 Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/branch-heads/8.9@{v8#45} Cr-Branched-From: 16b9bbb-refs/heads/8.9.255@{#1} Cr-Branched-From: d16a2a6-refs/heads/master@{#72039}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I4a9de24e3ea72ce5a6d4d51274e27f1dbbee263e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3209206 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/9.4@{v8#45} Cr-Branched-From: 3b51863-refs/heads/9.4.146@{#1} Cr-Branched-From: 2890419-refs/heads/master@{#76233}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I330a52cfaffa868a736fddd3ff75aa1b67ee05c4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3241362 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/9.5@{v8#45} Cr-Branched-From: 4a03d61-refs/heads/9.5.172@{#1} Cr-Branched-From: 9a60704-refs/heads/main@{#76741}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I3ee57be14d116c6b8436556c217daeceddd05f0c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2511071 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/8.6@{v8#45} Cr-Branched-From: a64aed2-refs/heads/8.6.395@{#1} Cr-Branched-From: a626bc0-refs/heads/master@{#69472}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
(cherry picked from commit 7c7cdec) (cherry picked from commit df40e08) Bug: chromium:1198309, v8:5660 No-Try: true No-Presubmit: true No-Tree-Checks: true Change-Id: I9cb5f66643c0c0ab9b18ca953cf85d2f6aa84b42 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2827899 Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Cr-Original-Original-Commit-Position: refs/heads/master@{#74038} Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2844660 Cr-Original-Commit-Position: refs/branch-heads/9.0@{v8#45} Cr-Original-Branched-From: bd0108b-refs/heads/9.0.257@{#1} Cr-Original-Branched-From: 349bcc6-refs/heads/master@{#73001} Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2850704 Reviewed-by: Victor-Gabriel Savu <vsavu@google.com> Commit-Queue: Artem Sumaneev <asumaneev@google.com> Cr-Commit-Position: refs/branch-heads/8.6@{v8#81} Cr-Branched-From: a64aed2-refs/heads/8.6.395@{#1} Cr-Branched-From: a626bc0-refs/heads/master@{#69472}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
Change-Id: I6af3da8561e7471a0c5df80a7ebe3191196dbaf6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3350524 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/9.6@{v8#45} Cr-Branched-From: 0b7bda0-refs/heads/9.6.180@{#1} Cr-Branched-From: 41a5a24-refs/heads/main@{#77244}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
(cherry picked from commit 7c7cdec) Bug: chromium:1198309, v8:5660 No-Try: true No-Presubmit: true No-Tree-Checks: true Change-Id: I9cb5f66643c0c0ab9b18ca953cf85d2f6aa84b42 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2827899 Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#74038} Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2844660 Cr-Commit-Position: refs/branch-heads/9.0@{v8#45} Cr-Branched-From: bd0108b-refs/heads/9.0.257@{#1} Cr-Branched-From: 349bcc6-refs/heads/master@{#73001}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
Port 42e8c23 Because the shift amount may not a 5-bit or 6-bit value, remove the DCHECK in shift operations like x86 and arm platforms; (cherry picked from commit b1033eb) Bug: v8:11123 TBR: Andreas Haas <ahaas@chromium.org> Change-Id: Idccbc2e14eec8d9b3c932004f5732ef8604ac5b6 No-Try: true No-Presubmit: true No-Tree-Checks: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2522297 Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/branch-heads/8.7@{v8#45} Cr-Branched-From: 0d81cd7-refs/heads/8.7.220@{#1} Cr-Branched-From: 942c2ef-refs/heads/master@{#70196}
patrik-lengweiler
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
May 31, 2023
When loading a 32-bit value from the stack, just load 32 bit and zero-extend them into the target register, instead of loading the full 64 bits. As there are things to fix (see https://crbug.com/1356461), we only enable this optimization for Wasm for now. R=jkummerow@chromium.org (cherry picked from commit a382099) Bug: chromium:1395604 No-Try: true No-Presubmit: true No-Tree-Checks: true Change-Id: Ibdd2d80704973362906aec9b38faa762d3b43f3f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4097424 Cr-Original-Commit-Position: refs/heads/main@{#84796} Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4111948 Reviewed-by: Maya Lekova <mslekova@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Roger Felipe Zanoni da Silva <rzanoni@google.com> Cr-Commit-Position: refs/branch-heads/10.2@{v8#45} Cr-Branched-From: 374091f-refs/heads/10.2.154@{#1} Cr-Branched-From: f0c353f-refs/heads/main@{#79976}
patrik-lengweiler
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
May 31, 2023
This is a reland of commit 91fce33 Changes since revert: - Skip added test in no-internalization builds. Original change's description: > [regexp] Handle empty ranges in unicode sets > > If a unicode set operation contains only an empty range, we generated a > set expression without operands. However the expression should match > nothing, so add the special operand not matching anything instead. > > Bug: chromium:1437346 > Change-Id: I8dd58884aaf6915277c80effbda43ea715049146 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4474547 > Commit-Queue: Patrick Thier <pthier@chromium.org> > Reviewed-by: Jakob Linke <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/main@{#87257} Bug: chromium:1437346 (cherry picked from commit cb8697b) Change-Id: I4aa4e3da1a428c23882a27792514e0dd6b354f8d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4502802 Commit-Queue: Patrick Thier <pthier@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/branch-heads/11.2@{v8#45} Cr-Branched-From: 755511a-refs/heads/11.2.214@{#1} Cr-Branched-From: e6b1cce-refs/heads/main@{#86014}
patrik-lengweiler
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
May 31, 2023
Fixed: chromium:1378239 (cherry picked from commit db83e72) Change-Id: I061d5dfe6e4ee24e6d0e7df56e15fbe37752d51e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3982254 Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/branch-heads/10.6@{v8#45} Cr-Branched-From: 41bc743-refs/heads/10.6.194@{#1} Cr-Branched-From: d5f29b9-refs/heads/main@{#82548}
patrik-lengweiler
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
May 31, 2023
Change-Id: If72ddb9fdcc1f33fba2ef13277a8485d4c495ed5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4107472 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/10.8@{v8#45} Cr-Branched-From: f1bc03f-refs/heads/10.8.168@{#1} Cr-Branched-From: 237de89-refs/heads/main@{#83672}
patrik-lengweiler
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
Jun 13, 2023
This reverts commit 1f26e44. Reason for revert: https://crbug.com/1453645#c12 Original change's description: > [arm64][turbofan] Word[32|64]Select support > > Enable the use of csel. > > Change-Id: I6c2d3cc835149ce4beeb7334985ad2c11300d2c8 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4374179 > Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> > Commit-Queue: Martyn Capewell <martyn.capewell@arm.com> > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Cr-Commit-Position: refs/heads/main@{#87165} (cherry picked from commit 51311a8) Bug: chromium:1451929, chromium:1453645 Change-Id: Icbfee84cf4fb65123a68e551b49773d3b39ee4b3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4607615 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/branch-heads/11.4@{v8#45} Cr-Branched-From: 8a8a1e7-refs/heads/11.4.183@{#1} Cr-Branched-From: 5483d8e-refs/heads/main@{#87241}
reposynch Bot
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
Jan 14, 2024
This interacts badly with other optimizations and isn't particularly common. Bug: chromium:1517354 (cherry picked from commit 389ea9b) Change-Id: Ib6a007c97396d72f974282971e9ca7e5cb727023 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5190782 Reviewed-by: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/branch-heads/12.1@{v8#45} Cr-Branched-From: b74ef6f-refs/heads/12.1.285@{#1} Cr-Branched-From: 32857fb-refs/heads/main@{#91313}
hubot
pushed a commit
that referenced
this pull request
Mar 11, 2024
Change-Id: I5775027a91060b867c0a5090ab36799e2162dae4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5363594 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/12.2@{#45} Cr-Branched-From: 6eb5a96-refs/heads/12.2.281@{#1} Cr-Branched-From: 44cf56d-refs/heads/main@{#91934}
hubot
pushed a commit
that referenced
this pull request
Apr 10, 2024
Change-Id: Id7629d1e003ee455606711146074a7653a366711 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5440225 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/12.0@{#45} Cr-Branched-From: ed7b4ca-refs/heads/12.0.267@{#1} Cr-Branched-From: 210e75b-refs/heads/main@{#90651}
hubot
pushed a commit
that referenced
this pull request
Jun 28, 2024
Change-Id: I47fd570247d4c84233c5aa0669d53beca477add7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5665865 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/12.6@{#45} Cr-Branched-From: 3c9fa12-refs/heads/12.6.228@{#2} Cr-Branched-From: 981bb15-refs/heads/main@{#93835}
hubot
pushed a commit
that referenced
this pull request
Aug 26, 2024
Change-Id: I2d2567120b81f81b8eb6f08d4615a59d9e34f079 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5812170 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/12.8@{#45} Cr-Branched-From: 70cbb39-refs/heads/12.8.374@{#1} Cr-Branched-From: 451b63e-refs/heads/main@{#95151}
hubot
pushed a commit
that referenced
this pull request
Sep 26, 2024
Stack walks expect the receiver and closure to be materialized. Bug: 368311899 (cherry picked from commit 6b455eb) Change-Id: Ib5657712dd49fca6c92d881967228e74a5705a9f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5893176 Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/branch-heads/12.9@{#45} Cr-Branched-From: 64a21d7-refs/heads/12.9.202@{#1} Cr-Branched-From: da4200b-refs/heads/main@{#95679}
hubot
pushed a commit
that referenced
this pull request
Dec 16, 2024
…le-block loops Fixed: 383356864 (cherry picked from commit f231d83) Change-Id: I3247f6071a9a27eaef49ae8981b7eea93f83dc55 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6097632 Reviewed-by: Eva Herencsárová <evih@chromium.org> Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Eva Herencsárová <evih@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/branch-heads/13.0@{#45} Cr-Branched-From: 4be854b-refs/heads/13.0.245@{#1} Cr-Branched-From: 1f5183f-refs/heads/main@{#96103}
hubot
pushed a commit
that referenced
this pull request
Dec 16, 2024
Version incremented at https://cr-buildbucket.appspot.com/build/8728362790410085121 Change-Id: I630d0cc5db17fe1ffc131c3ae47d213c15f7c9ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6097761 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/13.2@{#45} Cr-Branched-From: 24068c5-refs/heads/13.2.152@{#1} Cr-Branched-From: 6054ba9-refs/heads/main@{#97085}
hubot
pushed a commit
that referenced
this pull request
Feb 24, 2025
Version incremented at https://cr-buildbucket.appspot.com/build/8722067433502054161 Change-Id: I5290e8f873fca099f84de4df29ccd9b514a2e23a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6297563 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/13.3@{#45} Cr-Branched-From: 41dacff-refs/heads/13.3.415@{#1} Cr-Branched-From: 3348638-refs/heads/main@{#97937}
hubot
pushed a commit
that referenced
this pull request
Jul 3, 2025
Since fast api calls can now also call back to JS there can be multiple active fast c calls at the same time. This means just checking Isolate::InFastCCall() is not enough anymore because this only returns the state of the last CEntry frame. This CL therefore disables code space compaction when a stack is present to allow for multiple/nested fast C calls. Alternatively we could also just e.g. pin code objects referenced from the stack but this would require a bit more work. Bug: 424905890 (cherry picked from commit d4dbd1d) Change-Id: I21b2424469001141a107de36bf228208b37de731 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6701587 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Auto-Submit: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/branch-heads/13.8@{#45} Cr-Branched-From: 61ddd47-refs/heads/13.8.258@{#1} Cr-Branched-From: fdb5de2-refs/heads/main@{#100480}
hubot
pushed a commit
that referenced
this pull request
Jan 23, 2026
Version incremented at https://cr-buildbucket.appspot.com/build/8691863160015265233 Change-Id: If66493441806602629a27376fe7b4652f69ac26c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7509678 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/14.4@{#45} Cr-Branched-From: 80acc26-refs/heads/14.4.258@{#1} Cr-Branched-From: ce7e597-refs/heads/main@{#104020}
hubot
pushed a commit
that referenced
this pull request
Mar 18, 2026
(cherry picked from commit 433b291) Bug: 491884710 Change-Id: Id73c522c6f55cb05167f436c2ee7f60e0db71840 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7673820 Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Darius Mercadier <dmercadier@chromium.org> Cr-Commit-Position: refs/branch-heads/14.6@{#45} Cr-Branched-From: e04c3a1-refs/heads/14.6.202@{#1} Cr-Branched-From: 3b0b01e-refs/heads/main@{#105132}
hubot
pushed a commit
that referenced
this pull request
May 12, 2026
…isions) https://chromium.googlesource.com/external/github.com/WebKit/JetStream.git/+log/2145cedef4ca..91552391bf2f 2026-05-06 cbruni@chromium.org Fix wrong update-ui performance.mark and measure nesting 2026-03-26 cbruni@chromium.org Improve memory script 2026-03-19 cbruni@chromium.org Address comments for memory measurement script 2026-03-19 cbruni@chromium.org Add memory measurement script 2026-03-18 cbruni@chromium.org Actually fix --dump-test-list 2026-03-18 cbruni@chromium.org Fix --dump-test-list and --test in v3.0-custom 2026-03-17 cbruni@chromium.org Update v3.0-custom to latest v3.0 branch 2026-01-30 kmiller68@users.noreply.github.com Merge pull request #272 from danleh/JetStream3.0 2026-01-19 cbruni@chromium.org Reland: Improve Benchmark constructor and instance variables #255 (#263) 2026-01-19 cbruni@chromium.org Reland: Add resource loading bar (#264) 2026-01-19 danleh@users.noreply.github.com Merge pull request #261 from danleh/dotnet-mime-fix 2026-01-17 kmiller68@users.noreply.github.com Merge pull request #262 from kmiller68/revert-replace-prefetch-logic 2026-01-15 kmiller68@users.noreply.github.com Merge pull request #245 from kmiller68/add-open-governance-policy 2026-01-15 danleh@users.noreply.github.com Merge pull request #260 from danleh/readme-addendum 2026-01-14 danleh@users.noreply.github.com Merge pull request #258 from danleh/repo-readme 2026-01-14 cbruni@chromium.org Improve Benchmark constructor and instance variables (#255) 2026-01-14 kmiller68@users.noreply.github.com Merge pull request #254 from kmiller68/scatter-plot-should-increase-with-score 2026-01-14 danleh@users.noreply.github.com Merge pull request #257 from danleh/remove-unused-deps 2026-01-14 cbruni@chromium.org Fix dev server output (#252) 2026-01-14 danleh@users.noreply.github.com Merge pull request #256 from danleh/fix-npm-audit 2026-01-14 cbruni@chromium.org Add resource loading bar (#246) 2026-01-13 cbruni@chromium.org Replace prefetch logic (#251) 2026-01-06 kmiller68@users.noreply.github.com Merge pull request #249 from kmiller68/add-verbose-option-to-server 2026-01-06 camillobruni@users.noreply.github.com Add BrowserFileLoader (#242) 2025-12-18 camillobruni@users.noreply.github.com Add --force-gc support (#248) 2025-12-10 kmiller68@users.noreply.github.com Merge pull request #244 from kmiller68/nonStandard-error-rotate-back-to-red 2025-12-10 camillobruni@users.noreply.github.com fewer shell warnings (#234) 2025-11-13 kmiller68@users.noreply.github.com Merge pull request #238 from kmiller68/transformers-js-loads-resources-at-runtime 2025-11-13 ysuzuki@apple.com Merge pull request #239 from Constellation/mod-256 2025-11-12 kmiller68@users.noreply.github.com Merge pull request #225 from kmiller68/reduce-kotlin-iteration-count 2025-11-07 ysuzuki@apple.com Merge pull request #236 from Constellation/use-integer 2025-11-05 camillobruni@users.noreply.github.com sync-fs and async-fs improvements (#217) 2025-11-04 camillobruni@users.noreply.github.com More ubuntu tests (#235) 2025-11-04 kmiller68@users.noreply.github.com Merge pull request #188 from kmiller68/dotnet-legacy-exceptions 2025-10-30 camillobruni@users.noreply.github.com Github Workflow: split tests (#227) 2025-10-30 camillobruni@users.noreply.github.com Enable mobx-startup (#233) 2025-10-30 camillobruni@users.noreply.github.com More top-level cleanup (#229) 2025-10-30 camillobruni@users.noreply.github.com Improve preload code (#230) 2025-10-30 kmiller68@users.noreply.github.com Merge pull request #226 from kmiller68/console-warn-and-error-stderr-clis 2025-10-30 camillobruni@users.noreply.github.com Fix npm run test:build (#232) 2025-10-30 kmiller68@users.noreply.github.com Merge pull request #212 from kmiller68/disable-whisper-wasm 2025-10-29 camillobruni@users.noreply.github.com New Workload: Babylon class-heavy workload (#143) 2025-10-29 camillobruni@users.noreply.github.com Avoid new Date and improve filename extraction in doxbee benchmarks (#231) 2025-10-28 camillobruni@users.noreply.github.com New Workload: mobx observer + startup (#151) 2025-10-28 camillobruni@users.noreply.github.com StartupBenchmark refactoring (#218) 2025-10-27 camillobruni@users.noreply.github.com Add post-quit sleep for Safari (#220) 2025-10-27 kmiller68@users.noreply.github.com Enable jsdom-d3-startup by default. (#223) 2025-10-27 camillobruni@users.noreply.github.com More consistent LICENSE.txt files (#221) 2025-10-27 camillobruni@users.noreply.github.com Move more code to utils (#219) 2025-10-23 camillobruni@users.noreply.github.com Add npm run test:build script (#189) 2025-10-23 kmiller68@users.noreply.github.com Merge pull request #216 from kmiller68/total-to-overall-summary 2025-10-23 camillobruni@users.noreply.github.com render non default params (#197) 2025-10-23 camillobruni@users.noreply.github.com New Workload: JSDOM + d3 (#124) 2025-10-22 camillobruni@users.noreply.github.com Update test.yml (#190) 2025-10-22 camillobruni@users.noreply.github.com Await driver.quit (#209) 2025-10-22 camillobruni@users.noreply.github.com Add explicit version checks (#211) 2025-10-22 camillobruni@users.noreply.github.com Improve iterationCount and worstCaseCount params parsing (#215) 2025-10-22 camillobruni@users.noreply.github.com More consistent total score printing (#213) 2025-10-22 camillobruni@users.noreply.github.com Do not trigger logo animations again after loading all resources (#214) 2025-10-22 camillobruni@users.noreply.github.com support startAutomatically (#201) 2025-10-22 camillobruni@users.noreply.github.com Conditionally show more metric details (#167) 2025-10-22 camillobruni@users.noreply.github.com fix gaussian-blur input data (#207) 2025-10-22 camillobruni@users.noreply.github.com Improve tags (#206) 2025-10-22 camillobruni@users.noreply.github.com update selenium-webdriver version (#208) 2025-10-21 camillobruni@users.noreply.github.com Auto decompress files as part of test running (#195) 2025-10-17 camillobruni@users.noreply.github.com Support multiple comma separate tests in URL params (#198) 2025-10-15 danleh@users.noreply.github.com Merge pull request #77 from Constellation/base64 2025-10-15 camillobruni@users.noreply.github.com Fix prismjs sample file name(#202) 2025-10-08 camillobruni@users.noreply.github.com Add prettier config (#176) 2025-10-07 kmiller68@users.noreply.github.com Merge pull request #170 from eqrion/zlib-compress 2025-10-03 kmiller68@users.noreply.github.com Merge pull request #194 from victorvianna/main 2025-10-03 ysuzuki@apple.com Change shouldReport to report back 2025-10-03 camillobruni@users.noreply.github.com Compact display for non-default params (#191) 2025-10-01 camillobruni@users.noreply.github.com Add group-details parameter to conditionally display grouped benchmarks (#157) 2025-10-01 camillobruni@users.noreply.github.com New Workload: prismjs source code highlighting (#149) 2025-10-01 camillobruni@users.noreply.github.com New Workload: validatorjs regexp heavy workload (#147) 2025-09-23 ysuzuki@apple.com Merge pull request #192 from Constellation/dump-test-list 2025-09-22 camillobruni@users.noreply.github.com New Workload: TypeScript standalone (#117) 2025-09-19 kmiller68@users.noreply.github.com Merge pull request #187 from kmiller68/fix-web-ssr-for-options-bag 2025-09-17 keith_miller@apple.com Test is causing jetsams on iOS. Disabling for now while I investigate. 2025-09-17 camillobruni@users.noreply.github.com Add JetStreamParams (#171) 2025-09-17 camillobruni@users.noreply.github.com New Workload: React Server Side Rendering Startup (#116) 2025-09-17 danleh@users.noreply.github.com Merge pull request #130 from danleh/j2cl-box2d 2025-09-16 danleh@users.noreply.github.com Merge pull request #182 from danleh/recompile-dotnet 2025-09-16 danleh@users.noreply.github.com Merge pull request #148 from danleh/transformersjs-rebase 2025-09-11 camillobruni@users.noreply.github.com Experimental Workload: Intl (#146) 2025-09-10 danleh@users.noreply.github.com Merge pull request #178 from danleh/disable-gcc-loops-quicksort 2025-09-08 kmiller68@users.noreply.github.com Merge pull request #168 from kmiller68/reduce-dotnet-runtime 2025-09-03 camillobruni@users.noreply.github.com More consistent metric reporting (#175) 2025-09-03 camillobruni@users.noreply.github.com Minor browser test improvements (#177) 2025-09-03 danleh@users.noreply.github.com Merge pull request #173 from danleh/text-decoder-polyfill-move 2025-09-03 camillobruni@users.noreply.github.com Remove unused scripts (#174) 2025-09-02 danleh@users.noreply.github.com Merge pull request #172 from danleh/compress-js 2025-09-01 camillobruni@users.noreply.github.com Update/rewrite web-tooling-benchmark (#153) 2025-09-01 camillobruni@users.noreply.github.com Support custom benchmark arguments (#165) 2025-09-01 camillobruni@users.noreply.github.com Status update and CSS fixes (#169) 2025-08-27 camillobruni@users.noreply.github.com Use event.key instead of event.which #166 2025-08-27 danleh@users.noreply.github.com Merge pull request #144 from danleh/logo-text-to-path 2025-08-26 camillobruni@users.noreply.github.com StartupBenchmark: add better assertion failures (#164) 2025-08-26 camillobruni@users.noreply.github.com Add UTF16 sources test (#162) 2025-08-26 camillobruni@users.noreply.github.com Convert startup-helper/BabelCacheBuster.js to esm (#163) 2025-08-26 camillobruni@users.noreply.github.com Add startup benchmark helper (#158) 2025-08-20 danleh@users.noreply.github.com Merge pull request #159 from danleh/dotnet-wasm-rename 2025-08-15 camillobruni@users.noreply.github.com Expose JetStream global to workloads (#139) 2025-08-15 ysuzuki@apple.com Merge pull request #145 from Constellation/tfjs 2025-08-14 camillobruni@users.noreply.github.com Only expose a console copy in the realm (#137) 2025-08-14 kmiller68@users.noreply.github.com Merge pull request #133 from kmiller68/add-grouped-benchmark-for-sunspider 2025-08-14 danleh@users.noreply.github.com Merge pull request #142 from danleh/Dart-remove-unused-runner 2025-08-14 danleh@users.noreply.github.com Merge pull request #140 from danleh/disable-HashSet-wasm 2025-08-14 camillobruni@users.noreply.github.com merge async-fs code (#135) 2025-08-14 camillobruni@users.noreply.github.com Enable UniPoker validation by default (#141) 2025-08-14 danleh@users.noreply.github.com Merge pull request #138 from danleh/kotlin-fix-isD8-access 2025-08-14 camillobruni@users.noreply.github.com Bump selenium-webdriver version (#136) 2025-08-14 danleh@users.noreply.github.com Merge pull request #97 from eqrion/dart-todomvc 2025-08-14 camillobruni@users.noreply.github.com Improve console (#131) 2025-08-14 camillobruni@users.noreply.github.com Improve runner code (#134) 2025-08-14 camillobruni@users.noreply.github.com Rename worst4 to just worst (#129) 2025-08-13 ysuzuki@apple.com Merge pull request #127 from Constellation/list 2025-08-13 danleh@users.noreply.github.com Merge pull request #84 from danleh/kotlin 2025-08-12 camillobruni@users.noreply.github.com CSS fixes for info button (#126) 2025-08-12 camillobruni@users.noreply.github.com Add info-button (#123) 2025-08-11 ysuzuki@apple.com Merge pull request #119 from Constellation/set-status 2025-08-11 camillobruni@users.noreply.github.com Display workload scatterplots (#120) 2025-08-11 camillobruni@users.noreply.github.com Update .gitignore (#121) 2025-08-07 kmiller68@users.noreply.github.com Merge pull request #115 from kmiller68/fix-bencharks-by-tag-testlist 2025-08-06 camillobruni@users.noreply.github.com Configurable resource prefetching (#70) 2025-08-06 camillobruni@users.noreply.github.com github workflow: keep running all tests even if there are failures (#114) 2025-08-05 camillobruni@users.noreply.github.com Add Scripts helper classes (#109) 2025-08-05 iireland@mozilla.com Add three.js benchmark (#75) 2025-08-04 camillobruni@users.noreply.github.com Add validate method for async-fs and sync-fs (#111) 2025-08-04 camillobruni@users.noreply.github.com Add more performance.measure (#110) 2025-07-31 camillobruni@users.noreply.github.com Remove LuaJSFight micro benchmarks (#104) 2025-07-31 camillobruni@users.noreply.github.com Add cli flags (#101) 2025-07-31 camillobruni@users.noreply.github.com Cleanup performance.now shimming (#108) 2025-07-30 camillobruni@users.noreply.github.com Formatting (#105) 2025-07-30 camillobruni@users.noreply.github.com Run all disabled workloads in tests (#103) 2025-07-30 camillobruni@users.noreply.github.com Add benchmarks argument to Driver (#98) 2025-07-29 kmiller68@users.noreply.github.com Merge pull request #102 from kmiller68/reenable-dotnet-tests 2025-07-29 camillobruni@users.noreply.github.com Simplify updateUIAfterRun (#99) 2025-07-29 camillobruni@users.noreply.github.com Merge customTestList and testList (#100) 2025-07-29 camillobruni@users.noreply.github.com Use tags for workload selection (#82) 2025-07-23 danleh@users.noreply.github.com Merge pull request #93 from danleh/cleanup-loadInternal 2025-07-23 kmiller68@users.noreply.github.com Merge pull request #73 from maraf/DotnetWasm 2025-07-21 camillobruni@users.noreply.github.com Fix typo in headers fetch request (#80) 2025-07-15 camillobruni@users.noreply.github.com use default performance.measure implementation (#83) 2025-07-15 camillobruni@users.noreply.github.com Use subScores directly for the UI (#81) 2025-07-15 camillobruni@users.noreply.github.com Add basic unittests (#94) 2025-07-14 camillobruni@users.noreply.github.com Fix accidental loading status clipping in wide windows (#85) 2025-07-14 camillobruni@users.noreply.github.com Simplify formatting (#79) 2025-07-12 kmiller68@users.noreply.github.com Merge pull request #90 from kmiller68/fix-prepareForNextIteration-async-benchmark 2025-07-10 kmiller68@users.noreply.github.com Merge pull request #74 from kmiller68/preload-blobs-wasm 2025-07-08 kmiller68@users.noreply.github.com Merge pull request #76 from kmiller68/zlib-check-_compressFile-to-setupModule 2025-07-02 ysuzuki@apple.com Revert #78 as it broke JetStream3 on web page 2025-07-02 camillobruni@users.noreply.github.com Remove custom run methods #78 2025-06-04 yusukesuzuki@slowstart.org Merge pull request #72 from Constellation/new-string 2025-05-13 kmiller68@users.noreply.github.com Merge pull request #71 from kmiller68/disable-extra-bigint-tests 2025-05-13 camillobruni@users.noreply.github.com Merge pull request #65: OfflineAssembler: Avoid accidental toString operation 2025-05-13 camillobruni@users.noreply.github.com Merge pull request #64: WSL: Add performance.mark 2025-05-13 camillobruni@users.noreply.github.com Merge pull request #60: date-format: Add result hashing to prevent DCE 2025-05-13 camillobruni@users.noreply.github.com Merge pull request #62: Avoid eval in date-format-tofte 2025-05-05 kmiller68@users.noreply.github.com Merge pull request #53 from mkustermann/js-strings 2025-04-24 camillobruni@users.noreply.github.com Merge pull request #67 from issackjohn/issack/add-edge 2025-04-24 camillobruni@users.noreply.github.com Merge pull request #61 from camillobruni/2025-03-26_gbemu_hash 2025-04-07 kmiller68@users.noreply.github.com Merge pull request #59 from camillobruni/2025-03-26_cli_error_handling 2025-04-07 kmiller68@users.noreply.github.com Merge pull request #42 from camillobruni/2025-01-28_cli_tests 2025-04-07 kmiller68@users.noreply.github.com Merge pull request #41 from camillobruni/2025-01-28_runner_log 2025-04-07 kmiller68@users.noreply.github.com Merge pull request #14 from camillobruni/2024-11-26_tags 2025-03-12 kmiller68@users.noreply.github.com Merge pull request #57 from kmiller68/module-url-fix-v2 2025-02-27 kmiller68@users.noreply.github.com Merge pull request #51 from danleh/main 2025-02-27 kmiller68@users.noreply.github.com Merge pull request #52 from kmiller68/pathname-browser-dart 2025-02-26 kmiller68@users.noreply.github.com Merge pull request #33 from danleh/dart-flute-wasm-squash 2025-02-26 kmiller68@users.noreply.github.com Merge pull request #47 from kmiller68/argon2-to-js-scoring-v2 2025-02-26 kmiller68@users.noreply.github.com Merge pull request #40 from danleh/8bitbench-wasm-scoring 2025-02-12 kmiller68@users.noreply.github.com Merge pull request #43 from danleh/zlib-wasm 2025-02-10 kmiller68@users.noreply.github.com Merge pull request #45 from danleh/richards-workload-size-as-input 2025-02-07 kmiller68@users.noreply.github.com Merge pull request #44 from danleh/wasm-workload-sizes 2025-01-28 kmiller68@users.noreply.github.com Merge pull request #39 from camillobruni/2025-01-28_test_runner_fix 2025-01-27 kmiller68@users.noreply.github.com Merge pull request #35 from danleh/hashset-wasm-scoring 2025-01-27 kmiller68@users.noreply.github.com Merge pull request #30 from danleh/sqlite-scoring 2025-01-27 kmiller68@users.noreply.github.com Merge pull request #28 from danleh/quicksort-wasm-scoring 2025-01-27 kmiller68@users.noreply.github.com Merge pull request #37 from WebKit/remove-octane-zlib 2025-01-24 keith_miller@apple.com Revert "Remove Octane-zlib." 2025-01-24 keith_miller@apple.com Remove Octane-zlib. 2025-01-24 kmiller68@users.noreply.github.com Merge pull request #13 from camillobruni/2024-11-22_driver_prep 2025-01-24 kmiller68@users.noreply.github.com Merge pull request #11 from camillobruni/2024-11-26_github_actions 2025-01-23 kmiller68@users.noreply.github.com Merge pull request #27 from danleh/richards-js-scoring 2025-01-22 kmiller68@users.noreply.github.com Merge pull request #34 from WebKit/fix-report-JSON 2025-01-22 kmiller68@users.noreply.github.com Merge pull request #32 from danleh/performance-mark-measure 2025-01-21 kmiller68@users.noreply.github.com Merge pull request #31 from WebKit/revert-tfjs-to-js-scoring 2025-01-21 kmiller68@users.noreply.github.com Merge pull request #16 from camillobruni/2024-11-26_ms 2025-01-21 kmiller68@users.noreply.github.com Merge pull request #26 from danleh/gcc-loops-js-scoring 2025-01-16 kmiller68@users.noreply.github.com Merge pull request #23 from WebKit/tfjs-to-js-scoring 2025-01-16 kmiller68@users.noreply.github.com Merge pull request #17 from camillobruni/2024-11-26_safe_add 2025-01-16 kmiller68@users.noreply.github.com Merge pull request #25 from danleh/spidermonkey-cli-fix 2025-01-08 kmiller68@users.noreply.github.com Merge pull request #21 from WebKit/remove-float-mm-c 2024-12-21 kmiller68@users.noreply.github.com Merge pull request #18 from WebKit/wasm-benchmarks-should-be-scored-like-js-benchmarks 2024-12-20 kmiller68@users.noreply.github.com Merge pull request #2 from danleh/sqlite-wasm 2024-12-09 kmiller68@users.noreply.github.com Merge pull request #5 from camillobruni/2024-11-22_runner_improvements 2024-12-09 kmiller68@users.noreply.github.com Merge pull request #8 from camillobruni/2024-11-22_regexp 2024-12-09 kmiller68@users.noreply.github.com Merge pull request #19 from camillobruni/2024-11-27_async_fs 2024-11-26 kmiller68@users.noreply.github.com Merge pull request #7 from camillobruni/2024-11-22_driver_vars 2024-11-25 kmiller68@users.noreply.github.com Merge pull request #4 from camillobruni/2024-11-22_3dcube_fix 2024-11-25 kmiller68@users.noreply.github.com Merge pull request #6 from camillobruni/2024-11-22_gitignore 2024-11-13 kmiller68@users.noreply.github.com Merge pull request #1 from danleh/main 2024-10-30 keith_miller@apple.com Initial copy from WebKit/PerformanceTests/JetStream3 2024-10-30 kmiller68@users.noreply.github.com Initial commit If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/jetstream-v3-0-custom-v8 Please CC mliedtke@google.com,nicohartmann@google.com,v8-waterfall-gardeners@google.com on the revert to ensure that a human is aware of the problem. To file a bug in JetStream v3.0-custom: https://issues.chromium.org/u/1/issues/new?component=1741045&pli=1&template=0 To file a bug in V8: https://issues.chromium.org/u/1/issues/new?component=1456824&pli=1&template=2109136 To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: mliedtke@google.com,nicohartmann@google.com Change-Id: Ic53c7e030a05111ba56e03ab158282762aa17360 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7823185 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Bot-Commit: chromium-autoroll@skia-public.iam.gserviceaccount.com <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#107273}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mi-ac
assertis not a function in Python so the current assertion would ALWAYS be True.